From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7DB5C10F11 for ; Thu, 11 Apr 2019 03:11:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9D81421850 for ; Thu, 11 Apr 2019 03:11:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726814AbfDKDLZ (ORCPT ); Wed, 10 Apr 2019 23:11:25 -0400 Received: from Mailgw01.mediatek.com ([1.203.163.78]:19919 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726247AbfDKDLY (ORCPT ); Wed, 10 Apr 2019 23:11:24 -0400 X-UUID: fe850397add14cafb76e7970b5182ae8-20190411 X-UUID: fe850397add14cafb76e7970b5182ae8-20190411 Received: from mtkcas35.mediatek.inc [(172.27.4.253)] by mailgw01.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 1926004032; Thu, 11 Apr 2019 11:11:12 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31DR.mediatek.inc (172.27.6.102) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 11 Apr 2019 11:11:10 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 11 Apr 2019 11:11:09 +0800 Message-ID: <1554952269.10179.185.camel@mhfsdcap03> Subject: Re: [v3 PATCH 4/6] usb: roles: add API to get usb_role_switch by node From: Chunfeng Yun To: Heikki Krogerus CC: Rob Herring , Greg Kroah-Hartman , Mark Rutland , "Matthias Brugger" , Adam Thomson , Li Jun , "Badhri Jagan Sridharan" , Hans de Goede , Andy Shevchenko , Min Guo , Alan Stern , , , , , Date: Thu, 11 Apr 2019 11:11:09 +0800 In-Reply-To: <20190410102239.GG20058@kuha.fi.intel.com> References: <1554257354-7440-1-git-send-email-chunfeng.yun@mediatek.com> <1554257354-7440-5-git-send-email-chunfeng.yun@mediatek.com> <20190410102239.GG20058@kuha.fi.intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2019-04-10 at 13:22 +0300, Heikki Krogerus wrote: > On Wed, Apr 03, 2019 at 10:09:12AM +0800, Chunfeng Yun wrote: > > Add fwnode_usb_role_switch_get() to make easier to get > > usb_role_switch by fwnode which register it. > > It's useful when there is not device_connection registered > > between two drivers and only knows the fwnode which register > > usb_role_switch. > > > > Signed-off-by: Chunfeng Yun > > --- > > v3 changes: > > 1. use fwnodes instead of node suggested by Andy > > 2. rebuild the API suggested by Heikki > > > > v2 no changes > > --- > > drivers/usb/roles/class.c | 31 +++++++++++++++++++++++++++++++ > > include/linux/usb/role.h | 2 ++ > > 2 files changed, 33 insertions(+) > > > > diff --git a/drivers/usb/roles/class.c b/drivers/usb/roles/class.c > > index f45d8df5cfb8..5ecb57f8960b 100644 > > --- a/drivers/usb/roles/class.c > > +++ b/drivers/usb/roles/class.c > > @@ -12,6 +12,7 @@ > > #include > > #include > > #include > > +#include > > #include > > > > static struct class *role_class; > > @@ -135,6 +136,36 @@ struct usb_role_switch *usb_role_switch_get(struct device *dev) > > } > > EXPORT_SYMBOL_GPL(usb_role_switch_get); > > > > +static int __switch_match_fwnode(struct device *dev, const void *fwnode) > > +{ > > + return dev_fwnode(dev->parent) == (const struct fwnode_handle *)fwnode; > > +} > > I don't think this is actually needed. Yes, you are right > Why not just assign the > parent's fwnode for the mux as well? will do it in next version > > I'll add an example to the patch 6/6 in this series. > > > +/** > > + * fwnode_usb_role_switch_get - Find USB role switch by it's parent fwnode > > + * @fwnode: The fwnode that register USB role switch > > + * > > + * Finds and returns role switch registered by @fwnode. The reference count > > + * for the found switch is incremented. > > + */ > > +struct usb_role_switch * > > +fwnode_usb_role_switch_get(struct fwnode_handle *fwnode) > > +{ > > + struct usb_role_switch *sw; > > + struct device *dev; > > + > > + dev = class_find_device(role_class, NULL, fwnode, > > + __switch_match_fwnode); > > So here you can then reuse switch_fwnode_match(): > > dev = class_find_device(role_class, NULL, fwnode, switch_fwnode_match); I make a fast test, it works, thanks a lot Heikki > > > + if (!dev) > > + return ERR_PTR(-EPROBE_DEFER); > > + > > + sw = to_role_switch(dev); > > + WARN_ON(!try_module_get(sw->dev.parent->driver->owner)); > > + > > + return sw; > > +} > > +EXPORT_SYMBOL_GPL(fwnode_usb_role_switch_get); > > + > > /** > > * usb_role_switch_put - Release handle to a switch > > * @sw: USB Role Switch > > diff --git a/include/linux/usb/role.h b/include/linux/usb/role.h > > index c05ffa6abda9..d21cd55d9e45 100644 > > --- a/include/linux/usb/role.h > > +++ b/include/linux/usb/role.h > > @@ -46,6 +46,8 @@ int usb_role_switch_set_role(struct usb_role_switch *sw, enum usb_role role); > > enum usb_role usb_role_switch_get_role(struct usb_role_switch *sw); > > struct usb_role_switch *usb_role_switch_get(struct device *dev); > > void usb_role_switch_put(struct usb_role_switch *sw); > > +struct usb_role_switch * > > +fwnode_usb_role_switch_get(struct fwnode_handle *fwnode); > > > > struct usb_role_switch * > > usb_role_switch_register(struct device *parent, > > -- > > 2.20.1 > > thanks, > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chunfeng Yun Subject: Re: [v3 PATCH 4/6] usb: roles: add API to get usb_role_switch by node Date: Thu, 11 Apr 2019 11:11:09 +0800 Message-ID: <1554952269.10179.185.camel@mhfsdcap03> References: <1554257354-7440-1-git-send-email-chunfeng.yun@mediatek.com> <1554257354-7440-5-git-send-email-chunfeng.yun@mediatek.com> <20190410102239.GG20058@kuha.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190410102239.GG20058@kuha.fi.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Heikki Krogerus Cc: Mark Rutland , devicetree@vger.kernel.org, Hans de Goede , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Badhri Jagan Sridharan , Andy Shevchenko , Rob Herring , Alan Stern , Min Guo , Matthias Brugger , linux-mediatek@lists.infradead.org, Adam Thomson , linux-arm-kernel@lists.infradead.org, Li Jun List-Id: devicetree@vger.kernel.org On Wed, 2019-04-10 at 13:22 +0300, Heikki Krogerus wrote: > On Wed, Apr 03, 2019 at 10:09:12AM +0800, Chunfeng Yun wrote: > > Add fwnode_usb_role_switch_get() to make easier to get > > usb_role_switch by fwnode which register it. > > It's useful when there is not device_connection registered > > between two drivers and only knows the fwnode which register > > usb_role_switch. > > > > Signed-off-by: Chunfeng Yun > > --- > > v3 changes: > > 1. use fwnodes instead of node suggested by Andy > > 2. rebuild the API suggested by Heikki > > > > v2 no changes > > --- > > drivers/usb/roles/class.c | 31 +++++++++++++++++++++++++++++++ > > include/linux/usb/role.h | 2 ++ > > 2 files changed, 33 insertions(+) > > > > diff --git a/drivers/usb/roles/class.c b/drivers/usb/roles/class.c > > index f45d8df5cfb8..5ecb57f8960b 100644 > > --- a/drivers/usb/roles/class.c > > +++ b/drivers/usb/roles/class.c > > @@ -12,6 +12,7 @@ > > #include > > #include > > #include > > +#include > > #include > > > > static struct class *role_class; > > @@ -135,6 +136,36 @@ struct usb_role_switch *usb_role_switch_get(struct device *dev) > > } > > EXPORT_SYMBOL_GPL(usb_role_switch_get); > > > > +static int __switch_match_fwnode(struct device *dev, const void *fwnode) > > +{ > > + return dev_fwnode(dev->parent) == (const struct fwnode_handle *)fwnode; > > +} > > I don't think this is actually needed. Yes, you are right > Why not just assign the > parent's fwnode for the mux as well? will do it in next version > > I'll add an example to the patch 6/6 in this series. > > > +/** > > + * fwnode_usb_role_switch_get - Find USB role switch by it's parent fwnode > > + * @fwnode: The fwnode that register USB role switch > > + * > > + * Finds and returns role switch registered by @fwnode. The reference count > > + * for the found switch is incremented. > > + */ > > +struct usb_role_switch * > > +fwnode_usb_role_switch_get(struct fwnode_handle *fwnode) > > +{ > > + struct usb_role_switch *sw; > > + struct device *dev; > > + > > + dev = class_find_device(role_class, NULL, fwnode, > > + __switch_match_fwnode); > > So here you can then reuse switch_fwnode_match(): > > dev = class_find_device(role_class, NULL, fwnode, switch_fwnode_match); I make a fast test, it works, thanks a lot Heikki > > > + if (!dev) > > + return ERR_PTR(-EPROBE_DEFER); > > + > > + sw = to_role_switch(dev); > > + WARN_ON(!try_module_get(sw->dev.parent->driver->owner)); > > + > > + return sw; > > +} > > +EXPORT_SYMBOL_GPL(fwnode_usb_role_switch_get); > > + > > /** > > * usb_role_switch_put - Release handle to a switch > > * @sw: USB Role Switch > > diff --git a/include/linux/usb/role.h b/include/linux/usb/role.h > > index c05ffa6abda9..d21cd55d9e45 100644 > > --- a/include/linux/usb/role.h > > +++ b/include/linux/usb/role.h > > @@ -46,6 +46,8 @@ int usb_role_switch_set_role(struct usb_role_switch *sw, enum usb_role role); > > enum usb_role usb_role_switch_get_role(struct usb_role_switch *sw); > > struct usb_role_switch *usb_role_switch_get(struct device *dev); > > void usb_role_switch_put(struct usb_role_switch *sw); > > +struct usb_role_switch * > > +fwnode_usb_role_switch_get(struct fwnode_handle *fwnode); > > > > struct usb_role_switch * > > usb_role_switch_register(struct device *parent, > > -- > > 2.20.1 > > thanks, > From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v3,4/6] usb: roles: add API to get usb_role_switch by node From: Chunfeng Yun Message-Id: <1554952269.10179.185.camel@mhfsdcap03> Date: Thu, 11 Apr 2019 11:11:09 +0800 To: Heikki Krogerus Cc: Rob Herring , Greg Kroah-Hartman , Mark Rutland , Matthias Brugger , Adam Thomson , Li Jun , Badhri Jagan Sridharan , Hans de Goede , Andy Shevchenko , Min Guo , Alan Stern , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org List-ID: T24gV2VkLCAyMDE5LTA0LTEwIGF0IDEzOjIyICswMzAwLCBIZWlra2kgS3JvZ2VydXMgd3JvdGU6 Cj4gT24gV2VkLCBBcHIgMDMsIDIwMTkgYXQgMTA6MDk6MTJBTSArMDgwMCwgQ2h1bmZlbmcgWXVu IHdyb3RlOgo+ID4gQWRkIGZ3bm9kZV91c2Jfcm9sZV9zd2l0Y2hfZ2V0KCkgdG8gbWFrZSBlYXNp ZXIgdG8gZ2V0Cj4gPiB1c2Jfcm9sZV9zd2l0Y2ggYnkgZndub2RlIHdoaWNoIHJlZ2lzdGVyIGl0 Lgo+ID4gSXQncyB1c2VmdWwgd2hlbiB0aGVyZSBpcyBub3QgZGV2aWNlX2Nvbm5lY3Rpb24gcmVn aXN0ZXJlZAo+ID4gYmV0d2VlbiB0d28gZHJpdmVycyBhbmQgb25seSBrbm93cyB0aGUgZndub2Rl IHdoaWNoIHJlZ2lzdGVyCj4gPiB1c2Jfcm9sZV9zd2l0Y2guCj4gPiAKPiA+IFNpZ25lZC1vZmYt Ynk6IENodW5mZW5nIFl1biA8Y2h1bmZlbmcueXVuQG1lZGlhdGVrLmNvbT4KPiA+IC0tLQo+ID4g djMgY2hhbmdlczoKPiA+ICAgMS4gdXNlIGZ3bm9kZXMgaW5zdGVhZCBvZiBub2RlIHN1Z2dlc3Rl ZCBieSBBbmR5Cj4gPiAgIDIuIHJlYnVpbGQgdGhlIEFQSSBzdWdnZXN0ZWQgYnkgSGVpa2tpCj4g PiAKPiA+IHYyIG5vIGNoYW5nZXMKPiA+IC0tLQo+ID4gIGRyaXZlcnMvdXNiL3JvbGVzL2NsYXNz LmMgfCAzMSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gPiAgaW5jbHVkZS9saW51 eC91c2Ivcm9sZS5oICB8ICAyICsrCj4gPiAgMiBmaWxlcyBjaGFuZ2VkLCAzMyBpbnNlcnRpb25z KCspCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3VzYi9yb2xlcy9jbGFzcy5jIGIvZHJp dmVycy91c2Ivcm9sZXMvY2xhc3MuYwo+ID4gaW5kZXggZjQ1ZDhkZjVjZmI4Li41ZWNiNTdmODk2 MGIgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL3VzYi9yb2xlcy9jbGFzcy5jCj4gPiArKysgYi9k cml2ZXJzL3VzYi9yb2xlcy9jbGFzcy5jCj4gPiBAQCAtMTIsNiArMTIsNyBAQAo+ID4gICNpbmNs dWRlIDxsaW51eC9kZXZpY2UuaD4KPiA+ICAjaW5jbHVkZSA8bGludXgvbW9kdWxlLmg+Cj4gPiAg I2luY2x1ZGUgPGxpbnV4L211dGV4Lmg+Cj4gPiArI2luY2x1ZGUgPGxpbnV4L29mLmg+Cj4gPiAg I2luY2x1ZGUgPGxpbnV4L3NsYWIuaD4KPiA+ICAKPiA+ICBzdGF0aWMgc3RydWN0IGNsYXNzICpy b2xlX2NsYXNzOwo+ID4gQEAgLTEzNSw2ICsxMzYsMzYgQEAgc3RydWN0IHVzYl9yb2xlX3N3aXRj aCAqdXNiX3JvbGVfc3dpdGNoX2dldChzdHJ1Y3QgZGV2aWNlICpkZXYpCj4gPiAgfQo+ID4gIEVY UE9SVF9TWU1CT0xfR1BMKHVzYl9yb2xlX3N3aXRjaF9nZXQpOwo+ID4gIAo+ID4gK3N0YXRpYyBp bnQgX19zd2l0Y2hfbWF0Y2hfZndub2RlKHN0cnVjdCBkZXZpY2UgKmRldiwgY29uc3Qgdm9pZCAq Zndub2RlKQo+ID4gK3sKPiA+ICsJcmV0dXJuIGRldl9md25vZGUoZGV2LT5wYXJlbnQpID09IChj b25zdCBzdHJ1Y3QgZndub2RlX2hhbmRsZSAqKWZ3bm9kZTsKPiA+ICt9Cj4gCj4gSSBkb24ndCB0 aGluayB0aGlzIGlzIGFjdHVhbGx5IG5lZWRlZC4gClllcywgeW91IGFyZSByaWdodAoKPiBXaHkg bm90IGp1c3QgYXNzaWduIHRoZQo+IHBhcmVudCdzIGZ3bm9kZSBmb3IgdGhlIG11eCBhcyB3ZWxs Pwp3aWxsIGRvIGl0IGluIG5leHQgdmVyc2lvbgoKPiAKPiBJJ2xsIGFkZCBhbiBleGFtcGxlIHRv IHRoZSBwYXRjaCA2LzYgaW4gdGhpcyBzZXJpZXMuCj4gCj4gPiArLyoqCj4gPiArICogZndub2Rl X3VzYl9yb2xlX3N3aXRjaF9nZXQgLSBGaW5kIFVTQiByb2xlIHN3aXRjaCBieSBpdCdzIHBhcmVu dCBmd25vZGUKPiA+ICsgKiBAZndub2RlOiBUaGUgZndub2RlIHRoYXQgcmVnaXN0ZXIgVVNCIHJv bGUgc3dpdGNoCj4gPiArICoKPiA+ICsgKiBGaW5kcyBhbmQgcmV0dXJucyByb2xlIHN3aXRjaCBy ZWdpc3RlcmVkIGJ5IEBmd25vZGUuIFRoZSByZWZlcmVuY2UgY291bnQKPiA+ICsgKiBmb3IgdGhl IGZvdW5kIHN3aXRjaCBpcyBpbmNyZW1lbnRlZC4KPiA+ICsgKi8KPiA+ICtzdHJ1Y3QgdXNiX3Jv bGVfc3dpdGNoICoKPiA+ICtmd25vZGVfdXNiX3JvbGVfc3dpdGNoX2dldChzdHJ1Y3QgZndub2Rl X2hhbmRsZSAqZndub2RlKQo+ID4gK3sKPiA+ICsJc3RydWN0IHVzYl9yb2xlX3N3aXRjaCAqc3c7 Cj4gPiArCXN0cnVjdCBkZXZpY2UgKmRldjsKPiA+ICsKPiA+ICsJZGV2ID0gY2xhc3NfZmluZF9k ZXZpY2Uocm9sZV9jbGFzcywgTlVMTCwgZndub2RlLAo+ID4gKwkJCQlfX3N3aXRjaF9tYXRjaF9m d25vZGUpOwo+IAo+IFNvIGhlcmUgeW91IGNhbiB0aGVuIHJldXNlIHN3aXRjaF9md25vZGVfbWF0 Y2goKToKPiAKPiAJZGV2ID0gY2xhc3NfZmluZF9kZXZpY2Uocm9sZV9jbGFzcywgTlVMTCwgZndu b2RlLCBzd2l0Y2hfZndub2RlX21hdGNoKTsKSSBtYWtlIGEgZmFzdCB0ZXN0LCBpdCB3b3Jrcywg dGhhbmtzIGEgbG90IEhlaWtraQoKPiAKPiA+ICsJaWYgKCFkZXYpCj4gPiArCQlyZXR1cm4gRVJS X1BUUigtRVBST0JFX0RFRkVSKTsKPiA+ICsKPiA+ICsJc3cgPSB0b19yb2xlX3N3aXRjaChkZXYp Owo+ID4gKwlXQVJOX09OKCF0cnlfbW9kdWxlX2dldChzdy0+ZGV2LnBhcmVudC0+ZHJpdmVyLT5v d25lcikpOwo+ID4gKwo+ID4gKwlyZXR1cm4gc3c7Cj4gPiArfQo+ID4gK0VYUE9SVF9TWU1CT0xf R1BMKGZ3bm9kZV91c2Jfcm9sZV9zd2l0Y2hfZ2V0KTsKPiA+ICsKPiA+ICAvKioKPiA+ICAgKiB1 c2Jfcm9sZV9zd2l0Y2hfcHV0IC0gUmVsZWFzZSBoYW5kbGUgdG8gYSBzd2l0Y2gKPiA+ICAgKiBA c3c6IFVTQiBSb2xlIFN3aXRjaAo+ID4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvdXNiL3Jv bGUuaCBiL2luY2x1ZGUvbGludXgvdXNiL3JvbGUuaAo+ID4gaW5kZXggYzA1ZmZhNmFiZGE5Li5k MjFjZDU1ZDllNDUgMTAwNjQ0Cj4gPiAtLS0gYS9pbmNsdWRlL2xpbnV4L3VzYi9yb2xlLmgKPiA+ ICsrKyBiL2luY2x1ZGUvbGludXgvdXNiL3JvbGUuaAo+ID4gQEAgLTQ2LDYgKzQ2LDggQEAgaW50 IHVzYl9yb2xlX3N3aXRjaF9zZXRfcm9sZShzdHJ1Y3QgdXNiX3JvbGVfc3dpdGNoICpzdywgZW51 bSB1c2Jfcm9sZSByb2xlKTsKPiA+ICBlbnVtIHVzYl9yb2xlIHVzYl9yb2xlX3N3aXRjaF9nZXRf cm9sZShzdHJ1Y3QgdXNiX3JvbGVfc3dpdGNoICpzdyk7Cj4gPiAgc3RydWN0IHVzYl9yb2xlX3N3 aXRjaCAqdXNiX3JvbGVfc3dpdGNoX2dldChzdHJ1Y3QgZGV2aWNlICpkZXYpOwo+ID4gIHZvaWQg dXNiX3JvbGVfc3dpdGNoX3B1dChzdHJ1Y3QgdXNiX3JvbGVfc3dpdGNoICpzdyk7Cj4gPiArc3Ry dWN0IHVzYl9yb2xlX3N3aXRjaCAqCj4gPiArZndub2RlX3VzYl9yb2xlX3N3aXRjaF9nZXQoc3Ry dWN0IGZ3bm9kZV9oYW5kbGUgKmZ3bm9kZSk7Cj4gPiAgCj4gPiAgc3RydWN0IHVzYl9yb2xlX3N3 aXRjaCAqCj4gPiAgdXNiX3JvbGVfc3dpdGNoX3JlZ2lzdGVyKHN0cnVjdCBkZXZpY2UgKnBhcmVu dCwKPiA+IC0tIAo+ID4gMi4yMC4xCj4gCj4gdGhhbmtzLAo+Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E5D9C10F14 for ; Thu, 11 Apr 2019 03:11:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2CDEF20818 for ; Thu, 11 Apr 2019 03:11:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QYkp5yF/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2CDEF20818 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JnPgSA0In8Slb/ohRE0RjzLT9xvON9+1nSOGnPF6lBU=; b=QYkp5yF/H8wP/Q +DXAkF/o8m/TfPflaH7otr0Z0WiBv7CIavRkjXoYFijQvQ6NZiJUp4P7KENhrA8L4wXqQ4W5PK6G/ TaT1aVvU3eV3ovHQLMkjbk/aGFYyljeBC0JmOfzOu8cBnwvDBuuV0WmL8w7j4w0yD+ieLSgM4Nf3T DnPznU3WBOZytzfcJBhMETrb81ZHTcjBvr2mKgegwah2y0MOOswqLxT7hn/ybAJjouASjXg2IcIY1 ImyxtzLXhGb2RzegIOcsoqNDfQHbShlLfzIbVtydJ7n97aPGjPbLiZjie7olWZwWOrKiDTlK8/B1D XLKoYg7SM6cLCaxjfsWA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEQ7W-0002ya-7Z; Thu, 11 Apr 2019 03:11:22 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEQ7S-0002yE-SL; Thu, 11 Apr 2019 03:11:20 +0000 X-UUID: cfb858ee201d4eba82dbef2cbfc0b56b-20190410 X-UUID: cfb858ee201d4eba82dbef2cbfc0b56b-20190410 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1192692369; Wed, 10 Apr 2019 19:11:14 -0800 Received: from MTKMBS31DR.mediatek.inc (172.27.6.102) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 10 Apr 2019 20:11:13 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31DR.mediatek.inc (172.27.6.102) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 11 Apr 2019 11:11:10 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 11 Apr 2019 11:11:09 +0800 Message-ID: <1554952269.10179.185.camel@mhfsdcap03> Subject: Re: [v3 PATCH 4/6] usb: roles: add API to get usb_role_switch by node From: Chunfeng Yun To: Heikki Krogerus Date: Thu, 11 Apr 2019 11:11:09 +0800 In-Reply-To: <20190410102239.GG20058@kuha.fi.intel.com> References: <1554257354-7440-1-git-send-email-chunfeng.yun@mediatek.com> <1554257354-7440-5-git-send-email-chunfeng.yun@mediatek.com> <20190410102239.GG20058@kuha.fi.intel.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190410_201118_922960_57CBD1D3 X-CRM114-Status: GOOD ( 21.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Hans de Goede , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Badhri Jagan Sridharan , Andy Shevchenko , Rob Herring , Alan Stern , Min Guo , Matthias Brugger , linux-mediatek@lists.infradead.org, Adam Thomson , linux-arm-kernel@lists.infradead.org, Li Jun Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2019-04-10 at 13:22 +0300, Heikki Krogerus wrote: > On Wed, Apr 03, 2019 at 10:09:12AM +0800, Chunfeng Yun wrote: > > Add fwnode_usb_role_switch_get() to make easier to get > > usb_role_switch by fwnode which register it. > > It's useful when there is not device_connection registered > > between two drivers and only knows the fwnode which register > > usb_role_switch. > > > > Signed-off-by: Chunfeng Yun > > --- > > v3 changes: > > 1. use fwnodes instead of node suggested by Andy > > 2. rebuild the API suggested by Heikki > > > > v2 no changes > > --- > > drivers/usb/roles/class.c | 31 +++++++++++++++++++++++++++++++ > > include/linux/usb/role.h | 2 ++ > > 2 files changed, 33 insertions(+) > > > > diff --git a/drivers/usb/roles/class.c b/drivers/usb/roles/class.c > > index f45d8df5cfb8..5ecb57f8960b 100644 > > --- a/drivers/usb/roles/class.c > > +++ b/drivers/usb/roles/class.c > > @@ -12,6 +12,7 @@ > > #include > > #include > > #include > > +#include > > #include > > > > static struct class *role_class; > > @@ -135,6 +136,36 @@ struct usb_role_switch *usb_role_switch_get(struct device *dev) > > } > > EXPORT_SYMBOL_GPL(usb_role_switch_get); > > > > +static int __switch_match_fwnode(struct device *dev, const void *fwnode) > > +{ > > + return dev_fwnode(dev->parent) == (const struct fwnode_handle *)fwnode; > > +} > > I don't think this is actually needed. Yes, you are right > Why not just assign the > parent's fwnode for the mux as well? will do it in next version > > I'll add an example to the patch 6/6 in this series. > > > +/** > > + * fwnode_usb_role_switch_get - Find USB role switch by it's parent fwnode > > + * @fwnode: The fwnode that register USB role switch > > + * > > + * Finds and returns role switch registered by @fwnode. The reference count > > + * for the found switch is incremented. > > + */ > > +struct usb_role_switch * > > +fwnode_usb_role_switch_get(struct fwnode_handle *fwnode) > > +{ > > + struct usb_role_switch *sw; > > + struct device *dev; > > + > > + dev = class_find_device(role_class, NULL, fwnode, > > + __switch_match_fwnode); > > So here you can then reuse switch_fwnode_match(): > > dev = class_find_device(role_class, NULL, fwnode, switch_fwnode_match); I make a fast test, it works, thanks a lot Heikki > > > + if (!dev) > > + return ERR_PTR(-EPROBE_DEFER); > > + > > + sw = to_role_switch(dev); > > + WARN_ON(!try_module_get(sw->dev.parent->driver->owner)); > > + > > + return sw; > > +} > > +EXPORT_SYMBOL_GPL(fwnode_usb_role_switch_get); > > + > > /** > > * usb_role_switch_put - Release handle to a switch > > * @sw: USB Role Switch > > diff --git a/include/linux/usb/role.h b/include/linux/usb/role.h > > index c05ffa6abda9..d21cd55d9e45 100644 > > --- a/include/linux/usb/role.h > > +++ b/include/linux/usb/role.h > > @@ -46,6 +46,8 @@ int usb_role_switch_set_role(struct usb_role_switch *sw, enum usb_role role); > > enum usb_role usb_role_switch_get_role(struct usb_role_switch *sw); > > struct usb_role_switch *usb_role_switch_get(struct device *dev); > > void usb_role_switch_put(struct usb_role_switch *sw); > > +struct usb_role_switch * > > +fwnode_usb_role_switch_get(struct fwnode_handle *fwnode); > > > > struct usb_role_switch * > > usb_role_switch_register(struct device *parent, > > -- > > 2.20.1 > > thanks, > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel