Re: [clk:clk-fixes 4/4] WARNING: vmlinux.o(.text.unlikely+0x42409): Section mismatch in reference from the function pmc_setup_dev.isra.4() to the variable .init.rodata:critclk_systems

From: Stephen Boyd <sboyd@kernel.org>
To: David Müller <dave.mueller@gmx.ch>, kbuild test robot <lkp@intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	kbuild-all@01.org, linux-arm-kernel@lists.infradead.org,
	linux-clk@vger.kernel.org
Subject: Re: [clk:clk-fixes 4/4] WARNING: vmlinux.o(.text.unlikely+0x42409): Section mismatch in reference from the function pmc_setup_dev.isra.4() to the variable .init.rodata:critclk_systems
Date: Thu, 11 Apr 2019 10:22:21 -0700	[thread overview]
Message-ID: <155500334169.20095.13193425884744090405@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <201904111738.Ncw2Vf01%lkp@intel.com>

Quoting kbuild test robot (2019-04-11 02:25:41)
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-fixes
> head:   7c2e07130090ae001a97a6b65597830d6815e93e
> commit: 7c2e07130090ae001a97a6b65597830d6815e93e [4/4] clk: x86: Add system specific quirk to mark clocks as critical
> config: x86_64-randconfig-s4-04111213 (attached as .config)
> compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
> reproduce:
>         git checkout 7c2e07130090ae001a97a6b65597830d6815e93e
>         # save the attached .config to linux build tree
>         make ARCH=x86_64 
> 
> All warnings (new ones prefixed by >>):
> 
> >> WARNING: vmlinux.o(.text.unlikely+0x42409): Section mismatch in reference from the function pmc_setup_dev.isra.4() to the variable .init.rodata:critclk_systems
>    The function pmc_setup_dev.isra.4() references
>    the variable __initconst critclk_systems.
>    This is often because pmc_setup_dev.isra.4 lacks a __initconst
>    annotation or the annotation of critclk_systems is wrong.
> 

I don't know why there's __initconst there at all.

---8<----

diff --git a/drivers/platform/x86/pmc_atom.c b/drivers/platform/x86/pmc_atom.c
index eaec2d306481..c7039f52ad51 100644
--- a/drivers/platform/x86/pmc_atom.c
+++ b/drivers/platform/x86/pmc_atom.c
@@ -396,7 +396,7 @@ static int pmc_dbgfs_register(struct pmc_dev *pmc)
  * Some systems need one or more of their pmc_plt_clks to be
  * marked as critical.
  */
-static const struct dmi_system_id critclk_systems[] __initconst = {
+static const struct dmi_system_id critclk_systems[] = {
 	{
 		.ident = "MPL CEC1x",
 		.matches = {

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
