From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B015FC10F0E for ; Fri, 12 Apr 2019 15:49:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8784C20693 for ; Fri, 12 Apr 2019 15:49:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726925AbfDLPtt (ORCPT ); Fri, 12 Apr 2019 11:49:49 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:45635 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726702AbfDLPtt (ORCPT ); Fri, 12 Apr 2019 11:49:49 -0400 Received: from kresse.hi.pengutronix.de ([2001:67c:670:100:1d::2a]) by metis.ext.pengutronix.de with esmtp (Exim 4.89) (envelope-from ) id 1hEyQv-0008GX-3L; Fri, 12 Apr 2019 17:49:41 +0200 Message-ID: <1555084180.11529.27.camel@pengutronix.de> Subject: Re: [PATCH v3 01/11] PCI: imx6: Simplify imx7d_pcie_wait_for_phy_pll_lock() From: Lucas Stach To: Andrey Smirnov , linux-pci@vger.kernel.org Cc: Lorenzo Pieralisi , Bjorn Helgaas , Fabio Estevam , Chris Healy , Leonard Crestez , "A.s. Dong" , Richard Zhu , linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Fri, 12 Apr 2019 17:49:40 +0200 In-Reply-To: <20190401042547.14067-2-andrew.smirnov@gmail.com> References: <20190401042547.14067-1-andrew.smirnov@gmail.com> <20190401042547.14067-2-andrew.smirnov@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::2a X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Sonntag, den 31.03.2019, 21:25 -0700 schrieb Andrey Smirnov: > Make use of regmap_read_poll_timeout() to simplify > imx7d_pcie_wait_for_phy_pll_lock(). No functional change intended. > > > Cc: Lorenzo Pieralisi > > Cc: Bjorn Helgaas > > Cc: Fabio Estevam > > Cc: Chris Healy > > Cc: Lucas Stach > > Cc: Leonard Crestez > > Cc: "A.s. Dong" > > Cc: Richard Zhu > Cc: linux-imx@nxp.com > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-pci@vger.kernel.org > Signed-off-by: Andrey Smirnov Reviewed-by: Lucas Stach > --- >  drivers/pci/controller/dwc/pci-imx6.c | 21 +++++++-------------- >  1 file changed, 7 insertions(+), 14 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c > index 2eb39d5de4f6..fb0b29e5b1f0 100644 > --- a/drivers/pci/controller/dwc/pci-imx6.c > +++ b/drivers/pci/controller/dwc/pci-imx6.c > @@ -89,9 +89,8 @@ struct imx6_pcie { >  }; >   >  /* Parameters for the waiting for PCIe PHY PLL to lock on i.MX7 */ > > -#define PHY_PLL_LOCK_WAIT_MAX_RETRIES 2000 > > -#define PHY_PLL_LOCK_WAIT_USLEEP_MIN 50 > >  #define PHY_PLL_LOCK_WAIT_USLEEP_MAX 200 > > +#define PHY_PLL_LOCK_WAIT_TIMEOUT (2000 * PHY_PLL_LOCK_WAIT_USLEEP_MAX) >   >  /* PCIe Root Complex registers (memory-mapped) */ > >  #define PCIE_RC_IMX6_MSI_CAP 0x50 > @@ -488,20 +487,14 @@ static int imx6_pcie_enable_ref_clk(struct imx6_pcie *imx6_pcie) >  static void imx7d_pcie_wait_for_phy_pll_lock(struct imx6_pcie *imx6_pcie) >  { > >   u32 val; > > - unsigned int retries; > >   struct device *dev = imx6_pcie->pci->dev; >   > > - for (retries = 0; retries < PHY_PLL_LOCK_WAIT_MAX_RETRIES; retries++) { > > - regmap_read(imx6_pcie->iomuxc_gpr, IOMUXC_GPR22, &val); > - > > - if (val & IMX7D_GPR22_PCIE_PHY_PLL_LOCKED) > > - return; > - > > - usleep_range(PHY_PLL_LOCK_WAIT_USLEEP_MIN, > > -      PHY_PLL_LOCK_WAIT_USLEEP_MAX); > > - } > - > > - dev_err(dev, "PCIe PLL lock timeout\n"); > > + if (regmap_read_poll_timeout(imx6_pcie->iomuxc_gpr, > > +      IOMUXC_GPR22, val, > > +      val & IMX7D_GPR22_PCIE_PHY_PLL_LOCKED, > > +      PHY_PLL_LOCK_WAIT_USLEEP_MAX, > > +      PHY_PLL_LOCK_WAIT_TIMEOUT)) > > + dev_err(dev, "PCIe PLL lock timeout\n"); >  } >   >  static void imx6_pcie_deassert_core_reset(struct imx6_pcie *imx6_pcie) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A5DDC10F14 for ; Fri, 12 Apr 2019 15:49:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 659E920693 for ; Fri, 12 Apr 2019 15:49:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QmHw8qzT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 659E920693 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=edY7MvavOXA0hq1aCTsAoTm21Pw07OYXtCSOOzZt7Pg=; b=QmHw8qzT0Nua2c oUikt/7utLs999qWwTXMazyLx100y8N5A/a5xDq0M3S23Su7Db3CAtnL5dD3bj6LdA5d/mb2mJVOB eidPLdjCcFsrGz9GOx2ARyHPWevU3wVZKsv1epfIMH10OVkqsHYV0HJ4LpvSKuT43ZpYIl9IH05lL YMEkvIAtIEzmzXrWUnHkA11M+o/FENviszIF1+YN19M4q8gwroE5Ycgh/IQlC0qBQsQQ6XjOuQeDW Ic8dfomSW1HuvZwFLhoEYSojcEVHI8Q3xcF7KqS97RmqeGdi/i3RRMiz7i5EdxE687B2pBIKXSxJy 19/0aJfmPT69jwpGJgmg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEyR7-0000eF-J7; Fri, 12 Apr 2019 15:49:53 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEyR4-0000dW-C6 for linux-arm-kernel@lists.infradead.org; Fri, 12 Apr 2019 15:49:52 +0000 Received: from kresse.hi.pengutronix.de ([2001:67c:670:100:1d::2a]) by metis.ext.pengutronix.de with esmtp (Exim 4.89) (envelope-from ) id 1hEyQv-0008GX-3L; Fri, 12 Apr 2019 17:49:41 +0200 Message-ID: <1555084180.11529.27.camel@pengutronix.de> Subject: Re: [PATCH v3 01/11] PCI: imx6: Simplify imx7d_pcie_wait_for_phy_pll_lock() From: Lucas Stach To: Andrey Smirnov , linux-pci@vger.kernel.org Date: Fri, 12 Apr 2019 17:49:40 +0200 In-Reply-To: <20190401042547.14067-2-andrew.smirnov@gmail.com> References: <20190401042547.14067-1-andrew.smirnov@gmail.com> <20190401042547.14067-2-andrew.smirnov@gmail.com> X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::2a X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190412_084950_586475_DCA9C90D X-CRM114-Status: GOOD ( 14.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "A.s. Dong" , Lorenzo Pieralisi , Richard Zhu , linux-kernel@vger.kernel.org, Fabio Estevam , linux-imx@nxp.com, Bjorn Helgaas , Leonard Crestez , Chris Healy , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org QW0gU29ubnRhZywgZGVuIDMxLjAzLjIwMTksIDIxOjI1IC0wNzAwIHNjaHJpZWIgQW5kcmV5IFNt aXJub3Y6Cj4gTWFrZSB1c2Ugb2YgcmVnbWFwX3JlYWRfcG9sbF90aW1lb3V0KCkgdG8gc2ltcGxp ZnkKPiBpbXg3ZF9wY2llX3dhaXRfZm9yX3BoeV9wbGxfbG9jaygpLiBObyBmdW5jdGlvbmFsIGNo YW5nZSBpbnRlbmRlZC4KPiAKPiA+IENjOiBMb3JlbnpvIFBpZXJhbGlzaSA8bG9yZW56by5waWVy YWxpc2lAYXJtLmNvbT4KPiA+IENjOiBCam9ybiBIZWxnYWFzIDxiaGVsZ2Fhc0Bnb29nbGUuY29t Pgo+ID4gQ2M6IEZhYmlvIEVzdGV2YW0gPGZhYmlvLmVzdGV2YW1AbnhwLmNvbT4KPiA+IENjOiBD aHJpcyBIZWFseSA8Y3BoZWFseUBnbWFpbC5jb20+Cj4gPiBDYzogTHVjYXMgU3RhY2ggPGwuc3Rh Y2hAcGVuZ3V0cm9uaXguZGU+Cj4gPiBDYzogTGVvbmFyZCBDcmVzdGV6IDxsZW9uYXJkLmNyZXN0 ZXpAbnhwLmNvbT4KPiA+IENjOiAiQS5zLiBEb25nIiA8YWlzaGVuZy5kb25nQG54cC5jb20+Cj4g PiBDYzogUmljaGFyZCBaaHUgPGhvbmd4aW5nLnpodUBueHAuY29tPgo+IENjOiBsaW51eC1pbXhA bnhwLmNvbQo+IENjOiBsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKPiBDYzog bGludXgta2VybmVsQHZnZXIua2VybmVsLm9yZwo+IENjOiBsaW51eC1wY2lAdmdlci5rZXJuZWwu b3JnCj4gU2lnbmVkLW9mZi1ieTogQW5kcmV5IFNtaXJub3YgPGFuZHJldy5zbWlybm92QGdtYWls LmNvbT4KClJldmlld2VkLWJ5OiBMdWNhcyBTdGFjaCA8bC5zdGFjaEBwZW5ndXRyb25peC5kZT4K Cj4gLS0tCj4gwqBkcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2ktaW14Ni5jIHwgMjEgKysr KysrKy0tLS0tLS0tLS0tLS0tCj4gwqAxIGZpbGUgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspLCAx NCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9wY2kvY29udHJvbGxlci9k d2MvcGNpLWlteDYuYyBiL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1pbXg2LmMKPiBp bmRleCAyZWIzOWQ1ZGU0ZjYuLmZiMGIyOWU1YjFmMCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3Bj aS9jb250cm9sbGVyL2R3Yy9wY2ktaW14Ni5jCj4gKysrIGIvZHJpdmVycy9wY2kvY29udHJvbGxl ci9kd2MvcGNpLWlteDYuYwo+IEBAIC04OSw5ICs4OSw4IEBAIHN0cnVjdCBpbXg2X3BjaWUgewo+ IMKgfTsKPiDCoAo+IMKgLyogUGFyYW1ldGVycyBmb3IgdGhlIHdhaXRpbmcgZm9yIFBDSWUgUEhZ IFBMTCB0byBsb2NrIG9uIGkuTVg3ICovCj4gPiAtI2RlZmluZSBQSFlfUExMX0xPQ0tfV0FJVF9N QVhfUkVUUklFUwkyMDAwCj4gPiAtI2RlZmluZSBQSFlfUExMX0xPQ0tfV0FJVF9VU0xFRVBfTUlO CTUwCj4gPiDCoCNkZWZpbmUgUEhZX1BMTF9MT0NLX1dBSVRfVVNMRUVQX01BWAkyMDAKPiA+ICsj ZGVmaW5lIFBIWV9QTExfTE9DS19XQUlUX1RJTUVPVVQJKDIwMDAgKiBQSFlfUExMX0xPQ0tfV0FJ VF9VU0xFRVBfTUFYKQo+IMKgCj4gwqAvKiBQQ0llIFJvb3QgQ29tcGxleCByZWdpc3RlcnMgKG1l bW9yeS1tYXBwZWQpICovCj4gPiDCoCNkZWZpbmUgUENJRV9SQ19JTVg2X01TSV9DQVAJCQkweDUw Cj4gQEAgLTQ4OCwyMCArNDg3LDE0IEBAIHN0YXRpYyBpbnQgaW14Nl9wY2llX2VuYWJsZV9yZWZf Y2xrKHN0cnVjdCBpbXg2X3BjaWUgKmlteDZfcGNpZSkKPiDCoHN0YXRpYyB2b2lkIGlteDdkX3Bj aWVfd2FpdF9mb3JfcGh5X3BsbF9sb2NrKHN0cnVjdCBpbXg2X3BjaWUgKmlteDZfcGNpZSkKPiDC oHsKPiA+IMKgCXUzMiB2YWw7Cj4gPiAtCXVuc2lnbmVkIGludCByZXRyaWVzOwo+ID4gwqAJc3Ry dWN0IGRldmljZSAqZGV2ID0gaW14Nl9wY2llLT5wY2ktPmRldjsKPiDCoAo+ID4gLQlmb3IgKHJl dHJpZXMgPSAwOyByZXRyaWVzIDwgUEhZX1BMTF9MT0NLX1dBSVRfTUFYX1JFVFJJRVM7IHJldHJp ZXMrKykgewo+ID4gLQkJcmVnbWFwX3JlYWQoaW14Nl9wY2llLT5pb211eGNfZ3ByLCBJT01VWENf R1BSMjIsICZ2YWwpOwo+IC0KPiA+IC0JCWlmICh2YWwgJiBJTVg3RF9HUFIyMl9QQ0lFX1BIWV9Q TExfTE9DS0VEKQo+ID4gLQkJCXJldHVybjsKPiAtCj4gPiAtCQl1c2xlZXBfcmFuZ2UoUEhZX1BM TF9MT0NLX1dBSVRfVVNMRUVQX01JTiwKPiA+IC0JCQnCoMKgwqDCoMKgUEhZX1BMTF9MT0NLX1dB SVRfVVNMRUVQX01BWCk7Cj4gPiAtCX0KPiAtCj4gPiAtCWRldl9lcnIoZGV2LCAiUENJZSBQTEwg bG9jayB0aW1lb3V0XG4iKTsKPiA+ICsJaWYgKHJlZ21hcF9yZWFkX3BvbGxfdGltZW91dChpbXg2 X3BjaWUtPmlvbXV4Y19ncHIsCj4gPiArCQkJCcKgwqDCoMKgwqBJT01VWENfR1BSMjIsIHZhbCwK PiA+ICsJCQkJwqDCoMKgwqDCoHZhbCAmIElNWDdEX0dQUjIyX1BDSUVfUEhZX1BMTF9MT0NLRUQs Cj4gPiArCQkJCcKgwqDCoMKgwqBQSFlfUExMX0xPQ0tfV0FJVF9VU0xFRVBfTUFYLAo+ID4gKwkJ CQnCoMKgwqDCoMKgUEhZX1BMTF9MT0NLX1dBSVRfVElNRU9VVCkpCj4gPiArCQlkZXZfZXJyKGRl diwgIlBDSWUgUExMIGxvY2sgdGltZW91dFxuIik7Cj4gwqB9Cj4gwqAKPiDCoHN0YXRpYyB2b2lk IGlteDZfcGNpZV9kZWFzc2VydF9jb3JlX3Jlc2V0KHN0cnVjdCBpbXg2X3BjaWUgKmlteDZfcGNp ZSkKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4 LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFk Lm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFy bS1rZXJuZWwK