From: Valdis.Kletnieks@vt.edu (Valdis.Kletnieks at vt.edu)
To: kernelnewbies@lists.kernelnewbies.org
Subject: Bug Patch
Date: Mon, 08 Sep 2014 14:08:24 -0400 [thread overview]
Message-ID: <15552.1410199704@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Mon, 08 Sep 2014 06:36:34 -0400." <540D86B2.6080505@gmail.com>
On Mon, 08 Sep 2014 06:36:34 -0400, nick said:
> Found a bug and attempted to fix it
> sub_skb = dev_alloc_skb(nSubframe_Length + 12);
> + if (!sub_skb)
> + return -ENOMEM;
Nick - we've told you before to research this stuff more fully before
posting patches. As others have pointed out, there's exactly one caller, who
wants a different return on error.
For bonus points - explain why you're returning a -ENOMEM from
a function that's declared as 'static u8 parse_subframe(...'.
This is *NOT* how you convince us that you should be allowed anywhere near
kernel code.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 848 bytes
Desc: not available
Url : http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20140908/c4a2a560/attachment.bin
next prev parent reply other threads:[~2014-09-08 18:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-08 10:36 Bug Patch nick
2014-09-08 11:10 ` Sudip Mukherjee
2014-09-08 11:21 ` Tobias S. Josefowitz
2014-09-08 11:35 ` Sudip Mukherjee
2014-09-08 12:45 ` Doug Wilson
2014-09-08 18:08 ` Valdis.Kletnieks at vt.edu [this message]
2014-09-08 21:05 ` nick
2014-09-08 22:09 ` Valdis.Kletnieks at vt.edu
2014-09-09 0:51 ` nick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15552.1410199704@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.