All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonas Smedegaard <dr@jones.dk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1] sunxi: Add support for Olimex A64-Teres-I board
Date: Sun, 14 Apr 2019 23:49:57 +0200	[thread overview]
Message-ID: <155527859759.32580.16957885438715628693@auryn.jones.dk> (raw)
In-Reply-To: <CAMty3ZAZ_jrNO8S13MnpcoutR49uBoqkXFHGkM3G6opvvTQ-fg@mail.gmail.com>

Quoting Jagan Teki (2019-04-14 19:36:15)
> On Sun, Apr 14, 2019 at 10:16 PM Jonas Smedegaard <dr@jones.dk> wrote:
> >
> > Olimex Teres-I is a laptop DIY kit, and A64-Teres-I is its mainboard.
> > https://linux-sunxi.org/Olimex_Teres-A64
> >
> > This patch enables support for the A64-Teres-I board to u-boot,
> > including enabling screen backlight (lacking from Linux device-tree).
> >
> > sun50i-a64-teres-i.dts is copied verbatim from Linux 5.0.
> > Cosmetic warnings regarding whitespace and placement of SPDX notice for
> > this file was ignored.
> 
> Add the commit id details from which commit it synced from.

You mean mention explicitly that the git tag for Linux 5.0 is "v5.0"?  
Or mention explicitly the hash corresponding to that tag?  Or mention 
the hash for the last commit affecting that particular file?  Or mention 
a URL pointing to the file, e.g. 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts?h=v5.0 
?


> > config and .dtsi file are adapted from pinebook files.
> >
> > Author: Vasily Khoruzhick <anarsoul@gmail.com>
> 
> Didn't find this tag before, may be you can add details in commit
> message itself.

Ok, will then simply delete that: Already mentioned in file headers.


> > Tested-by: Jonas Smedegaard <dr@jones.dk>
> > Signed-off-by: Jonas Smedegaard <dr@jones.dk>
> > ---
> >
> >  arch/arm/dts/Makefile                       |   3 +-
> >  arch/arm/dts/sun50i-a64-teres-i-u-boot.dtsi |  41 +++
> >  arch/arm/dts/sun50i-a64-teres-i.dts         | 270 ++++++++++++++++++++
> >  configs/teres_i_defconfig                   |  21 ++
> 
> Maintainer entry?

Will add myself and Icenowy (who've worked on this in the past and have 
agreed to help look after this).


Thanks for the feedback, Jagan,

 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190414/9264ae38/attachment.sig>

      reply	other threads:[~2019-04-14 21:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-14 16:46 [U-Boot] [PATCH v1] sunxi: Add support for Olimex A64-Teres-I board Jonas Smedegaard
2019-04-14 17:36 ` Jagan Teki
2019-04-14 21:49   ` Jonas Smedegaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=155527859759.32580.16957885438715628693@auryn.jones.dk \
    --to=dr@jones.dk \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.