All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mac80211: Fix kernel panic due to use of txq after free
@ 2019-04-16  7:24 ` Bhagavathi Perumal S
  0 siblings, 0 replies; 4+ messages in thread
From: Bhagavathi Perumal S @ 2019-04-16  7:24 UTC (permalink / raw)
  To: johannes, ath10k, linux-wireless; +Cc: Bhagavathi Perumal S

The txq of vif is added to active_txqs list for ATF TXQ scheduling
in the function ieee80211_queue_skb(), but it was not properly removed
before freeing the txq object. It was causing use after free of the txq
objects from the active_txqs list, result was kernel panic
due to invalid memory access.

Fix kernel invalid memory access by properly removing txq object
from active_txqs list before free the object.

Signed-off-by: Bhagavathi Perumal S <bperumal@codeaurora.org>
---
 net/mac80211/iface.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c
index 94459b2..410685d 100644
--- a/net/mac80211/iface.c
+++ b/net/mac80211/iface.c
@@ -1907,6 +1907,9 @@ void ieee80211_if_remove(struct ieee80211_sub_if_data *sdata)
 	list_del_rcu(&sdata->list);
 	mutex_unlock(&sdata->local->iflist_mtx);
 
+	if (sdata->vif.txq)
+		ieee80211_txq_purge(sdata->local, to_txq_info(sdata->vif.txq));
+
 	synchronize_rcu();
 
 	if (sdata->dev) {
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] mac80211: Fix kernel panic due to use of txq after free
@ 2019-04-16  7:24 ` Bhagavathi Perumal S
  0 siblings, 0 replies; 4+ messages in thread
From: Bhagavathi Perumal S @ 2019-04-16  7:24 UTC (permalink / raw)
  To: johannes, ath10k, linux-wireless; +Cc: Bhagavathi Perumal S

The txq of vif is added to active_txqs list for ATF TXQ scheduling
in the function ieee80211_queue_skb(), but it was not properly removed
before freeing the txq object. It was causing use after free of the txq
objects from the active_txqs list, result was kernel panic
due to invalid memory access.

Fix kernel invalid memory access by properly removing txq object
from active_txqs list before free the object.

Signed-off-by: Bhagavathi Perumal S <bperumal@codeaurora.org>
---
 net/mac80211/iface.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c
index 94459b2..410685d 100644
--- a/net/mac80211/iface.c
+++ b/net/mac80211/iface.c
@@ -1907,6 +1907,9 @@ void ieee80211_if_remove(struct ieee80211_sub_if_data *sdata)
 	list_del_rcu(&sdata->list);
 	mutex_unlock(&sdata->local->iflist_mtx);
 
+	if (sdata->vif.txq)
+		ieee80211_txq_purge(sdata->local, to_txq_info(sdata->vif.txq));
+
 	synchronize_rcu();
 
 	if (sdata->dev) {
-- 
1.9.1


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] mac80211: Fix kernel panic due to use of txq after free
  2019-04-16  7:24 ` Bhagavathi Perumal S
@ 2019-04-16  8:49   ` Toke Høiland-Jørgensen
  -1 siblings, 0 replies; 4+ messages in thread
From: Toke Høiland-Jørgensen @ 2019-04-16  8:49 UTC (permalink / raw)
  To: Bhagavathi Perumal S, johannes, ath10k, linux-wireless
  Cc: Bhagavathi Perumal S

Bhagavathi Perumal S <bperumal@codeaurora.org> writes:

> The txq of vif is added to active_txqs list for ATF TXQ scheduling
> in the function ieee80211_queue_skb(), but it was not properly removed
> before freeing the txq object. It was causing use after free of the txq
> objects from the active_txqs list, result was kernel panic
> due to invalid memory access.
>
> Fix kernel invalid memory access by properly removing txq object
> from active_txqs list before free the object.
>
> Signed-off-by: Bhagavathi Perumal S <bperumal@codeaurora.org>

Nice catch, thanks!

Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>

This should probably have a fixes tag:

Fixes: 1866760096bf ("mac80211: Add TXQ scheduling API")

-Toke

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] mac80211: Fix kernel panic due to use of txq after free
@ 2019-04-16  8:49   ` Toke Høiland-Jørgensen
  0 siblings, 0 replies; 4+ messages in thread
From: Toke Høiland-Jørgensen @ 2019-04-16  8:49 UTC (permalink / raw)
  To: Bhagavathi Perumal S, johannes, ath10k, linux-wireless

Bhagavathi Perumal S <bperumal@codeaurora.org> writes:

> The txq of vif is added to active_txqs list for ATF TXQ scheduling
> in the function ieee80211_queue_skb(), but it was not properly removed
> before freeing the txq object. It was causing use after free of the txq
> objects from the active_txqs list, result was kernel panic
> due to invalid memory access.
>
> Fix kernel invalid memory access by properly removing txq object
> from active_txqs list before free the object.
>
> Signed-off-by: Bhagavathi Perumal S <bperumal@codeaurora.org>

Nice catch, thanks!

Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>

This should probably have a fixes tag:

Fixes: 1866760096bf ("mac80211: Add TXQ scheduling API")

-Toke

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-04-16  8:49 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-16  7:24 [PATCH] mac80211: Fix kernel panic due to use of txq after free Bhagavathi Perumal S
2019-04-16  7:24 ` Bhagavathi Perumal S
2019-04-16  8:49 ` Toke Høiland-Jørgensen
2019-04-16  8:49   ` Toke Høiland-Jørgensen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.