From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH v2 3/4] drm/i915: Make workaround verification *optional* Date: Tue, 16 Apr 2019 12:24:20 +0100 Message-ID: <155541386090.25605.18323669608333399422@skylake-alporthouse-com> References: <20190416081024.20536-1-chris@chris-wilson.co.uk> <20190416081024.20536-3-chris@chris-wilson.co.uk> <13010cb8-f272-f42b-7718-cb0cf40f7053@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id AE84A89BA3 for ; Tue, 16 Apr 2019 11:24:25 +0000 (UTC) In-Reply-To: <13010cb8-f272-f42b-7718-cb0cf40f7053@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org UXVvdGluZyBUdnJ0a28gVXJzdWxpbiAoMjAxOS0wNC0xNiAxMDo0ODowNSkKPiAKPiBPbiAxNi8w NC8yMDE5IDA5OjEwLCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gPiBTb21ldGltZXMgdGhlIEhXIGRv ZXNuJ3QgZXZlbiBwbGF5IGZhaXIsIGFuZCBjb21wbGV0ZWx5IGZvcmdldHMgYWJvdXQKPiA+IHJl Z2lzdGVyIHdyaXRlcy4gU2tpcCB2ZXJpZnlpbmcga25vd24gdHJvdWJsZW1ha2Vycy4KPiA+IAo+ ID4gUmVmZXJlbmNlczogaHR0cHM6Ly9idWdzLmZyZWVkZXNrdG9wLm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTA4OTU0Cj4gPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdp bHNvbi5jby51az4KPiA+IENjOiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwu Y29tPgo+ID4gLS0tCj4gPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3dvcmthcm91bmRz LmMgICAgICB8IDQwICsrKysrKysrKysrKysrLS0tLS0KPiA+ICAgLi4uL2dwdS9kcm0vaTkxNS9p bnRlbF93b3JrYXJvdW5kc190eXBlcy5oICAgIHwgIDcgKystLQo+ID4gICAyIGZpbGVzIGNoYW5n ZWQsIDMzIGluc2VydGlvbnMoKyksIDE0IGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfd29ya2Fyb3VuZHMuYyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX3dvcmthcm91bmRzLmMKPiA+IGluZGV4IGRiOTlmMmU2NzZiYi4uYmE1 OGJlMDVmNThjIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfd29y a2Fyb3VuZHMuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfd29ya2Fyb3Vu ZHMuYwo+ID4gQEAgLTEyMiw2ICsxMjIsNyBAQCBzdGF0aWMgdm9pZCBfd2FfYWRkKHN0cnVjdCBp OTE1X3dhX2xpc3QgKndhbCwgY29uc3Qgc3RydWN0IGk5MTVfd2EgKndhKQo+ID4gICAgICAgICAg ICAgICAgICAgICAgIHdhbC0+d2FfY291bnQrKzsKPiA+ICAgICAgICAgICAgICAgICAgICAgICB3 YV8tPnZhbCB8PSB3YS0+dmFsOwo+ID4gICAgICAgICAgICAgICAgICAgICAgIHdhXy0+bWFzayB8 PSB3YS0+bWFzazsKPiA+ICsgICAgICAgICAgICAgICAgICAgICB3YV8tPnJlYWQgfD0gd2EtPnJl YWQ7Cj4gPiAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuOwo+ID4gICAgICAgICAgICAgICB9 Cj4gPiAgICAgICB9Cj4gPiBAQCAtMTQ2LDkgKzE0NywxMCBAQCB3YV93cml0ZV9tYXNrZWRfb3Io c3RydWN0IGk5MTVfd2FfbGlzdCAqd2FsLCBpOTE1X3JlZ190IHJlZywgdTMyIG1hc2ssCj4gPiAg ICAgICAgICAgICAgICAgIHUzMiB2YWwpCj4gPiAgIHsKPiA+ICAgICAgIHN0cnVjdCBpOTE1X3dh IHdhID0gewo+ID4gLSAgICAgICAgICAgICAucmVnID0gcmVnLAo+ID4gKyAgICAgICAgICAgICAu cmVnICA9IHJlZywKPiA+ICAgICAgICAgICAgICAgLm1hc2sgPSBtYXNrLAo+ID4gLSAgICAgICAg ICAgICAudmFsID0gdmFsCj4gPiArICAgICAgICAgICAgIC52YWwgID0gdmFsLAo+ID4gKyAgICAg ICAgICAgICAucmVhZCA9IG1hc2ssCj4gPiAgICAgICB9Owo+ID4gICAKPiA+ICAgICAgIF93YV9h ZGQod2FsLCAmd2EpOwo+ID4gQEAgLTE3Miw2ICsxNzQsMTkgQEAgd2Ffd3JpdGVfb3Ioc3RydWN0 IGk5MTVfd2FfbGlzdCAqd2FsLCBpOTE1X3JlZ190IHJlZywgdTMyIHZhbCkKPiA+ICAgICAgIHdh X3dyaXRlX21hc2tlZF9vcih3YWwsIHJlZywgdmFsLCB2YWwpOwo+ID4gICB9Cj4gPiAgIAo+ID4g K3N0YXRpYyB2b2lkCj4gPiAraWdub3JlX3dhX3dyaXRlX29yKHN0cnVjdCBpOTE1X3dhX2xpc3Qg KndhbCwgaTkxNV9yZWdfdCByZWcsIHUzMiBtYXNrLCB1MzIgdmFsKQo+ID4gK3sKPiA+ICsgICAg IHN0cnVjdCBpOTE1X3dhIHdhID0gewo+ID4gKyAgICAgICAgICAgICAucmVnICA9IHJlZywKPiA+ ICsgICAgICAgICAgICAgLm1hc2sgPSBtYXNrLAo+ID4gKyAgICAgICAgICAgICAudmFsICA9IHZh bCwKPiA+ICsgICAgICAgICAgICAgLyogQm9ua2VycyBIVywgc2tpcCB2ZXJpZnlpbmcgKi8KPiA+ ICsgICAgIH07Cj4gPiArCj4gPiArICAgICBfd2FfYWRkKHdhbCwgJndhKTsKPiA+ICt9Cj4gPiAr Cj4gPiAgICNkZWZpbmUgV0FfU0VUX0JJVF9NQVNLRUQoYWRkciwgbWFzaykgXAo+ID4gICAgICAg d2Ffd3JpdGVfbWFza2VkX29yKHdhbCwgKGFkZHIpLCAobWFzayksIF9NQVNLRURfQklUX0VOQUJM RShtYXNrKSkKPiA+ICAgCj4gPiBAQCAtOTE2LDEwICs5MzEsMTEgQEAgd2FsX2dldF9md19mb3Jf cm13KHN0cnVjdCBpbnRlbF91bmNvcmUgKnVuY29yZSwgY29uc3Qgc3RydWN0IGk5MTVfd2FfbGlz dCAqd2FsKQo+ID4gICBzdGF0aWMgYm9vbAo+ID4gICB3YV92ZXJpZnkoY29uc3Qgc3RydWN0IGk5 MTVfd2EgKndhLCB1MzIgY3VyLCBjb25zdCBjaGFyICpuYW1lLCBjb25zdCBjaGFyICpmcm9tKQo+ ID4gICB7Cj4gPiAtICAgICBpZiAoKGN1ciBeIHdhLT52YWwpICYgd2EtPm1hc2spIHsKPiA+ICsg ICAgIGlmICgoY3VyIF4gd2EtPnZhbCkgJiB3YS0+cmVhZCkgewo+ID4gICAgICAgICAgICAgICBE Uk1fRVJST1IoIiVzIHdvcmthcm91bmQgbG9zdCBvbiAlcyEgKCV4PSV4LyV4LCBleHBlY3RlZCAl eCwgbWFzaz0leClcbiIsCj4gPiAtICAgICAgICAgICAgICAgICAgICAgICBuYW1lLCBmcm9tLCBp OTE1X21taW9fcmVnX29mZnNldCh3YS0+cmVnKSwgY3VyLAo+ID4gLSAgICAgICAgICAgICAgICAg ICAgICAgY3VyICYgd2EtPm1hc2ssIHdhLT52YWwsIHdhLT5tYXNrKTsKPiA+ICsgICAgICAgICAg ICAgICAgICAgICAgIG5hbWUsIGZyb20sIGk5MTVfbW1pb19yZWdfb2Zmc2V0KHdhLT5yZWcpLAo+ ID4gKyAgICAgICAgICAgICAgICAgICAgICAgY3VyLCBjdXIgJiB3YS0+cmVhZCwKPiA+ICsgICAg ICAgICAgICAgICAgICAgICAgIHdhLT52YWwsIHdhLT5tYXNrKTsKPiA+ICAgCj4gPiAgICAgICAg ICAgICAgIHJldHVybiBmYWxzZTsKPiA+ICAgICAgIH0KPiA+IEBAIC0xMTIyLDkgKzExMzgsMTAg QEAgcmNzX2VuZ2luZV93YV9pbml0KHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSwgc3Ry dWN0IGk5MTVfd2FfbGlzdCAqd2FsKQo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgXzNE X0NISUNLRU4zX0FBX0xJTkVfUVVBTElUWV9GSVhfRU5BQkxFKTsKPiA+ICAgCj4gPiAgICAgICAg ICAgICAgIC8qIFdhUGlwZWxpbmVGbHVzaENvaGVyZW50TGluZXM6aWNsICovCj4gPiAtICAgICAg ICAgICAgIHdhX3dyaXRlX29yKHdhbCwKPiA+IC0gICAgICAgICAgICAgICAgICAgICAgICAgR0VO OF9MM1NRQ1JFRzQsCj4gPiAtICAgICAgICAgICAgICAgICAgICAgICAgIEdFTjhfTFFTQ19GTFVT SF9DT0hFUkVOVF9MSU5FUyk7Cj4gPiArICAgICAgICAgICAgIGlnbm9yZV93YV93cml0ZV9vcih3 YWwsCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBHRU44X0wzU1FDUkVHNCwK PiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEdFTjhfTFFTQ19GTFVTSF9DT0hF UkVOVF9MSU5FUywKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEdFTjhfTFFT Q19GTFVTSF9DT0hFUkVOVF9MSU5FUyk7Cj4gPiAgIAo+ID4gICAgICAgICAgICAgICAvKgo+ID4g ICAgICAgICAgICAgICAgKiBXYV8xNDA1NTQzNjIyOmljbAo+ID4gQEAgLTExNTEsOSArMTE2OCwx MCBAQCByY3NfZW5naW5lX3dhX2luaXQoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lLCBz dHJ1Y3QgaTkxNV93YV9saXN0ICp3YWwpCj4gPiAgICAgICAgICAgICAgICAqIFdhXzE0MDU3MzMy MTY6aWNsCj4gPiAgICAgICAgICAgICAgICAqIEZvcm1lcmx5IGtub3duIGFzIFdhRGlzYWJsZUNs ZWFuRXZpY3RzCj4gPiAgICAgICAgICAgICAgICAqLwo+ID4gLSAgICAgICAgICAgICB3YV93cml0 ZV9vcih3YWwsCj4gPiAtICAgICAgICAgICAgICAgICAgICAgICAgIEdFTjhfTDNTUUNSRUc0LAo+ ID4gLSAgICAgICAgICAgICAgICAgICAgICAgICBHRU4xMV9MUVNDX0NMRUFOX0VWSUNUX0RJU0FC TEUpOwo+ID4gKyAgICAgICAgICAgICBpZ25vcmVfd2Ffd3JpdGVfb3Iod2FsLAo+ID4gKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgR0VOOF9MM1NRQ1JFRzQsCj4gPiArICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBHRU4xMV9MUVNDX0NMRUFOX0VWSUNUX0RJU0FCTEUsCj4g PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBHRU4xMV9MUVNDX0NMRUFOX0VWSUNU X0RJU0FCTEUpOwo+ID4gICAKPiA+ICAgICAgICAgICAgICAgLyogV2FGb3J3YXJkUHJvZ3Jlc3NT b2Z0UmVzZXQ6aWNsICovCj4gPiAgICAgICAgICAgICAgIHdhX3dyaXRlX29yKHdhbCwKPiA+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF93b3JrYXJvdW5kc190eXBlcy5o IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfd29ya2Fyb3VuZHNfdHlwZXMuaAo+ID4gaW5k ZXggMzA5MThkYTE4MGZmLi40MmFjMWZiOTk1NzIgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF93b3JrYXJvdW5kc190eXBlcy5oCj4gPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF93b3JrYXJvdW5kc190eXBlcy5oCj4gPiBAQCAtMTIsOSArMTIsMTAg QEAKPiA+ICAgI2luY2x1ZGUgImk5MTVfcmVnLmgiCj4gPiAgIAo+ID4gICBzdHJ1Y3QgaTkxNV93 YSB7Cj4gPiAtICAgICBpOTE1X3JlZ190ICAgICAgICByZWc7Cj4gPiAtICAgICB1MzIgICAgICAg ICAgICAgICBtYXNrOwo+ID4gLSAgICAgdTMyICAgICAgICAgICAgICAgdmFsOwo+ID4gKyAgICAg aTkxNV9yZWdfdCAgICAgIHJlZzsKPiA+ICsgICAgIHUzMiAgICAgICAgICAgICBtYXNrOwo+ID4g KyAgICAgdTMyICAgICAgICAgICAgIHZhbDsKPiA+ICsgICAgIHUzMiAgICAgICAgICAgICByZWFk Owo+ID4gICB9Owo+ID4gICAKPiA+ICAgc3RydWN0IGk5MTVfd2FfbGlzdCB7Cj4gPiAKPiAKPiBU aGUgc3BvcmFkaWMgbmF0dXJlIG9mIGZhaWx1cmVzIHdvcnJpZXMgbWUgaGVyZS4gV2hhdCBpcyBi ZXR0ZXI6Cj4gCj4gYSkgU3RvcCB2ZXJpZnlpbmcgZnJvbSB0aGUgZHJpdmVyIGFuZCBwb3RlbnRp YWxseSBsb3NlIGEgd29ya2Fyb3VuZCAKPiBhbmQvb3IgbmV2ZXIgZmlndXJlIG91dCB3aGF0IGlz IGFjdHVhbGx5IGdvaW5nIG9uLgo+IAo+IGIpIEhhdmUgQ0kgYnVnbG9nIHRyYWNrIHRoaXMgYXMg YSBrbm93biBpc3N1ZSAiZm9yZXZlciI/IENhbid0IG91ciAKPiBhdXRvbWF0ZWQgdG9vbGluZyBo YW5kbGUgdGhpcz8KCkVpdGhlciB3YXksIGl0J3MgTk9UT1VSQlVHLiBJZiBpdCdzIG5vdCBjbGVh ciwgbXkgaW50ZW50IGlzIHRoYXQgdGhpcyBpcwpyZWNvZ25pc2VkIGFzIGEgSFcgaXNzdWUuIFRo ZSBwcm9ibGVtIHdpdGggbGV0dGluZyBpdCByZXNpZGUgaW4gdGhlIHRlc3QKc3VpdGUgaXMgdGhh dCBpdCBpcyBoYXJkIGZvciBodW1hbnMgdG8gZGlzY2VybiBhbiBleHBlY3RlZCBmYWlsdXJlIGZy b20KYSBuZXcgZmFpbHVyZSAoYW5kIGlmIGl0IGhhcmQgZm9yIHVzIHRvIHRlbGwgYXQgYSBnbGFu Y2UsIEkgZnVsbHkgZXhwZWN0CmEgZ2VuZXJpYyBvdmVyLXJlYWNoaW5nIGNhdGNoIGFsbCBmaWx0 ZXIgdG8gYmUgYXBwbGllZCBpbiBjaWJ1Z2xvZyksIHNvCkkgYW50aWNpcGF0ZSB0aGF0IHRoaXMg dGVzdCBiZWNvbWVzIHVzZWxlc3MgaWYgbGVmdCB0byBjaWJ1Z2xvZyAtLSBwbHVzCml0IHdpbGwg cmVtYWluIGZvcmV2ZXIgaW4gdGhlIGlzc3Vlcy5odG1sLiBIZW5jZSBtYXJraW5nIHVwIGtub3du CmZhaWx1cmVzLCB3aXRoIG9uZSBob3BlcyBhbiBIU0RFUy4KLUNocmlzCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QK SW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==