From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mail.openembedded.org (Postfix) with ESMTP id CBA766AC12 for ; Fri, 6 Feb 2015 09:57:06 +0000 (UTC) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 06 Feb 2015 01:57:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,528,1418112000"; d="scan'208";a="662467974" Received: from kamaher-mobl6.ger.corp.intel.com (HELO peggleto-mobl5.ger.corp.intel.com) ([10.252.8.37]) by fmsmga001.fm.intel.com with ESMTP; 06 Feb 2015 01:56:24 -0800 From: Paul Eggleton To: Chong Lu Date: Fri, 06 Feb 2015 09:56:24 +0000 Message-ID: <1555691.UdstIKFBUi@peggleto-mobl5.ger.corp.intel.com> Organization: Intel Corporation User-Agent: KMail/4.14.4 (Linux/3.17.8-200.fc20.x86_64; KDE/4.14.4; x86_64; ; ) In-Reply-To: <54D4649E.7080403@windriver.com> References: <1584081.qrVQXzTzW7@peggleto-mobl5.ger.corp.intel.com> <54D4649E.7080403@windriver.com> MIME-Version: 1.0 Cc: bitbake-devel@lists.openembedded.org Subject: Re: [PATCH V3 0/2] bitbake-layers: add a ability to query layer dependencies from layer index X-BeenThere: bitbake-devel@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussion that advance bitbake development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Feb 2015 09:57:08 -0000 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Hi Chong, On Friday 06 February 2015 14:52:14 Chong Lu wrote: > On 02/03/2015 12:05 AM, Paul Eggleton wrote: > > On Friday 23 January 2015 13:28:32 Chong Lu wrote: > >> Change since V2: > >> re-split for IPv6 URL parsing > >> > >> The following changes since commit 35c9fa0588ed8e88b541a6c80cc1517324616cea: > >> maintainers: Update for non-maintained recipes (2015-01-20 21:39:41 > >> +0000) > >> > >> are available in the git repository at: > >> git://git.pokylinux.org/poky-contrib chonglu/layerindex > >> http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=chonglu/layerind > >> ex > >> > >> Chong Lu (2): > >> bitbake.conf: Add two variables for layer index > >> bitbake-layers: add a ability to query layer dependencies from layer > >> index > > > > Apologies for the delay in getting back to you. This is definitely > > improving, some feedback though: > > > > * I think the new subcommand would make more sense if it were switched > > around so that it was fetching by default (and renamed as appropriate). > > Perhaps "layerindex-fetch" (with -n to avoid fetching and just report > > what it would fetch). > > > > * I think the layer index URL specified in the OE variable should be to > > the > > root rather than to /api - instead have that suffix added by the code that > > does the API calls. This makes it usable as a URL for the index for > > presenting to the user if needed. > > > > * Can you rename the two variables to BBLAYERS_LAYERINDEX_URL and > > BBLAYERS_FETCH_DIR (sorry I didn't think of this earlier). > > I don't understand why does uname? Or, would you give me a example? I'm not sure I understand the question - but FWIW the variables I'm talking about renaming are currently named BITBAKE_LAYERINDEX_URL and LAYER_FETCH_DIR. The reason I suggest naming them BBLAYERS_LAYERINDEX_URL and BBLAYERS_FETCH_DIR respectively is it is more closely related to the area where the values are actually used. Is that what you were asking about? > > * Please mention bitbake-layers in the comment above the settings in > > bitbake.conf so it's clear where these variables are used. > > And I don't understand this one """ > > Please mention bitbake-layers in the comment above the settings in > bitbake.conf so it's clear where these variables are used. > > """ > Would you explain in details? You're adding defaults for these variables in bitbake.conf. We should mention above those defaults what these variables are actually being used for. i.e.: ################################################################## +# Settings used by bitbake-layers. +################################################################## +BBLAYERS_LAYERINDEX_URL ??= "http://layers.openembedded.org/layerindex/api/" +BBLAYERS_FETCH_DIR ??= "${COREBASE}" + +################################################################## > > * By using -q with git you lose the status output which can be very useful > > given how long it can take to fetch some layers e.g. meta-oe, so can you > > drop this? > > > > * Can you add a check to see if the layer has already been fetched before > > fetching it and skip the fetch if it does (but not skip the add)? > > > > * If I run "bitbake-layers show-layer-deps meta-security" I get an error: > > ERROR: Can NOT get meta-security git repo and subdir > > (The code currently expects there to be a subdir, but this is an optional > > field, not all layers have a subdirectory, meta-security is one example.) > > > > * I think you may be able to get away with skipping the initial parse by > > passing config_only=True to init_bbhandler(). If you can, this will save a > > bit of time each time you run the command. Cheers, Paul -- Paul Eggleton Intel Open Source Technology Centre