[PATCH 1/2] vim: Rework to not rely on relative directories

[PATCH 1/2] vim: Rework to not rely on relative directories

[Tom Rini]

The vim recipe has all of the code inside the "src" subdirectory but
other things we rely on, such as the license file in a subdirectory
relative to the src.  However, as there is a top-level "configure"
script that moves us down to the src directory, we can rework the recipe
to be overall more simple and regularly laid out if we use that.

Signed-off-by: Tom Rini <trini@konsulko.com>
---
 meta/recipes-support/vim/vim-tiny_8.1.1017.bb |  2 +-
 meta/recipes-support/vim/vim_8.1.1017.bb      | 18 ++++++++++--------
 2 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/meta/recipes-support/vim/vim-tiny_8.1.1017.bb b/meta/recipes-support/vim/vim-tiny_8.1.1017.bb
index 8b1fb7b1158d..74464833adb5 100644
--- a/meta/recipes-support/vim/vim-tiny_8.1.1017.bb
+++ b/meta/recipes-support/vim/vim-tiny_8.1.1017.bb
@@ -8,7 +8,7 @@ ALTERNATIVE_${PN}_remove = "xxd"
 PACKAGECONFIG += "tiny"
 
 do_install() {
-    install -D -m 0755 ${S}/vim ${D}/${bindir}/vim.tiny
+    install -D -m 0755 ${S}/src/vim ${D}/${bindir}/vim.tiny
 }
 
 ALTERNATIVE_PRIORITY = "90"
diff --git a/meta/recipes-support/vim/vim_8.1.1017.bb b/meta/recipes-support/vim/vim_8.1.1017.bb
index 7627d2844b79..4e3e663c5429 100644
--- a/meta/recipes-support/vim/vim_8.1.1017.bb
+++ b/meta/recipes-support/vim/vim_8.1.1017.bb
@@ -6,16 +6,16 @@ DEPENDS = "ncurses gettext-native"
 # vimdiff doesn't like busybox diff
 RSUGGESTS_${PN} = "diffutils"
 LICENSE = "vim"
-LIC_FILES_CHKSUM = "file://../runtime/doc/uganda.txt;endline=287;md5=f1f82b42360005c70b8c19b0ef493f72"
+LIC_FILES_CHKSUM = "file://runtime/doc/uganda.txt;endline=287;md5=f1f82b42360005c70b8c19b0ef493f72"
 
 SRC_URI = "git://github.com/vim/vim.git \
-           file://disable_acl_header_check.patch;patchdir=.. \
-           file://vim-add-knob-whether-elf.h-are-checked.patch;patchdir=.. \
-           file://0001-src-Makefile-improve-reproducibility.patch;patchdir=.. \
+           file://disable_acl_header_check.patch \
+           file://vim-add-knob-whether-elf.h-are-checked.patch \
+           file://0001-src-Makefile-improve-reproducibility.patch \
 "
 SRCREV = "493fbe4abee660d30b4f2aef87b754b0a720213c"
 
-S = "${WORKDIR}/git/src"
+S = "${WORKDIR}/git"
 
 VIMDIR = "vim${@d.getVar('PV').split('.')[0]}${@d.getVar('PV').split('.')[1]}"
 
@@ -25,13 +25,15 @@ CLEANBROKEN = "1"
 
 # vim configure.in contains functions which got 'dropped' by autotools.bbclass
 do_configure () {
+    cd src
     rm -f auto/*
     touch auto/config.mk
     aclocal
     autoconf
+    cd ..
     oe_runconf
-    touch auto/configure
-    touch auto/config.mk auto/config.h
+    touch src/auto/configure
+    touch src/auto/config.mk src/auto/config.h
 }
 
 #Available PACKAGECONFIG options are gtkgui, acl, x11, tiny
@@ -76,7 +78,7 @@ do_install() {
     chmod -x ${D}${datadir}/${BPN}/${VIMDIR}/tools/*.py
 
     # Install example vimrc from runtime files
-    install -m 0644 ../runtime/vimrc_example.vim ${D}/${datadir}/${BPN}/vimrc
+    install -m 0644 runtime/vimrc_example.vim ${D}/${datadir}/${BPN}/vimrc
 
     # we use --with-features=big as default
     mv ${D}${bindir}/${BPN} ${D}${bindir}/${BPN}.${BPN}
-- 
2.7.4

[PATCH 2/2] vim: Update to 8.1.1198

[Tom Rini]

This brings us to the current version of vim.

Signed-off-by: Tom Rini <trini@konsulko.com>
---
 meta/recipes-support/vim/{vim-tiny_8.1.1017.bb => vim-tiny_8.1.1198.bb} | 0
 meta/recipes-support/vim/{vim_8.1.1017.bb => vim_8.1.1198.bb}           | 2 +-
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename meta/recipes-support/vim/{vim-tiny_8.1.1017.bb => vim-tiny_8.1.1198.bb} (100%)
 rename meta/recipes-support/vim/{vim_8.1.1017.bb => vim_8.1.1198.bb} (98%)

diff --git a/meta/recipes-support/vim/vim-tiny_8.1.1017.bb b/meta/recipes-support/vim/vim-tiny_8.1.1198.bb
similarity index 100%
rename from meta/recipes-support/vim/vim-tiny_8.1.1017.bb
rename to meta/recipes-support/vim/vim-tiny_8.1.1198.bb
diff --git a/meta/recipes-support/vim/vim_8.1.1017.bb b/meta/recipes-support/vim/vim_8.1.1198.bb
similarity index 98%
rename from meta/recipes-support/vim/vim_8.1.1017.bb
rename to meta/recipes-support/vim/vim_8.1.1198.bb
index 4e3e663c5429..d7b864ee8b94 100644
--- a/meta/recipes-support/vim/vim_8.1.1017.bb
+++ b/meta/recipes-support/vim/vim_8.1.1198.bb
@@ -13,7 +13,7 @@ SRC_URI = "git://github.com/vim/vim.git \
            file://vim-add-knob-whether-elf.h-are-checked.patch \
            file://0001-src-Makefile-improve-reproducibility.patch \
 "
-SRCREV = "493fbe4abee660d30b4f2aef87b754b0a720213c"
+SRCREV = "958eabe5e53673fc39186432ff98b3656663beeb"
 
 S = "${WORKDIR}/git"
 
-- 
2.7.4

Re: [PATCH 2/2] vim: Update to 8.1.1198

[Richard Purdie]

On Sun, 2019-04-21 at 13:57 -0400, Tom Rini wrote:
> This brings us to the current version of vim.
> 
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
>  meta/recipes-support/vim/{vim-tiny_8.1.1017.bb => vim-
> tiny_8.1.1198.bb} | 0
>  meta/recipes-support/vim/{vim_8.1.1017.bb =>
> vim_8.1.1198.bb}           | 2 +-
>  2 files changed, 1 insertion(+), 1 deletion(-)
>  rename meta/recipes-support/vim/{vim-tiny_8.1.1017.bb => vim-
> tiny_8.1.1198.bb} (100%)
>  rename meta/recipes-support/vim/{vim_8.1.1017.bb => vim_8.1.1198.bb}
> (98%)

https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/527

Cheers,

Richard

Re: [PATCH 2/2] vim: Update to 8.1.1198

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 1227 bytes --]

On Tue, Apr 23, 2019 at 04:02:49PM +0100, Richard Purdie wrote:
> On Sun, 2019-04-21 at 13:57 -0400, Tom Rini wrote:
> > This brings us to the current version of vim.
> > 
> > Signed-off-by: Tom Rini <trini@konsulko.com>
> > ---
> >  meta/recipes-support/vim/{vim-tiny_8.1.1017.bb => vim-
> > tiny_8.1.1198.bb} | 0
> >  meta/recipes-support/vim/{vim_8.1.1017.bb =>
> > vim_8.1.1198.bb}           | 2 +-
> >  2 files changed, 1 insertion(+), 1 deletion(-)
> >  rename meta/recipes-support/vim/{vim-tiny_8.1.1017.bb => vim-
> > tiny_8.1.1198.bb} (100%)
> >  rename meta/recipes-support/vim/{vim_8.1.1017.bb => vim_8.1.1198.bb}
> > (98%)
> 
> https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/527

Does the current version even work in this case?  Digging down into
https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/527/steps/7/logs/step1b
there's a certain level of "how does that even work today then?" that
springs to mind.

I need a few more details to know how to reproduce this locally as I
don't see whatever must be in site.conf/etc to turn regular poky into
no-x11.  The errors are also around iconv stuff so maybe nls is also
removed here?  Thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH 2/2] vim: Update to 8.1.1198

[richard.purdie]

On Tue, 2019-04-23 at 18:01 -0400, Tom Rini wrote:
> On Tue, Apr 23, 2019 at 04:02:49PM +0100, Richard Purdie wrote:
> > On Sun, 2019-04-21 at 13:57 -0400, Tom Rini wrote:
> > > This brings us to the current version of vim.
> > > 
> > > Signed-off-by: Tom Rini <trini@konsulko.com>
> > > ---
> > >  meta/recipes-support/vim/{vim-tiny_8.1.1017.bb => vim-
> > > tiny_8.1.1198.bb} | 0
> > >  meta/recipes-support/vim/{vim_8.1.1017.bb =>
> > > vim_8.1.1198.bb}           | 2 +-
> > >  2 files changed, 1 insertion(+), 1 deletion(-)
> > >  rename meta/recipes-support/vim/{vim-tiny_8.1.1017.bb => vim-
> > > tiny_8.1.1198.bb} (100%)
> > >  rename meta/recipes-support/vim/{vim_8.1.1017.bb => vim_8.1.1198.bb}
> > > (98%)
> > 
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/527
> 
> Does the current version even work in this case?  Digging down into
> https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/527/steps/7/logs/step1b
> there's a certain level of "how does that even work today then?" that
> springs to mind.
> 
> I need a few more details to know how to reproduce this locally as I
> don't see whatever must be in site.conf/etc to turn regular poky into
> no-x11.  The errors are also around iconv stuff so maybe nls is also
> removed here?  Thanks!

perhaps simpler, qemux86-world also failed:

https://autobuilder.yoctoproject.org/typhoon/#/builders/52/builds/515

with:

| /home/pokybuild/yocto-worker/qemux86-world/build/build/tmp/work/i586-
poky-linux/vim/8.1.1198-r0/recipe-sysroot-native/usr/bin/msgfmt: Cannot
convert from "ISO-8859-2" to "UTF-8". msgfmt relies on iconv(), and
iconv() does not support this conversion.
| make[2]: *** [gvim.desktop] Error 1

So perhaps there is host contamination and this works one some build
machine setups but not more minimal ones?

The build configuration hasn't changed, just the new version upgrade
and the other patch. I suppose its possible it depends which of our
workers its built upon but that seems unlikely for two world failures
(no-x11 is also a world failure).

Cheers,

Richard

Re: [PATCH 2/2] vim: Update to 8.1.1198

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 2426 bytes --]

On Tue, Apr 23, 2019 at 11:22:14PM +0100, richard.purdie@linuxfoundation.org wrote:
> On Tue, 2019-04-23 at 18:01 -0400, Tom Rini wrote:
> > On Tue, Apr 23, 2019 at 04:02:49PM +0100, Richard Purdie wrote:
> > > On Sun, 2019-04-21 at 13:57 -0400, Tom Rini wrote:
> > > > This brings us to the current version of vim.
> > > > 
> > > > Signed-off-by: Tom Rini <trini@konsulko.com>
> > > > ---
> > > >  meta/recipes-support/vim/{vim-tiny_8.1.1017.bb => vim-
> > > > tiny_8.1.1198.bb} | 0
> > > >  meta/recipes-support/vim/{vim_8.1.1017.bb =>
> > > > vim_8.1.1198.bb}           | 2 +-
> > > >  2 files changed, 1 insertion(+), 1 deletion(-)
> > > >  rename meta/recipes-support/vim/{vim-tiny_8.1.1017.bb => vim-
> > > > tiny_8.1.1198.bb} (100%)
> > > >  rename meta/recipes-support/vim/{vim_8.1.1017.bb => vim_8.1.1198.bb}
> > > > (98%)
> > > 
> > > https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/527
> > 
> > Does the current version even work in this case?  Digging down into
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/527/steps/7/logs/step1b
> > there's a certain level of "how does that even work today then?" that
> > springs to mind.
> > 
> > I need a few more details to know how to reproduce this locally as I
> > don't see whatever must be in site.conf/etc to turn regular poky into
> > no-x11.  The errors are also around iconv stuff so maybe nls is also
> > removed here?  Thanks!
> 
> perhaps simpler, qemux86-world also failed:
> 
> https://autobuilder.yoctoproject.org/typhoon/#/builders/52/builds/515
> 
> with:
> 
> | /home/pokybuild/yocto-worker/qemux86-world/build/build/tmp/work/i586-
> poky-linux/vim/8.1.1198-r0/recipe-sysroot-native/usr/bin/msgfmt: Cannot
> convert from "ISO-8859-2" to "UTF-8". msgfmt relies on iconv(), and
> iconv() does not support this conversion.
> | make[2]: *** [gvim.desktop] Error 1
> 
> So perhaps there is host contamination and this works one some build
> machine setups but not more minimal ones?

Hmm, could be.  I assume there's not currently a minimal Docker (or,
whatever) image to grab and build off of (I just spent some time setting
up such a thing for U-Boot) ?  It looks like I can setup a minimal
Fedora chroot without too much work, so I'll pencil in some time to make
that, install the normal documented must-haves and see what I can make
blow up.  Thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH 2/2] vim: Update to 8.1.1198

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 2582 bytes --]

On Tue, Apr 23, 2019 at 11:22:14PM +0100, richard.purdie@linuxfoundation.org wrote:
> On Tue, 2019-04-23 at 18:01 -0400, Tom Rini wrote:
> > On Tue, Apr 23, 2019 at 04:02:49PM +0100, Richard Purdie wrote:
> > > On Sun, 2019-04-21 at 13:57 -0400, Tom Rini wrote:
> > > > This brings us to the current version of vim.
> > > > 
> > > > Signed-off-by: Tom Rini <trini@konsulko.com>
> > > > ---
> > > >  meta/recipes-support/vim/{vim-tiny_8.1.1017.bb => vim-
> > > > tiny_8.1.1198.bb} | 0
> > > >  meta/recipes-support/vim/{vim_8.1.1017.bb =>
> > > > vim_8.1.1198.bb}           | 2 +-
> > > >  2 files changed, 1 insertion(+), 1 deletion(-)
> > > >  rename meta/recipes-support/vim/{vim-tiny_8.1.1017.bb => vim-
> > > > tiny_8.1.1198.bb} (100%)
> > > >  rename meta/recipes-support/vim/{vim_8.1.1017.bb => vim_8.1.1198.bb}
> > > > (98%)
> > > 
> > > https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/527
> > 
> > Does the current version even work in this case?  Digging down into
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/527/steps/7/logs/step1b
> > there's a certain level of "how does that even work today then?" that
> > springs to mind.
> > 
> > I need a few more details to know how to reproduce this locally as I
> > don't see whatever must be in site.conf/etc to turn regular poky into
> > no-x11.  The errors are also around iconv stuff so maybe nls is also
> > removed here?  Thanks!
> 
> perhaps simpler, qemux86-world also failed:
> 
> https://autobuilder.yoctoproject.org/typhoon/#/builders/52/builds/515
> 
> with:
> 
> | /home/pokybuild/yocto-worker/qemux86-world/build/build/tmp/work/i586-
> poky-linux/vim/8.1.1198-r0/recipe-sysroot-native/usr/bin/msgfmt: Cannot
> convert from "ISO-8859-2" to "UTF-8". msgfmt relies on iconv(), and
> iconv() does not support this conversion.
> | make[2]: *** [gvim.desktop] Error 1
> 
> So perhaps there is host contamination and this works one some build
> machine setups but not more minimal ones?
> 
> The build configuration hasn't changed, just the new version upgrade
> and the other patch. I suppose its possible it depends which of our
> workers its built upon but that seems unlikely for two world failures
> (no-x11 is also a world failure).

Current poky master-next + my patches (and bitbake -k'ing around
gobject-introspection-native failing to configure over passing
-Ddocs=false) and vim builds on a FC29 "Cloud" image + documented
additional packages off of
https://www.openembedded.org/wiki/Getting_started

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH 2/2] vim: Update to 8.1.1198

[Tim Orling]

[-- Attachment #1: Type: text/plain, Size: 3056 bytes --]

On Tue, Apr 23, 2019 at 6:17 PM Tom Rini <trini@konsulko.com> wrote:

> On Tue, Apr 23, 2019 at 11:22:14PM +0100,
> richard.purdie@linuxfoundation.org wrote:
> > On Tue, 2019-04-23 at 18:01 -0400, Tom Rini wrote:
> > > On Tue, Apr 23, 2019 at 04:02:49PM +0100, Richard Purdie wrote:
> > > > On Sun, 2019-04-21 at 13:57 -0400, Tom Rini wrote:
> > > > > This brings us to the current version of vim.
> > > > >
> > > > > Signed-off-by: Tom Rini <trini@konsulko.com>
> > > > > ---
> > > > >  meta/recipes-support/vim/{vim-tiny_8.1.1017.bb => vim-
> > > > > tiny_8.1.1198.bb} | 0
> > > > >  meta/recipes-support/vim/{vim_8.1.1017.bb =>
> > > > > vim_8.1.1198.bb}           | 2 +-
> > > > >  2 files changed, 1 insertion(+), 1 deletion(-)
> > > > >  rename meta/recipes-support/vim/{vim-tiny_8.1.1017.bb => vim-
> > > > > tiny_8.1.1198.bb} (100%)
> > > > >  rename meta/recipes-support/vim/{vim_8.1.1017.bb =>
> vim_8.1.1198.bb}
> > > > > (98%)
> > > >
> > > >
> https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/527
> > >
> > > Does the current version even work in this case?  Digging down into
> > >
> https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/527/steps/7/logs/step1b
> > > there's a certain level of "how does that even work today then?" that
> > > springs to mind.
> > >
> > > I need a few more details to know how to reproduce this locally as I
> > > don't see whatever must be in site.conf/etc to turn regular poky into
> > > no-x11.  The errors are also around iconv stuff so maybe nls is also
> > > removed here?  Thanks!
> >
> > perhaps simpler, qemux86-world also failed:
> >
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/52/builds/515
> >
> > with:
> >
> > | /home/pokybuild/yocto-worker/qemux86-world/build/build/tmp/work/i586-
> > poky-linux/vim/8.1.1198-r0/recipe-sysroot-native/usr/bin/msgfmt: Cannot
> > convert from "ISO-8859-2" to "UTF-8". msgfmt relies on iconv(), and
> > iconv() does not support this conversion.
> > | make[2]: *** [gvim.desktop] Error 1
> >
> > So perhaps there is host contamination and this works one some build
> > machine setups but not more minimal ones?
> >
> > The build configuration hasn't changed, just the new version upgrade
> > and the other patch. I suppose its possible it depends which of our
> > workers its built upon but that seems unlikely for two world failures
> > (no-x11 is also a world failure).
>
> Current poky master-next + my patches (and bitbake -k'ing around
> gobject-introspection-native failing to configure over passing
> -Ddocs=false) and vim builds on a FC29 "Cloud" image + documented
> additional packages off of
> https://www.openembedded.org/wiki/Getting_started
>

Or you could use a CROPS container?
https://hub.docker.com/r/crops/poky/


> --
> Tom
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 5444 bytes --]

Re: [PATCH 2/2] vim: Update to 8.1.1198

[richard.purdie]

On Tue, 2019-04-23 at 21:17 -0400, Tom Rini wrote:
> On Tue, Apr 23, 2019 at 11:22:14PM +0100, 
> richard.purdie@linuxfoundation.org wrote:
> > On Tue, 2019-04-23 at 18:01 -0400, Tom Rini wrote:
> > > On Tue, Apr 23, 2019 at 04:02:49PM +0100, Richard Purdie wrote:
> > > > On Sun, 2019-04-21 at 13:57 -0400, Tom Rini wrote:
> > > > > This brings us to the current version of vim.
> > > > > 
> > > > > Signed-off-by: Tom Rini <trini@konsulko.com>
> > > > > ---
> > > > >  meta/recipes-support/vim/{vim-tiny_8.1.1017.bb => vim-
> > > > > tiny_8.1.1198.bb} | 0
> > > > >  meta/recipes-support/vim/{vim_8.1.1017.bb =>
> > > > > vim_8.1.1198.bb}           | 2 +-
> > > > >  2 files changed, 1 insertion(+), 1 deletion(-)
> > > > >  rename meta/recipes-support/vim/{vim-tiny_8.1.1017.bb =>
> > > > > vim-
> > > > > tiny_8.1.1198.bb} (100%)
> > > > >  rename meta/recipes-support/vim/{vim_8.1.1017.bb =>
> > > > > vim_8.1.1198.bb}
> > > > > (98%)
> > > > 
> > > > https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/527
> > > 
> > > Does the current version even work in this case?  Digging down
> > > into
> > > https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/527/steps/7/logs/step1b
> > > there's a certain level of "how does that even work today then?"
> > > that
> > > springs to mind.
> > > 
> > > I need a few more details to know how to reproduce this locally
> > > as I
> > > don't see whatever must be in site.conf/etc to turn regular poky
> > > into
> > > no-x11.  The errors are also around iconv stuff so maybe nls is
> > > also
> > > removed here?  Thanks!
> > 
> > perhaps simpler, qemux86-world also failed:
> > 
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/52/builds/515
> > 
> > with:
> > 
> > > /home/pokybuild/yocto-worker/qemux86-
> > > world/build/build/tmp/work/i586-
> > poky-linux/vim/8.1.1198-r0/recipe-sysroot-native/usr/bin/msgfmt:
> > Cannot
> > convert from "ISO-8859-2" to "UTF-8". msgfmt relies on iconv(), and
> > iconv() does not support this conversion.
> > > make[2]: *** [gvim.desktop] Error 1
> > 
> > So perhaps there is host contamination and this works one some
> > build
> > machine setups but not more minimal ones?
> > 
> > The build configuration hasn't changed, just the new version
> > upgrade
> > and the other patch. I suppose its possible it depends which of our
> > workers its built upon but that seems unlikely for two world
> > failures
> > (no-x11 is also a world failure).
> 
> Current poky master-next + my patches (and bitbake -k'ing around
> gobject-introspection-native failing to configure over passing
> -Ddocs=false) and vim builds on a FC29 "Cloud" image + documented
> additional packages off of
> https://www.openembedded.org/wiki/Getting_started

Something odd is going on as I tried this on my local build system and
that failed the same way as the autobuilder. That is an ubuntu 18.04
system, nothing special. I guess this means I should try and figure out
why it breaks. I still suspect something about the native locales
installed...

The gobject-introspection-native issue was dropped from -next fwiw.

What does "locale -a" show for you?

Cheers,

Richard

Re: [PATCH 2/2] vim: Update to 8.1.1198

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 4478 bytes --]

On Wed, Apr 24, 2019 at 08:40:01AM +0100, richard.purdie@linuxfoundation.org wrote:
> On Tue, 2019-04-23 at 21:17 -0400, Tom Rini wrote:
> > On Tue, Apr 23, 2019 at 11:22:14PM +0100, 
> > richard.purdie@linuxfoundation.org wrote:
> > > On Tue, 2019-04-23 at 18:01 -0400, Tom Rini wrote:
> > > > On Tue, Apr 23, 2019 at 04:02:49PM +0100, Richard Purdie wrote:
> > > > > On Sun, 2019-04-21 at 13:57 -0400, Tom Rini wrote:
> > > > > > This brings us to the current version of vim.
> > > > > > 
> > > > > > Signed-off-by: Tom Rini <trini@konsulko.com>
> > > > > > ---
> > > > > >  meta/recipes-support/vim/{vim-tiny_8.1.1017.bb => vim-
> > > > > > tiny_8.1.1198.bb} | 0
> > > > > >  meta/recipes-support/vim/{vim_8.1.1017.bb =>
> > > > > > vim_8.1.1198.bb}           | 2 +-
> > > > > >  2 files changed, 1 insertion(+), 1 deletion(-)
> > > > > >  rename meta/recipes-support/vim/{vim-tiny_8.1.1017.bb =>
> > > > > > vim-
> > > > > > tiny_8.1.1198.bb} (100%)
> > > > > >  rename meta/recipes-support/vim/{vim_8.1.1017.bb =>
> > > > > > vim_8.1.1198.bb}
> > > > > > (98%)
> > > > > 
> > > > > https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/527
> > > > 
> > > > Does the current version even work in this case?  Digging down
> > > > into
> > > > https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/527/steps/7/logs/step1b
> > > > there's a certain level of "how does that even work today then?"
> > > > that
> > > > springs to mind.
> > > > 
> > > > I need a few more details to know how to reproduce this locally
> > > > as I
> > > > don't see whatever must be in site.conf/etc to turn regular poky
> > > > into
> > > > no-x11.  The errors are also around iconv stuff so maybe nls is
> > > > also
> > > > removed here?  Thanks!
> > > 
> > > perhaps simpler, qemux86-world also failed:
> > > 
> > > https://autobuilder.yoctoproject.org/typhoon/#/builders/52/builds/515
> > > 
> > > with:
> > > 
> > > > /home/pokybuild/yocto-worker/qemux86-
> > > > world/build/build/tmp/work/i586-
> > > poky-linux/vim/8.1.1198-r0/recipe-sysroot-native/usr/bin/msgfmt:
> > > Cannot
> > > convert from "ISO-8859-2" to "UTF-8". msgfmt relies on iconv(), and
> > > iconv() does not support this conversion.
> > > > make[2]: *** [gvim.desktop] Error 1
> > > 
> > > So perhaps there is host contamination and this works one some
> > > build
> > > machine setups but not more minimal ones?
> > > 
> > > The build configuration hasn't changed, just the new version
> > > upgrade
> > > and the other patch. I suppose its possible it depends which of our
> > > workers its built upon but that seems unlikely for two world
> > > failures
> > > (no-x11 is also a world failure).
> > 
> > Current poky master-next + my patches (and bitbake -k'ing around
> > gobject-introspection-native failing to configure over passing
> > -Ddocs=false) and vim builds on a FC29 "Cloud" image + documented
> > additional packages off of
> > https://www.openembedded.org/wiki/Getting_started
> 
> Something odd is going on as I tried this on my local build system and
> that failed the same way as the autobuilder. That is an ubuntu 18.04
> system, nothing special. I guess this means I should try and figure out
> why it breaks. I still suspect something about the native locales
> installed...

Very strange, yeah.

> The gobject-introspection-native issue was dropped from -next fwiw.

OK.

> What does "locale -a" show for you?

On Fedora Core 29:
C
C.utf8
en_AG
en_AG.utf8
en_AU
en_AU.iso88591
en_AU.utf8
en_BW
en_BW.iso88591
en_BW.utf8
en_CA
en_CA.iso88591
en_CA.utf8
en_DK
en_DK.iso88591
en_DK.utf8
en_GB
en_GB.iso88591
en_GB.iso885915
en_GB.utf8
en_HK
en_HK.iso88591
en_HK.utf8
en_IE
en_IE@euro
en_IE.iso88591
en_IE.iso885915@euro
en_IE.utf8
en_IL
en_IL.utf8
en_IN
en_IN.utf8
en_NG
en_NG.utf8
en_NZ
en_NZ.iso88591
en_NZ.utf8
en_PH
en_PH.iso88591
en_PH.utf8
en_SC.utf8
en_SG
en_SG.iso88591
en_SG.utf8
en_US
en_US.iso88591
en_US.iso885915
en_US.utf8
en_ZA
en_ZA.iso88591
en_ZA.utf8
en_ZM
en_ZM.utf8
en_ZW
en_ZW.iso88591
en_ZW.utf8
POSIX

And then my Ubuntu 16.04 regular build env:
C
C.UTF-8
en_AG
en_AG.utf8
en_AU.utf8
en_BW.utf8
en_CA.utf8
en_DK.utf8
en_GB.utf8
en_HK.utf8
en_IE.utf8
en_IN
en_IN.utf8
en_NG
en_NG.utf8
en_NZ.utf8
en_PH.utf8
en_SG.utf8
en_US.utf8
en_ZA.utf8
en_ZM
en_ZM.utf8
en_ZW.utf8
POSIX

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH 2/2] vim: Update to 8.1.1198

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 3162 bytes --]

On Tue, Apr 23, 2019 at 10:24:42PM -0700, Tim Orling wrote:
> On Tue, Apr 23, 2019 at 6:17 PM Tom Rini <trini@konsulko.com> wrote:
> 
> > On Tue, Apr 23, 2019 at 11:22:14PM +0100,
> > richard.purdie@linuxfoundation.org wrote:
> > > On Tue, 2019-04-23 at 18:01 -0400, Tom Rini wrote:
> > > > On Tue, Apr 23, 2019 at 04:02:49PM +0100, Richard Purdie wrote:
> > > > > On Sun, 2019-04-21 at 13:57 -0400, Tom Rini wrote:
> > > > > > This brings us to the current version of vim.
> > > > > >
> > > > > > Signed-off-by: Tom Rini <trini@konsulko.com>
> > > > > > ---
> > > > > >  meta/recipes-support/vim/{vim-tiny_8.1.1017.bb => vim-
> > > > > > tiny_8.1.1198.bb} | 0
> > > > > >  meta/recipes-support/vim/{vim_8.1.1017.bb =>
> > > > > > vim_8.1.1198.bb}           | 2 +-
> > > > > >  2 files changed, 1 insertion(+), 1 deletion(-)
> > > > > >  rename meta/recipes-support/vim/{vim-tiny_8.1.1017.bb => vim-
> > > > > > tiny_8.1.1198.bb} (100%)
> > > > > >  rename meta/recipes-support/vim/{vim_8.1.1017.bb =>
> > vim_8.1.1198.bb}
> > > > > > (98%)
> > > > >
> > > > >
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/527
> > > >
> > > > Does the current version even work in this case?  Digging down into
> > > >
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/527/steps/7/logs/step1b
> > > > there's a certain level of "how does that even work today then?" that
> > > > springs to mind.
> > > >
> > > > I need a few more details to know how to reproduce this locally as I
> > > > don't see whatever must be in site.conf/etc to turn regular poky into
> > > > no-x11.  The errors are also around iconv stuff so maybe nls is also
> > > > removed here?  Thanks!
> > >
> > > perhaps simpler, qemux86-world also failed:
> > >
> > > https://autobuilder.yoctoproject.org/typhoon/#/builders/52/builds/515
> > >
> > > with:
> > >
> > > | /home/pokybuild/yocto-worker/qemux86-world/build/build/tmp/work/i586-
> > > poky-linux/vim/8.1.1198-r0/recipe-sysroot-native/usr/bin/msgfmt: Cannot
> > > convert from "ISO-8859-2" to "UTF-8". msgfmt relies on iconv(), and
> > > iconv() does not support this conversion.
> > > | make[2]: *** [gvim.desktop] Error 1
> > >
> > > So perhaps there is host contamination and this works one some build
> > > machine setups but not more minimal ones?
> > >
> > > The build configuration hasn't changed, just the new version upgrade
> > > and the other patch. I suppose its possible it depends which of our
> > > workers its built upon but that seems unlikely for two world failures
> > > (no-x11 is also a world failure).
> >
> > Current poky master-next + my patches (and bitbake -k'ing around
> > gobject-introspection-native failing to configure over passing
> > -Ddocs=false) and vim builds on a FC29 "Cloud" image + documented
> > additional packages off of
> > https://www.openembedded.org/wiki/Getting_started
> 
> Or you could use a CROPS container?
> https://hub.docker.com/r/crops/poky/

No, only in that I was looking to replicate a hopefully known failing
env (of which RP pointed to Centos and Fedora builders).

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH 2/2] vim: Update to 8.1.1198

[richard.purdie]

On Wed, 2019-04-24 at 07:29 -0400, Tom Rini wrote:
> On Wed, Apr 24, 2019 at 08:40:01AM +0100, 
> richard.purdie@linuxfoundation.org wrote:
> 
> > What does "locale -a" show for you?
> 
> On Fedora Core 29:
> C
> C.utf8
> en_AG
> en_AG.utf8
> en_AU
> en_AU.iso88591
> en_AU.utf8
> en_BW
> en_BW.iso88591
> en_BW.utf8
> en_CA
> en_CA.iso88591
> en_CA.utf8
> en_DK
> en_DK.iso88591
> en_DK.utf8
> en_GB
> en_GB.iso88591
> en_GB.iso885915
> en_GB.utf8
> en_HK
> en_HK.iso88591
> en_HK.utf8
> en_IE
> en_IE@euro
> en_IE.iso88591
> en_IE.iso885915@euro
> en_IE.utf8
> en_IL
> en_IL.utf8
> en_IN
> en_IN.utf8
> en_NG
> en_NG.utf8
> en_NZ
> en_NZ.iso88591
> en_NZ.utf8
> en_PH
> en_PH.iso88591
> en_PH.utf8
> en_SC.utf8
> en_SG
> en_SG.iso88591
> en_SG.utf8
> en_US
> en_US.iso88591
> en_US.iso885915
> en_US.utf8
> en_ZA
> en_ZA.iso88591
> en_ZA.utf8
> en_ZM
> en_ZM.utf8
> en_ZW
> en_ZW.iso88591
> en_ZW.utf8
> POSIX
> 
> And then my Ubuntu 16.04 regular build env:
> C
> C.UTF-8
> en_AG
> en_AG.utf8
> en_AU.utf8
> en_BW.utf8
> en_CA.utf8
> en_DK.utf8
> en_GB.utf8
> en_HK.utf8
> en_IE.utf8
> en_IN
> en_IN.utf8
> en_NG
> en_NG.utf8
> en_NZ.utf8
> en_PH.utf8
> en_SG.utf8
> en_US.utf8
> en_ZA.utf8
> en_ZM
> en_ZM.utf8
> en_ZW.utf8
> POSIX

Does vim build cleanly on the 16.04 box? My working theory was the lack
of iso88591 locale variants may be causing some kind of issue...

Failing that can you send me the log.do_compile from a successful build
offlist and I can compare to my failing one (or send you my failing
compile log).

Cheers,

Richard

Re: [PATCH 2/2] vim: Update to 8.1.1198

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 2043 bytes --]

On Wed, Apr 24, 2019 at 02:50:51PM +0100, richard.purdie@linuxfoundation.org wrote:
> On Wed, 2019-04-24 at 07:29 -0400, Tom Rini wrote:
> > On Wed, Apr 24, 2019 at 08:40:01AM +0100, 
> > richard.purdie@linuxfoundation.org wrote:
> > 
> > > What does "locale -a" show for you?
> > 
> > On Fedora Core 29:
> > C
> > C.utf8
> > en_AG
> > en_AG.utf8
> > en_AU
> > en_AU.iso88591
> > en_AU.utf8
> > en_BW
> > en_BW.iso88591
> > en_BW.utf8
> > en_CA
> > en_CA.iso88591
> > en_CA.utf8
> > en_DK
> > en_DK.iso88591
> > en_DK.utf8
> > en_GB
> > en_GB.iso88591
> > en_GB.iso885915
> > en_GB.utf8
> > en_HK
> > en_HK.iso88591
> > en_HK.utf8
> > en_IE
> > en_IE@euro
> > en_IE.iso88591
> > en_IE.iso885915@euro
> > en_IE.utf8
> > en_IL
> > en_IL.utf8
> > en_IN
> > en_IN.utf8
> > en_NG
> > en_NG.utf8
> > en_NZ
> > en_NZ.iso88591
> > en_NZ.utf8
> > en_PH
> > en_PH.iso88591
> > en_PH.utf8
> > en_SC.utf8
> > en_SG
> > en_SG.iso88591
> > en_SG.utf8
> > en_US
> > en_US.iso88591
> > en_US.iso885915
> > en_US.utf8
> > en_ZA
> > en_ZA.iso88591
> > en_ZA.utf8
> > en_ZM
> > en_ZM.utf8
> > en_ZW
> > en_ZW.iso88591
> > en_ZW.utf8
> > POSIX
> > 
> > And then my Ubuntu 16.04 regular build env:
> > C
> > C.UTF-8
> > en_AG
> > en_AG.utf8
> > en_AU.utf8
> > en_BW.utf8
> > en_CA.utf8
> > en_DK.utf8
> > en_GB.utf8
> > en_HK.utf8
> > en_IE.utf8
> > en_IN
> > en_IN.utf8
> > en_NG
> > en_NG.utf8
> > en_NZ.utf8
> > en_PH.utf8
> > en_SG.utf8
> > en_US.utf8
> > en_ZA.utf8
> > en_ZM
> > en_ZM.utf8
> > en_ZW.utf8
> > POSIX
> 
> Does vim build cleanly on the 16.04 box? My working theory was the lack
> of iso88591 locale variants may be causing some kind of issue...

Yup.  I do a nodistro build of my changes before posting to be sure it
builds somewhere at least.

> Failing that can you send me the log.do_compile from a successful build
> offlist and I can compare to my failing one (or send you my failing
> compile log).

Coming up in a moment.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[RFC DO NOT APPLY][PATCH 3/2] vim: Add a work-around for some locale issues

[Tom Rini]

We do not support fully / correctly the certain locales.  Attempting
to use these with msgfmt in order to update the ".desktop" files exposes
this problem and leads to the compile failing.

Signed-off-by: Tom Rini <trini@konsulko.com>
---
 meta/recipes-support/vim/vim_8.1.1198.bb | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/meta/recipes-support/vim/vim_8.1.1198.bb b/meta/recipes-support/vim/vim_8.1.1198.bb
index d7b864ee8b94..6b17a3c90e68 100644
--- a/meta/recipes-support/vim/vim_8.1.1198.bb
+++ b/meta/recipes-support/vim/vim_8.1.1198.bb
@@ -36,6 +36,16 @@ do_configure () {
     touch src/auto/config.mk src/auto/config.h
 }
 
+do_compile() {
+    # We do not support fully / correctly the following locales.  Attempting
+    # to use these with msgfmt in order to update the ".desktop" files exposes
+    # this problem and leads to the compile failing.
+    for LOCALE in cs fr ko pl sk zh_CN zh_TW;do
+        echo -n > src/po/${LOCALE}.po
+    done
+    autotools_do_compile
+}
+
 #Available PACKAGECONFIG options are gtkgui, acl, x11, tiny
 PACKAGECONFIG ??= ""
 PACKAGECONFIG += " \
-- 
2.7.4