From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 462D7C282E1 for ; Tue, 23 Apr 2019 21:50:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 12F41218D3 for ; Tue, 23 Apr 2019 21:50:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556056202; bh=J+YHi1IzD02f61Iuwqcb2kR1LgPXS8gmgs5XrI4Xuj8=; h=In-Reply-To:References:Cc:From:Subject:To:Date:List-ID:From; b=Dbxc1ZoTAumTA/hU3nwDxWaFSr2f029nX0nIxGEewp+3LDDmWG72MyRR5OqCjtr38 A012rfx1Klx7WnHlv11m59qjmQyorF0BxucvmDfef76VKzBm3RpXV/W9GLqI6DgmVy jxYIUgwk9ly+vTIOZvc1OJzb8VVe0JJ/7x2gSlk0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727963AbfDWVuB (ORCPT ); Tue, 23 Apr 2019 17:50:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:50040 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726029AbfDWVuB (ORCPT ); Tue, 23 Apr 2019 17:50:01 -0400 Received: from localhost (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2CCF3218D2; Tue, 23 Apr 2019 21:50:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556056200; bh=J+YHi1IzD02f61Iuwqcb2kR1LgPXS8gmgs5XrI4Xuj8=; h=In-Reply-To:References:Cc:From:Subject:To:Date:From; b=X446voAG9HJWFqVCCpXoO3/SL6oUccLndgB8JOJUS7I/Q60Dv3ZTKu+l5P3Fx8/X2 LFlROxrBQdby105FMx//8RxF2n2yvBVjP8SdsKr21v2FCGX54LtYInJfGVMKDpHfuP XVWaWXZ7gvToiszkfcVxUjjdACRvWYl5SYW8EVHM= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <155493360763.20095.6174028293897341109@swboyd.mtv.corp.google.com> References: <1553269010-15591-1-git-send-email-abel.vesa@nxp.com> <155493360763.20095.6174028293897341109@swboyd.mtv.corp.google.com> Cc: Shawn Guo , Fabio Estevam , Aisheng Dong , Lucas Stach , Sascha Hauer , "linux-clk@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Linux Kernel Mailing List From: Stephen Boyd Subject: Re: [RFC 00/19] clk: imx: Switch the imx6 and imx7 to clk_hw based API To: Abel Vesa , Fabio Estevam Message-ID: <155605619927.15276.90300312265075245@swboyd.mtv.corp.google.com> User-Agent: alot/0.8 Date: Tue, 23 Apr 2019 14:49:59 -0700 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Stephen Boyd (2019-04-10 15:00:07) > Quoting Fabio Estevam (2019-03-22 09:24:54) > > Hi Abel, > >=20 > > On Fri, Mar 22, 2019 at 12:37 PM Abel Vesa wrote: > > > > > > This work is part of the effort of switching the entire imx clock dri= vers > > > towards clk_hw based API. In order to do that, we have to keep the old > >=20 > > Maybe I missed some earlier discussions on this topic, but let me ask > > a fundamental question first: what is the motivation for this API > > change? > >=20 > > I could not find the reasoning inside the series. >=20 > The reasoning should be added to the series, but I would like to see clk > providers only deal with clk_hw structures and not with clk structures. > This clearly divides the line between clk consumers and clk providers so > that we know if clk providers are using the clk API themselves. That's > why I introduced clk_hw_register() in the first place. >=20 FYI, I'm dropping this from my review queue under the assumption it will be sent again. Also, it would be nice to not have the wrappers at all in the next series so that everything is clk_hw based instead of clk based. Otherwise, it looks good to me and I'd like to see this work completed. Thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A917C10F03 for ; Tue, 23 Apr 2019 21:50:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2694C218D2 for ; Tue, 23 Apr 2019 21:50:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="P8n8OWT3"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="X446voAG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2694C218D2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:Message-ID:To:Subject:From: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NhjxUBSGhsXNVHV7qeWYVli4ZRF4Q14fKF1naIlUL8M=; b=P8n8OWT3o9oqqi R0TZUWz1S8lmIthzWD8s/nVXbrflvVvJvbEStQwnk5hHuZQGChxWKoQvl2UdB2wwC5qVJl0qbef1L L6+Yguux9dhQcrg7RkJUqYxZFa7kcJ92VAN3Dt63TfnUMWYghghEYQOqWsvREshurbCmCCniJJ/BV Xs+bkh6FsnBZ/qk0Eqct1O5XPS5dHb6wQCq5vbEPK+XyRI26r7lPCqqkpxSDBaU+Wc45lXYmjrjQ7 z8VlVVbSvYbDkFJk1MSsTV8GjD7RQoM+uucSuF7Htuwo+0+QNOy2XxJ9S3cDl24wGrZE2AKsi9GQv VYADiTiR3E+6SK5P6i3g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hJ3Ih-00085k-QA; Tue, 23 Apr 2019 21:50:03 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hJ3Ie-0007sb-Uy for linux-arm-kernel@lists.infradead.org; Tue, 23 Apr 2019 21:50:02 +0000 Received: from localhost (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2CCF3218D2; Tue, 23 Apr 2019 21:50:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556056200; bh=J+YHi1IzD02f61Iuwqcb2kR1LgPXS8gmgs5XrI4Xuj8=; h=In-Reply-To:References:Cc:From:Subject:To:Date:From; b=X446voAG9HJWFqVCCpXoO3/SL6oUccLndgB8JOJUS7I/Q60Dv3ZTKu+l5P3Fx8/X2 LFlROxrBQdby105FMx//8RxF2n2yvBVjP8SdsKr21v2FCGX54LtYInJfGVMKDpHfuP XVWaWXZ7gvToiszkfcVxUjjdACRvWYl5SYW8EVHM= MIME-Version: 1.0 In-Reply-To: <155493360763.20095.6174028293897341109@swboyd.mtv.corp.google.com> References: <1553269010-15591-1-git-send-email-abel.vesa@nxp.com> <155493360763.20095.6174028293897341109@swboyd.mtv.corp.google.com> From: Stephen Boyd Subject: Re: [RFC 00/19] clk: imx: Switch the imx6 and imx7 to clk_hw based API To: Abel Vesa , Fabio Estevam Message-ID: <155605619927.15276.90300312265075245@swboyd.mtv.corp.google.com> User-Agent: alot/0.8 Date: Tue, 23 Apr 2019 14:49:59 -0700 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190423_145001_009557_8FBDDE12 X-CRM114-Status: GOOD ( 15.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aisheng Dong , Linux Kernel Mailing List , Sascha Hauer , Fabio Estevam , Shawn Guo , "linux-clk@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Lucas Stach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Stephen Boyd (2019-04-10 15:00:07) > Quoting Fabio Estevam (2019-03-22 09:24:54) > > Hi Abel, > > > > On Fri, Mar 22, 2019 at 12:37 PM Abel Vesa wrote: > > > > > > This work is part of the effort of switching the entire imx clock drivers > > > towards clk_hw based API. In order to do that, we have to keep the old > > > > Maybe I missed some earlier discussions on this topic, but let me ask > > a fundamental question first: what is the motivation for this API > > change? > > > > I could not find the reasoning inside the series. > > The reasoning should be added to the series, but I would like to see clk > providers only deal with clk_hw structures and not with clk structures. > This clearly divides the line between clk consumers and clk providers so > that we know if clk providers are using the clk API themselves. That's > why I introduced clk_hw_register() in the first place. > FYI, I'm dropping this from my review queue under the assumption it will be sent again. Also, it would be nice to not have the wrappers at all in the next series so that everything is clk_hw based instead of clk based. Otherwise, it looks good to me and I'd like to see this work completed. Thanks! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel