Re: [PATCH] drm/i915/gen11: enable support for headerless msgs

From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: Dongwon Kim <dongwon.kim@intel.com>
Subject: Re: [PATCH] drm/i915/gen11: enable support for headerless msgs
Date: Wed, 24 Apr 2019 21:43:57 +0100	[thread overview]
Message-ID: <155613863741.3650.16652012603480113463@skylake-alporthouse-com> (raw)
In-Reply-To: <20190424203857.7317-1-dongwon.kim@intel.com>

Quoting Dongwon Kim (2019-04-24 21:38:57)
> Setting bit5 (headerless msg for preemptable GPGPU context) of SAMPLER_MODE
> register to enable support for the headless msgs on gen11. None of existing
> use cases will be affected by this as this change makes both types of message
> - headerless and w/ header supported at the same time. It also complies with
> the new recommendation for the default bit value for the next gen.
> 
> v2: rewrote commit message to include more information
> 
> Signed-off-by: Dongwon Kim <dongwon.kim@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_reg.h  |  1 +
>  drivers/gpu/drm/i915/intel_lrc.c | 18 ++++++++++++++++++
>  2 files changed, 19 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index b74824f0b5b1..b45042f71c0a 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -8862,6 +8862,7 @@ enum {
>  #define   GEN11_LSN_UNSLCVC_GAFS_HALF_SF_MAXALLOC      (1 << 7)
>  
>  #define GEN10_SAMPLER_MODE             _MMIO(0xE18C)
> +#define   GEN11_SAMPLER_ENABLE_HEADLESS_MSG    (1 << 5)
>  
>  /* IVYBRIDGE DPF */
>  #define GEN7_L3CDERRST1(slice)         _MMIO(0xB008 + (slice) * 0x200) /* L3CD Error Status 1 */
> diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
> index 4e0a351bfbca..07c8fe2a5549 100644
> --- a/drivers/gpu/drm/i915/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/intel_lrc.c
> @@ -1807,6 +1807,21 @@ static int gen8_init_common_ring(struct intel_engine_cs *engine)
>         return 0;
>  }
>  
> +static int gen11_init_render_ring(struct intel_engine_cs *engine)
> +{
> +       struct drm_i915_private *dev_priv = engine->i915;
> +       int ret;
> +
> +       ret = gen8_init_common_ring(engine);
> +       if (ret)
> +               return ret;
> +
> +       /* allow headerless messages for pre-emptable GPGPU contexts */
> +       I915_WRITE(GEN10_SAMPLER_MODE, _MASKED_BIT_ENABLE(GEN11_SAMPLER_ENABLE_HEADLESS_MSG));

But you didn't move this to icl_ctx_workarounds_init() where it will be
then checked by igt (making sure it remains set after resets and
resume).
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx