From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 01/45] drm/i915: Seal races between async GPU cancellation, retirement and signaling Date: Thu, 25 Apr 2019 11:42:03 +0100 Message-ID: <155618892353.13478.2164088942151832504@skylake-alporthouse-com> References: <20190425092004.9995-1-chris@chris-wilson.co.uk> <2b6f92b3-1fb3-512d-8087-be13d57fc19a@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id 53B4089213 for ; Thu, 25 Apr 2019 10:42:08 +0000 (UTC) In-Reply-To: <2b6f92b3-1fb3-512d-8087-be13d57fc19a@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org UXVvdGluZyBUdnJ0a28gVXJzdWxpbiAoMjAxOS0wNC0yNSAxMTozNTowMSkKPiAKPiBPbiAyNS8w NC8yMDE5IDEwOjE5LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gPiBDdXJyZW50bHkgdGhlcmUgaXMg YW4gdW5kZXJseWluZyBhc3N1bXB0aW9uIHRoYXQgaTkxNV9yZXF1ZXN0X3Vuc3VibWl0KCkKPiA+ IGlzIHN5bmNocm9ub3VzIHdydCB0aGUgR1BVIC0tIHRoYXQgaXMgdGhlIHJlcXVlc3QgaXMgbm8g bG9uZ2VyIGluIGZsaWdodAo+ID4gYXMgd2UgcmVtb3ZlIGl0LiBJbiB0aGUgbmVhciBmdXR1cmUg dGhhdCBtYXkgY2hhbmdlLCBhbmQgdGhpcyBtYXkgdXBzZXQKPiA+IG91ciBzaWduYWxpbmcgYXMg d2UgY2FuIHByb2Nlc3MgYW4gaW50ZXJydXB0IGZvciB0aGF0IHJlcXVlc3Qgd2hpbGUgaXQKPiA+ IGlzIG5vIGxvbmdlciBpbiBmbGlnaHQuCj4gPiAKPiA+IENQVTAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgQ1BVMQo+ID4gaW50ZWxfZW5naW5lX2JyZWFkY3J1bWJzX2lycQo+ID4g KHF1ZXVlIHJlcXVlc3QgY29tcGxldGlvbikKPiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgaTkxNV9yZXF1ZXN0X2NhbmNlbF9zaWduYWxpbmcKPiA+IC4uLiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgLi4uCj4gPiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGk5MTVfcmVxdWVzdF9lbmFibGVfc2lnbmFsaW5nCj4gPiBkbWFfZmVu Y2Vfc2lnbmFsCj4gPiAKPiA+IEhlbmNlIGluIHRoZSB0aW1lIGl0IHRvb2sgdXMgdG8gZHJvcCB0 aGUgbG9jayB0byBzaWduYWwgdGhlIHJlcXVlc3QsIGEKPiA+IHByZWVtcHRpb24gZXZlbnQgbWF5 IGhhdmUgb2NjdXJyZWQgYW5kIHJlLXF1ZXVlZCB0aGUgcmVxdWVzdC4gSW4gdGhlCj4gPiBwcm9j ZXNzLCB0aGF0IHJlcXVlc3Qgd291bGQgaGF2ZSBzZWVuIEk5MTVfRkVOQ0VfRkxBR19TSUdOQUwg Y2xlYXIgYW5kCj4gPiBzbyByZXVzZWQgdGhlIHJxLT5zaWduYWxfbGluayB0aGF0IHdhcyBpbiB1 c2Ugb24gQ1BVMCwgbGVhZGluZyB0byBiYWQKPiA+IHBvaW50ZXIgY2hhc2luZyBpbiBpbnRlbF9l bmdpbmVfYnJlYWRjcnVtYnNfaXJxLgo+ID4gCj4gPiBBIHJlbGF0ZWQgaXNzdWUgd2FzIHRoYXQg aWYgc29tZW9uZSBzdGFydGVkIGxpc3RlbmluZyBmb3IgYSBzaWduYWwgb24gYQo+ID4gY29tcGxl dGVkIGJ1dCBubyBsb25nZXIgaW4tZmxpZ2h0IHJlcXVlc3QsIHdlIG1pc3NlZCB0aGUgb3Bwb3J0 dW5pdHkgdG8KPiA+IGltbWVkaWF0ZWx5IHNpZ25hbCB0aGF0IHJlcXVlc3QuCj4gPiAKPiA+IEZ1 cnRoZXJtb3JlLCBhcyBpbnRlbF9jb250ZXh0cyBtYXkgYmUgaW1tZWRpYXRlbHkgcmVsZWFzZWQg ZHVyaW5nCj4gPiByZXF1ZXN0IHJldGlyZW1lbnQsIGluIG9yZGVyIHRvIGJlIGVudGlyZWx5IHN1 cmUgdGhhdAo+ID4gaW50ZWxfZW5naW5lX2JyZWFkY3J1bWJzX2lycSBtYXkgbm8gbG9uZ2VyIGRl cmVmZXJlbmNlIHRoZSBpbnRlbF9jb250ZXh0Cj4gPiAoY2UtPnNpZ25hbHMgYW5kIGNlLT5zaWdu YWxfbGluayksIHdlIG11c3Qgd2FpdCBmb3IgaXJxIHNwaW5sb2NrLgo+ID4gCj4gPiBJbiBvcmRl ciB0byBwcmV2ZW50IHRoZSByYWNlLCB3ZSB1c2UgYSBiaXQgaW4gdGhlIGZlbmNlLmZsYWdzIHRv IHNpZ25hbAo+ID4gdGhlIHRyYW5zZmVyIG9udG8gdGhlIHNpZ25hbCBsaXN0IGluc2lkZSBpbnRl bF9lbmdpbmVfYnJlYWRjcnVtYnNfaXJxLgo+ID4gRm9yIHNpbXBsaWNpdHksIHdlIHVzZSB0aGUg RE1BX0ZFTkNFX0ZMQUdfU0lHTkFMRURfQklUIGFzIGl0IHRoZW4KPiA+IHF1aWNrbHkgc2lnbmFs cyB0byBhbnkgb3V0c2lkZSBvYnNlcnZlciB0aGF0IHRoZSBmZW5jZSBpcyBpbmRlZWQgc2lnbmFs ZWQuCj4gPiAKPiA+IEZpeGVzOiA1MmMwZmRiMjVjN2MgKCJkcm0vaTkxNTogUmVwbGFjZSBnbG9i YWwgYnJlYWRjcnVtYnMgd2l0aCBwZXItY29udGV4dCBpbnRlcnJ1cHQgdHJhY2tpbmciKQo+ID4g U2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4g PiBDYzogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPiA+IC0tLQo+ ID4gICBkcml2ZXJzL2RtYS1idWYvZG1hLWZlbmNlLmMgICAgICAgICAgICAgICAgIHwgIDEgKwo+ ID4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9ndC9pbnRlbF9icmVhZGNydW1icy5jIHwgNTggKysr KysrKysrKysrKy0tLS0tLS0tCj4gPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVxdWVz dC5jICAgICAgICAgfCAgMSArCj4gPiAgIDMgZmlsZXMgY2hhbmdlZCwgMzkgaW5zZXJ0aW9ucygr KSwgMjEgZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2RtYS1idWYv ZG1hLWZlbmNlLmMgYi9kcml2ZXJzL2RtYS1idWYvZG1hLWZlbmNlLmMKPiA+IGluZGV4IDNhYTg3 MzNmODMyYS4uOWJmMDYwNDI2MTlhIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9kbWEtYnVmL2Rt YS1mZW5jZS5jCj4gPiArKysgYi9kcml2ZXJzL2RtYS1idWYvZG1hLWZlbmNlLmMKPiA+IEBAIC0y OSw2ICsyOSw3IEBACj4gPiAgIAo+ID4gICBFWFBPUlRfVFJBQ0VQT0lOVF9TWU1CT0woZG1hX2Zl bmNlX2VtaXQpOwo+ID4gICBFWFBPUlRfVFJBQ0VQT0lOVF9TWU1CT0woZG1hX2ZlbmNlX2VuYWJs ZV9zaWduYWwpOwo+ID4gK0VYUE9SVF9UUkFDRVBPSU5UX1NZTUJPTChkbWFfZmVuY2Vfc2lnbmFs ZWQpOwo+ID4gICAKPiA+ICAgc3RhdGljIERFRklORV9TUElOTE9DSyhkbWFfZmVuY2Vfc3R1Yl9s b2NrKTsKPiA+ICAgc3RhdGljIHN0cnVjdCBkbWFfZmVuY2UgZG1hX2ZlbmNlX3N0dWI7Cj4gPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3QvaW50ZWxfYnJlYWRjcnVtYnMuYyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L2ludGVsX2JyZWFkY3J1bWJzLmMKPiA+IGluZGV4IDNj YmZmZDQwMGIxYi4uNDI4MzIyNDI0OWQ0IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvZ3QvaW50ZWxfYnJlYWRjcnVtYnMuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvZ3QvaW50ZWxfYnJlYWRjcnVtYnMuYwo+ID4gQEAgLTIzLDYgKzIzLDcgQEAKPiA+ICAgICov Cj4gPiAgIAo+ID4gICAjaW5jbHVkZSA8bGludXgva3RocmVhZC5oPgo+ID4gKyNpbmNsdWRlIDx0 cmFjZS9ldmVudHMvZG1hX2ZlbmNlLmg+Cj4gPiAgICNpbmNsdWRlIDx1YXBpL2xpbnV4L3NjaGVk L3R5cGVzLmg+Cj4gPiAgIAo+ID4gICAjaW5jbHVkZSAiaTkxNV9kcnYuaCIKPiA+IEBAIC04Myw2 ICs4NCw3IEBAIHN0YXRpYyBpbmxpbmUgYm9vbCBfX3JlcXVlc3RfY29tcGxldGVkKGNvbnN0IHN0 cnVjdCBpOTE1X3JlcXVlc3QgKnJxKQo+ID4gICB2b2lkIGludGVsX2VuZ2luZV9icmVhZGNydW1i c19pcnEoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ID4gICB7Cj4gPiAgICAgICBz dHJ1Y3QgaW50ZWxfYnJlYWRjcnVtYnMgKmIgPSAmZW5naW5lLT5icmVhZGNydW1iczsKPiA+ICsg ICAgIGNvbnN0IGt0aW1lX3QgdGltZXN0YW1wID0ga3RpbWVfZ2V0KCk7Cj4gPiAgICAgICBzdHJ1 Y3QgaW50ZWxfY29udGV4dCAqY2UsICpjbjsKPiA+ICAgICAgIHN0cnVjdCBsaXN0X2hlYWQgKnBv cywgKm5leHQ7Cj4gPiAgICAgICBMSVNUX0hFQUQoc2lnbmFsKTsKPiA+IEBAIC0xMDQsNiArMTA2 LDExIEBAIHZvaWQgaW50ZWxfZW5naW5lX2JyZWFkY3J1bWJzX2lycShzdHJ1Y3QgaW50ZWxfZW5n aW5lX2NzICplbmdpbmUpCj4gPiAgIAo+ID4gICAgICAgICAgICAgICAgICAgICAgIEdFTV9CVUdf T04oIXRlc3RfYml0KEk5MTVfRkVOQ0VfRkxBR19TSUdOQUwsCj4gPiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgJnJxLT5mZW5jZS5mbGFncykpOwo+ID4gKyAgICAg ICAgICAgICAgICAgICAgIGNsZWFyX2JpdChJOTE1X0ZFTkNFX0ZMQUdfU0lHTkFMLCAmcnEtPmZl bmNlLmZsYWdzKTsKPiA+ICsKPiA+ICsgICAgICAgICAgICAgICAgICAgICBpZiAodGVzdF9hbmRf c2V0X2JpdChETUFfRkVOQ0VfRkxBR19TSUdOQUxFRF9CSVQsCj4gPiArICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgJnJxLT5mZW5jZS5mbGFncykpCj4gPiArICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBjb250aW51ZTsKPiA+ICAgCj4gPiAgICAgICAgICAgICAg ICAgICAgICAgLyoKPiA+ICAgICAgICAgICAgICAgICAgICAgICAgKiBRdWV1ZSBmb3IgZXhlY3V0 aW9uIGFmdGVyIGRyb3BwaW5nIHRoZSBzaWduYWxpbmcKPiA+IEBAIC0xMTEsMTQgKzExOCw2IEBA IHZvaWQgaW50ZWxfZW5naW5lX2JyZWFkY3J1bWJzX2lycShzdHJ1Y3QgaW50ZWxfZW5naW5lX2Nz ICplbmdpbmUpCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICogbW9yZSBzaWduYWxlcnMgdG8g dGhlIHNhbWUgY29udGV4dCBvciBlbmdpbmUuCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICov Cj4gPiAgICAgICAgICAgICAgICAgICAgICAgaTkxNV9yZXF1ZXN0X2dldChycSk7Cj4gPiAtCj4g PiAtICAgICAgICAgICAgICAgICAgICAgLyoKPiA+IC0gICAgICAgICAgICAgICAgICAgICAgKiBX ZSBtYXkgcmFjZSB3aXRoIGRpcmVjdCBpbnZvY2F0aW9uIG9mCj4gPiAtICAgICAgICAgICAgICAg ICAgICAgICogZG1hX2ZlbmNlX3NpZ25hbCgpLCBlLmcuIGk5MTVfcmVxdWVzdF9yZXRpcmUoKSwK PiA+IC0gICAgICAgICAgICAgICAgICAgICAgKiBzbyB3ZSBuZWVkIHRvIGFjcXVpcmUgb3VyIHJl ZmVyZW5jZSB0byB0aGUgcmVxdWVzdAo+ID4gLSAgICAgICAgICAgICAgICAgICAgICAqIGJlZm9y ZSB3ZSBjYW5jZWwgdGhlIGJyZWFkY3J1bWIuCj4gPiAtICAgICAgICAgICAgICAgICAgICAgICov Cj4gPiAtICAgICAgICAgICAgICAgICAgICAgY2xlYXJfYml0KEk5MTVfRkVOQ0VfRkxBR19TSUdO QUwsICZycS0+ZmVuY2UuZmxhZ3MpOwo+ID4gICAgICAgICAgICAgICAgICAgICAgIGxpc3RfYWRk X3RhaWwoJnJxLT5zaWduYWxfbGluaywgJnNpZ25hbCk7Cj4gPiAgICAgICAgICAgICAgIH0KPiA+ ICAgCj4gPiBAQCAtMTQwLDggKzEzOSwyMSBAQCB2b2lkIGludGVsX2VuZ2luZV9icmVhZGNydW1i c19pcnEoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ID4gICAgICAgbGlzdF9mb3Jf ZWFjaF9zYWZlKHBvcywgbmV4dCwgJnNpZ25hbCkgewo+ID4gICAgICAgICAgICAgICBzdHJ1Y3Qg aTkxNV9yZXF1ZXN0ICpycSA9Cj4gPiAgICAgICAgICAgICAgICAgICAgICAgbGlzdF9lbnRyeShw b3MsIHR5cGVvZigqcnEpLCBzaWduYWxfbGluayk7Cj4gPiArICAgICAgICAgICAgIHN0cnVjdCBk bWFfZmVuY2VfY2IgKmN1ciwgKnRtcDsKPiA+ICsKPiA+ICsgICAgICAgICAgICAgdHJhY2VfZG1h X2ZlbmNlX3NpZ25hbGVkKCZycS0+ZmVuY2UpOwo+ID4gKwo+ID4gKyAgICAgICAgICAgICBycS0+ ZmVuY2UudGltZXN0YW1wID0gdGltZXN0YW1wOwo+ID4gKyAgICAgICAgICAgICBzZXRfYml0KERN QV9GRU5DRV9GTEFHX1RJTUVTVEFNUF9CSVQsICZycS0+ZmVuY2UuZmxhZ3MpOwo+ID4gKwo+ID4g KyAgICAgICAgICAgICBzcGluX2xvY2soJnJxLT5sb2NrKTsKPiA+ICsgICAgICAgICAgICAgbGlz dF9mb3JfZWFjaF9lbnRyeV9zYWZlKGN1ciwgdG1wLCAmcnEtPmZlbmNlLmNiX2xpc3QsIG5vZGUp IHsKPiA+ICsgICAgICAgICAgICAgICAgICAgICBJTklUX0xJU1RfSEVBRCgmY3VyLT5ub2RlKTsK PiA+ICsgICAgICAgICAgICAgICAgICAgICBjdXItPmZ1bmMoJnJxLT5mZW5jZSwgY3VyKTsKPiA+ ICsgICAgICAgICAgICAgfQo+ID4gKyAgICAgICAgICAgICBJTklUX0xJU1RfSEVBRCgmcnEtPmZl bmNlLmNiX2xpc3QpOwo+ID4gKyAgICAgICAgICAgICBzcGluX3VubG9jaygmcnEtPmxvY2spOwo+ ID4gICAKPiA+IC0gICAgICAgICAgICAgZG1hX2ZlbmNlX3NpZ25hbCgmcnEtPmZlbmNlKTsKPiAK PiBJIHBvc3RlZCBzb21lIGNvbW1lbnRzIG9uIHRoaXMgcGF0Y2ggYWxyZWFkeS4gSW4gZXNzZW5j ZSBpdCB3YXMgYSAKPiBzdWdnZXN0aW9uIHRvIG5vdCBvcGVuLWNvZGUtYW5kLW9wdGltaXplIGRt YV9mZW5jZV9zaWduYWwsIGJ1dCBzcGxpdCBpdCAKPiBpbnRvIHR3byBsb3ctbGV2ZWwgaGVscGVy cyBhbmQgZXhwb3J0IGZyb20gdGhlIHBhcmVudCBsb2NhdGlvbi4gTGlrZSAKPiBfX2RtYV9mZW5j ZV9tYXliZS9zdGFydF9zaWduYWwgYW5kIF9fZG1hX2ZlbmNlX2ZpbmlzaF9zaWduYWwuCj4gCj4g Ym9vbCBfX2RtYV9mZW5jZV9zdGFydF9zaWduYWwoLi4uKQo+IHsKPiAgICAgICAgIHJldHVybiB0 ZXN0X2FuZF9zZXRfYml0KERNQV9GRU5DRV9GTEFHX1NJR05BTEVEX0JJVCwKPiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGZlbmNlLT5mbGFncyk7Cj4gfQo+IEVYUE9SVF9TWU1CT0wo Li4uKQo+IAo+IHZvaWQgX19kbWFfZmVuY2VfZmluaXNoX3NpZ25hbCguLi4pCj4gewo+ICAgICAg ICAgdHJhY2VfZG1hX2ZlbmNlX3NpZ25hbGVkLi4uCj4gICAgICAgICB0aW1lc3RhbXAuLi4KPiAg ICAgICAgIGNhbGxiYWNrcy4uLgo+IH0KPiBFWFBPUlRfU1lNQk9MKC4uLikKPiAKPiBUaGlzIHdh eSB3ZSBkb24ndCBhZGQgY291cGxpbmcgdG8gbG93IGxldmVsIGltcGxlbWVudGF0aW9uIGRldGFp bHMgaW4gaTkxNS4KCllvdSBtZWFuIG1pZGxheWVyIGltcGxlbWVudGF0aW9uIGRldGFpbHMgOi1w CgpUaGUgYWx0ZXJuYXRpdmUgSSBtZW50aW9uZWQgd2FzIHRoYXQgd2UgdXNlIGEgcmVkdW5kYW50 IGJpdC4gQnV0IHRoYXQKaGFzIGR1cGxpY2l0eSBvZiBwdXJwb3NlLgoKVGhlIHBhdGNoIG5lZWRz IHRvIGJlIHN0YWJsZS1mcmllbmRseSBmb3IgdGhlIGZpeGVzLCBzbyBJIG9wdGVkIGZvcgp0YWtp bmcgY29udHJvbC4KLUNocmlzCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu dGVsLWdmeA==