All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicholas Piggin <npiggin@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
	linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] kernel/sched: run nohz idle load balancer on HK_FLAG_MISC CPUs
Date: Fri, 26 Apr 2019 14:40:40 +1000	[thread overview]
Message-ID: <1556253219.geomfr4bo2.astroid@bobo.none> (raw)
In-Reply-To: <20190425115620.GQ4038@hirez.programming.kicks-ass.net>

Peter Zijlstra's on April 25, 2019 9:56 pm:
> On Fri, Apr 12, 2019 at 02:26:13PM +1000, Nicholas Piggin wrote:
>> The nohz idle balancer runs on the lowest idle CPU. This can
>> interfere with isolated CPUs, so confine it to HK_FLAG_MISC
>> housekeeping CPUs.
>> 
>> HK_FLAG_SCHED is not used for this because it is not set anywhere
>> at the moment. This could be folded into HK_FLAG_SCHED once that
>> option is fixed.
> 
> Frederic? Anyway, I thnk I'll take this patch as is.

That would be great, thanks. We've been testing it in a staging
environment (this is where they noticed the noise in the first
place), and results have been as expected:

  I've been able to test Nick's idle-loop load balancer (ILB) patch, 
  with and without the TEO cpuidle governor. With the ILB patch (and 
  nohz_full) I get a very quiet noise profile with either cpuidle 
  governor (menu or teo). For my tests, I don't see a meaningful 
  difference between the two governors.

  [...]

  Bottom line: Nick's patch that constrains the ILB to run on non-nohz 
  cores has a noticeable noise-reduction effect. For this type of 
  workload, the choice of cpuidle governor, menu or teo, is immaterial.

This is against a slightly backported RHEL kernel they are using, but
no significant differences from upstream in these areas.

Thanks,
Nick


  reply	other threads:[~2019-04-26  4:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-12  4:26 [PATCH] kernel/sched: run nohz idle load balancer on HK_FLAG_MISC CPUs Nicholas Piggin
2019-04-25 11:56 ` Peter Zijlstra
2019-04-26  4:40   ` Nicholas Piggin [this message]
2019-04-28  7:01 ` Wanpeng Li
2019-04-28 11:58   ` Nicholas Piggin
2019-04-29  6:38 ` [tip:sched/core] sched/nohz: Run NOHZ " tip-bot for Nicholas Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1556253219.geomfr4bo2.astroid@bobo.none \
    --to=npiggin@gmail.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.