From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7B521892E6 for ; Fri, 26 Apr 2019 05:40:35 +0000 (UTC) MIME-Version: 1.0 From: Chris Wilson References: <20190425205822.8995-1-daniel.t.mrzyglod@intel.com> <20190425205822.8995-4-daniel.t.mrzyglod@intel.com> In-Reply-To: <20190425205822.8995-4-daniel.t.mrzyglod@intel.com> Message-ID: <155625723098.3869.5434947766903910774@skylake-alporthouse-com> Date: Fri, 26 Apr 2019 06:40:31 +0100 Subject: Re: [igt-dev] [PATCH i-g-t v4 3/6] lib/intel_mmio: use igt_device_map_pci_bar_region for mmap if fd is known. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Daniel Mrzyglod , igt-dev@lists.freedesktop.org List-ID: UXVvdGluZyBEYW5pZWwgTXJ6eWdsb2QgKDIwMTktMDQtMjUgMjE6NTg6MTkpCj4gIHZvaWQKPiAt aW50ZWxfbW1pb191c2VfcGNpX2JhcihzdHJ1Y3QgcGNpX2RldmljZSAqcGNpX2RldikKPiAraW50 ZWxfbW1pb191c2VfcGNpX2JhcihzdHJ1Y3QgcGNpX2RldmljZSAqcGNpX2RldiwgaW50IGZkKQo+ ICB7Cj4gICAgICAgICB1aW50MzJfdCBkZXZpZCwgZ2VuOwo+ICAgICAgICAgaW50IG1taW9fYmFy LCBtbWlvX3NpemU7Cj4gQEAgLTEzNSwxNCArMTM2LDI4IEBAIGludGVsX21taW9fdXNlX3BjaV9i YXIoc3RydWN0IHBjaV9kZXZpY2UgKnBjaV9kZXYpCj4gICAgICAgICBlbHNlCj4gICAgICAgICAg ICAgICAgIG1taW9fc2l6ZSA9IDIqMTAyNCoxMDI0Owo+ICAKPiAtICAgICAgIGVycm9yID0gcGNp X2RldmljZV9tYXBfcmFuZ2UgKHBjaV9kZXYsCj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBwY2lfZGV2LT5yZWdpb25zW21taW9fYmFyXS5iYXNlX2FkZHIsCj4gLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBtbWlvX3NpemUsCj4gLSAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBQQ0lfREVWX01BUF9GTEFHX1dSSVRBQkxFLAo+IC0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJmlndF9nbG9iYWxfbW1pbyk7Cj4g KyAgICAgICAvKiBJdCdzIGZvciBzb21lIGxlZ2FjeSB0b29scyBleGlzdGluZyBpbiB0cmVlIHRo YXQgcmVxdWlyZQo+ICsgICAgICAgICogd29ya2luZyB3aXRob3V0IGRyaXZlcgo+ICsgICAgICAg ICovCj4gKwo+ICsgICAgICAgaWYgKGZkID09IC0xKSB7Cj4gKyAgICAgICAgICAgICAgIGVycm9y ID0gcGNpX2RldmljZV9tYXBfcmFuZ2UocGNpX2RldiwKPiArICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBwY2lfZGV2LT5yZWdpb25zW21taW9fYmFyXS5iYXNlX2Fk ZHIsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbW1pb19z aXplLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFBDSV9E RVZfTUFQX0ZMQUdfV1JJVEFCTEUsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgJmlndF9nbG9iYWxfbW1pbyk7Cj4gKwo+ICsgICAgICAgICAgICAgICBpZ3Rf ZmFpbF9vbl9mKGVycm9yICE9IDAsICJDb3VsZG4ndCBtYXAgTU1JTyByZWdpb25cbiIpOwo+ICsg ICAgICAgfSBlbHNlIHsKPiArICAgICAgICAgICAgICAgLyogVGhpcyBtZXRob2QgaXMgbXVjaCBt b3JlIGNvbnZlbmllbnQgd2hlbiB3ZSBoYXZlIG1hbnkKPiArICAgICAgICAgICAgICAgICogY29u Y3VycmVudCBQQ0kgZGV2aWNlcwo+ICsgICAgICAgICAgICAgICAgKi8KPiArICAgICAgICAgICAg ICAgaWd0X2dsb2JhbF9tbWlvID0gaWd0X2RldmljZV9tYXBfcGNpX2Jhcl9yZWdpb24oZmQsIG1t aW9fYmFyLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBtbWlvX3NpemUpOwo+ICsgICAgICAgICAgICAgICBpZ3RfZmFpbF9v bl9mKG1taW9fZGF0YS0+aWd0X21taW8gPT0gTUFQX0ZBSUxFRCwKPiArICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAiQ291bGRuJ3QgbWFwIE1NSU8gcmVnaW9uXG4iKTsKClRoaXMgbWFrZXMg bm8gc2Vuc2UgdG8gbWUgYXQgYWxsLiBXZSBhbHJlYWR5IGhhdmUgdGhlIHBjaV9kZXZpY2Ugd2UK d2FudCBhbmQgdGhlIEJBUiB3ZSB3YW50IHRvIG1tYXAsIHNvIHdoeSByZXBlYXQgb3Vyc2VsdmVz PwoKSWYgeW91IGRpZG4ndCB3YW50IHRoYXQgcGNpX2Rldiwgd2h5IGFyZSB3ZSBwYXNzaW5nIGFy b3VuZCB0aGUgd3JvbmcKb25lPwotQ2hyaXMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KaWd0LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pZ3QtZGV2