From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B273C43219 for ; Sun, 28 Apr 2019 12:16:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5F6C72075D for ; Sun, 28 Apr 2019 12:16:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726691AbfD1MQi (ORCPT ); Sun, 28 Apr 2019 08:16:38 -0400 Received: from Mailgw01.mediatek.com ([1.203.163.78]:56089 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726480AbfD1MQh (ORCPT ); Sun, 28 Apr 2019 08:16:37 -0400 X-UUID: 1f637e104eea43569a06ec1c775d2b48-20190428 X-UUID: 1f637e104eea43569a06ec1c775d2b48-20190428 Received: from mtkcas34.mediatek.inc [(172.27.4.253)] by mailgw01.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 1683014745; Sun, 28 Apr 2019 20:16:30 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31DR.mediatek.inc (172.27.6.102) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sun, 28 Apr 2019 20:16:29 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Sun, 28 Apr 2019 20:16:28 +0800 Message-ID: <1556453788.10179.224.camel@mhfsdcap03> Subject: Re: [PATCH v4 3/6] dt-bindings: usb: mtu3: add properties about USB Role Switch From: Chunfeng Yun To: Rob Herring CC: Greg Kroah-Hartman , Heikki Krogerus , Mark Rutland , Matthias Brugger , Adam Thomson , Li Jun , "Badhri Jagan Sridharan" , Hans de Goede , Andy Shevchenko , Min Guo , , , , , , Biju Das , Linus Walleij Date: Sun, 28 Apr 2019 20:16:28 +0800 In-Reply-To: <20190426204906.GB15074@bogus> References: <1556261237-13823-1-git-send-email-chunfeng.yun@mediatek.com> <1556261237-13823-4-git-send-email-chunfeng.yun@mediatek.com> <20190426204906.GB15074@bogus> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2019-04-26 at 15:49 -0500, Rob Herring wrote: > On Fri, Apr 26, 2019 at 02:47:14PM +0800, Chunfeng Yun wrote: > > Now the USB Role Switch is supported, so add properties about it > > > > Signed-off-by: Chunfeng Yun > > --- > > v4: no changes > > v3: no changes > > > > v2 changes: > > 1. fix typo > > 2. refer new binding about connector property > > --- > > .../devicetree/bindings/usb/mediatek,mtu3.txt | 10 ++++++++-- > > 1 file changed, 8 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt > > index 3382b5cb471d..6e004c4a89af 100644 > > --- a/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt > > +++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt > > @@ -27,7 +27,9 @@ Optional properties: > > - ranges : allows valid 1:1 translation between child's address space and > > parent's address space > > - extcon : external connector for vbus and idpin changes detection, needed > > - when supports dual-role mode. > > + when supports dual-role mode; it's consiedered valid for compatibility > > + reasons, and not allowed for new bindings, use the property > > + usb-role-switch instead. > > - vbus-supply : reference to the VBUS regulator, needed when supports > > dual-role mode. > > - pinctrl-names : a pinctrl state named "default" is optional, and need be > > @@ -36,7 +38,8 @@ Optional properties: > > is not set. > > - pinctrl-0 : pin control group > > See: Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt > > - > > + - usb-role-switch : use USB Role Switch to support dual-role switch, but > > + not extcon > > Coordinate with the Renesas and HiSilicon folks implementing the same > thing and put this in a common spot. I'll prepare a patch for it, and CC Biju and Yu > However, I think this should not > even be needed as knowing the controller capabilities (based on the > compatible) and knowing the type of connector should be enough > information to tell you if dual role is supported or not. Some Dual-Role controller drivers already used extcon framework to handle role switch, if try to support the new USB Role Switch framework, the driver may want to know which way will be used. Sometimes users also want to use dual-role even use the type-A, such as use sys interface to handle role switch, so only knowing the connector type can't tell driver which way to use > > > - maximum-speed : valid arguments are "super-speed", "high-speed" and > > "full-speed"; refer to usb/generic.txt > > - enable-manual-drd : supports manual dual-role switch via debugfs; usually > > @@ -61,6 +64,9 @@ The xhci should be added as subnode to mtu3 as shown in the following example > > if host mode is enabled. The DT binding details of xhci can be found in: > > Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt > > > > +The port would be added as subnode if use usb-role-switch property > > + see graph.txt > > + > > Example: > > ssusb: usb@11271000 { > > compatible = "mediatek,mt8173-mtu3"; > > -- > > 2.21.0 > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chunfeng Yun Subject: Re: [PATCH v4 3/6] dt-bindings: usb: mtu3: add properties about USB Role Switch Date: Sun, 28 Apr 2019 20:16:28 +0800 Message-ID: <1556453788.10179.224.camel@mhfsdcap03> References: <1556261237-13823-1-git-send-email-chunfeng.yun@mediatek.com> <1556261237-13823-4-git-send-email-chunfeng.yun@mediatek.com> <20190426204906.GB15074@bogus> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190426204906.GB15074@bogus> Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring Cc: Greg Kroah-Hartman , Heikki Krogerus , Mark Rutland , Matthias Brugger , Adam Thomson , Li Jun , Badhri Jagan Sridharan , Hans de Goede , Andy Shevchenko , Min Guo , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Biju Das , Linus Walleij List-Id: devicetree@vger.kernel.org On Fri, 2019-04-26 at 15:49 -0500, Rob Herring wrote: > On Fri, Apr 26, 2019 at 02:47:14PM +0800, Chunfeng Yun wrote: > > Now the USB Role Switch is supported, so add properties about it > > > > Signed-off-by: Chunfeng Yun > > --- > > v4: no changes > > v3: no changes > > > > v2 changes: > > 1. fix typo > > 2. refer new binding about connector property > > --- > > .../devicetree/bindings/usb/mediatek,mtu3.txt | 10 ++++++++-- > > 1 file changed, 8 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt > > index 3382b5cb471d..6e004c4a89af 100644 > > --- a/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt > > +++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt > > @@ -27,7 +27,9 @@ Optional properties: > > - ranges : allows valid 1:1 translation between child's address space and > > parent's address space > > - extcon : external connector for vbus and idpin changes detection, needed > > - when supports dual-role mode. > > + when supports dual-role mode; it's consiedered valid for compatibility > > + reasons, and not allowed for new bindings, use the property > > + usb-role-switch instead. > > - vbus-supply : reference to the VBUS regulator, needed when supports > > dual-role mode. > > - pinctrl-names : a pinctrl state named "default" is optional, and need be > > @@ -36,7 +38,8 @@ Optional properties: > > is not set. > > - pinctrl-0 : pin control group > > See: Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt > > - > > + - usb-role-switch : use USB Role Switch to support dual-role switch, but > > + not extcon > > Coordinate with the Renesas and HiSilicon folks implementing the same > thing and put this in a common spot. I'll prepare a patch for it, and CC Biju and Yu > However, I think this should not > even be needed as knowing the controller capabilities (based on the > compatible) and knowing the type of connector should be enough > information to tell you if dual role is supported or not. Some Dual-Role controller drivers already used extcon framework to handle role switch, if try to support the new USB Role Switch framework, the driver may want to know which way will be used. Sometimes users also want to use dual-role even use the type-A, such as use sys interface to handle role switch, so only knowing the connector type can't tell driver which way to use > > > - maximum-speed : valid arguments are "super-speed", "high-speed" and > > "full-speed"; refer to usb/generic.txt > > - enable-manual-drd : supports manual dual-role switch via debugfs; usually > > @@ -61,6 +64,9 @@ The xhci should be added as subnode to mtu3 as shown in the following example > > if host mode is enabled. The DT binding details of xhci can be found in: > > Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt > > > > +The port would be added as subnode if use usb-role-switch property > > + see graph.txt > > + > > Example: > > ssusb: usb@11271000 { > > compatible = "mediatek,mt8173-mtu3"; > > -- > > 2.21.0 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v4,3/6] dt-bindings: usb: mtu3: add properties about USB Role Switch From: Chunfeng Yun Message-Id: <1556453788.10179.224.camel@mhfsdcap03> Date: Sun, 28 Apr 2019 20:16:28 +0800 To: Rob Herring Cc: Greg Kroah-Hartman , Heikki Krogerus , Mark Rutland , Matthias Brugger , Adam Thomson , Li Jun , Badhri Jagan Sridharan , Hans de Goede , Andy Shevchenko , Min Guo , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Biju Das , Linus Walleij List-ID: T24gRnJpLCAyMDE5LTA0LTI2IGF0IDE1OjQ5IC0wNTAwLCBSb2IgSGVycmluZyB3cm90ZToKPiBP biBGcmksIEFwciAyNiwgMjAxOSBhdCAwMjo0NzoxNFBNICswODAwLCBDaHVuZmVuZyBZdW4gd3Jv dGU6Cj4gPiBOb3cgdGhlIFVTQiBSb2xlIFN3aXRjaCBpcyBzdXBwb3J0ZWQsIHNvIGFkZCBwcm9w ZXJ0aWVzIGFib3V0IGl0Cj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IENodW5mZW5nIFl1biA8Y2h1 bmZlbmcueXVuQG1lZGlhdGVrLmNvbT4KPiA+IC0tLQo+ID4gdjQ6IG5vIGNoYW5nZXMKPiA+IHYz OiBubyBjaGFuZ2VzCj4gPiAKPiA+IHYyIGNoYW5nZXM6Cj4gPiAgIDEuIGZpeCB0eXBvCj4gPiAg IDIuIHJlZmVyIG5ldyBiaW5kaW5nIGFib3V0IGNvbm5lY3RvciBwcm9wZXJ0eQo+ID4gLS0tCj4g PiAgLi4uL2RldmljZXRyZWUvYmluZGluZ3MvdXNiL21lZGlhdGVrLG10dTMudHh0ICAgICAgICAg IHwgMTAgKysrKysrKystLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDIg ZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRy ZWUvYmluZGluZ3MvdXNiL21lZGlhdGVrLG10dTMudHh0IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0 cmVlL2JpbmRpbmdzL3VzYi9tZWRpYXRlayxtdHUzLnR4dAo+ID4gaW5kZXggMzM4MmI1Y2I0NzFk Li42ZTAwNGM0YTg5YWYgMTAwNjQ0Cj4gPiAtLS0gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUv YmluZGluZ3MvdXNiL21lZGlhdGVrLG10dTMudHh0Cj4gPiArKysgYi9Eb2N1bWVudGF0aW9uL2Rl dmljZXRyZWUvYmluZGluZ3MvdXNiL21lZGlhdGVrLG10dTMudHh0Cj4gPiBAQCAtMjcsNyArMjcs OSBAQCBPcHRpb25hbCBwcm9wZXJ0aWVzOgo+ID4gICAtIHJhbmdlcyA6IGFsbG93cyB2YWxpZCAx OjEgdHJhbnNsYXRpb24gYmV0d2VlbiBjaGlsZCdzIGFkZHJlc3Mgc3BhY2UgYW5kCj4gPiAgCXBh cmVudCdzIGFkZHJlc3Mgc3BhY2UKPiA+ICAgLSBleHRjb24gOiBleHRlcm5hbCBjb25uZWN0b3Ig Zm9yIHZidXMgYW5kIGlkcGluIGNoYW5nZXMgZGV0ZWN0aW9uLCBuZWVkZWQKPiA+IC0Jd2hlbiBz dXBwb3J0cyBkdWFsLXJvbGUgbW9kZS4KPiA+ICsJd2hlbiBzdXBwb3J0cyBkdWFsLXJvbGUgbW9k ZTsgaXQncyBjb25zaWVkZXJlZCB2YWxpZCBmb3IgY29tcGF0aWJpbGl0eQo+ID4gKwlyZWFzb25z LCBhbmQgbm90IGFsbG93ZWQgZm9yIG5ldyBiaW5kaW5ncywgdXNlIHRoZSBwcm9wZXJ0eQo+ID4g Kwl1c2Itcm9sZS1zd2l0Y2ggaW5zdGVhZC4KPiA+ICAgLSB2YnVzLXN1cHBseSA6IHJlZmVyZW5j ZSB0byB0aGUgVkJVUyByZWd1bGF0b3IsIG5lZWRlZCB3aGVuIHN1cHBvcnRzCj4gPiAgCWR1YWwt cm9sZSBtb2RlLgo+ID4gICAtIHBpbmN0cmwtbmFtZXMgOiBhIHBpbmN0cmwgc3RhdGUgbmFtZWQg ImRlZmF1bHQiIGlzIG9wdGlvbmFsLCBhbmQgbmVlZCBiZQo+ID4gQEAgLTM2LDcgKzM4LDggQEAg T3B0aW9uYWwgcHJvcGVydGllczoKPiA+ICAJaXMgbm90IHNldC4KPiA+ICAgLSBwaW5jdHJsLTAg OiBwaW4gY29udHJvbCBncm91cAo+ID4gIAlTZWU6IERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9i aW5kaW5ncy9waW5jdHJsL3BpbmN0cmwtYmluZGluZ3MudHh0Cj4gPiAtCj4gPiArIC0gdXNiLXJv bGUtc3dpdGNoIDogdXNlIFVTQiBSb2xlIFN3aXRjaCB0byBzdXBwb3J0IGR1YWwtcm9sZSBzd2l0 Y2gsIGJ1dAo+ID4gKwlub3QgZXh0Y29uCj4gCj4gQ29vcmRpbmF0ZSB3aXRoIHRoZSBSZW5lc2Fz IGFuZCBIaVNpbGljb24gZm9sa3MgaW1wbGVtZW50aW5nIHRoZSBzYW1lIAo+IHRoaW5nIGFuZCBw dXQgdGhpcyBpbiBhIGNvbW1vbiBzcG90LiAKSSdsbCBwcmVwYXJlIGEgcGF0Y2ggZm9yIGl0LCBh bmQgQ0MgQmlqdSBhbmQgWXUKCj4gSG93ZXZlciwgSSB0aGluayB0aGlzIHNob3VsZCBub3QgCj4g ZXZlbiBiZSBuZWVkZWQgYXMga25vd2luZyB0aGUgY29udHJvbGxlciBjYXBhYmlsaXRpZXMgKGJh c2VkIG9uIHRoZSAKPiBjb21wYXRpYmxlKSBhbmQga25vd2luZyB0aGUgdHlwZSBvZiBjb25uZWN0 b3Igc2hvdWxkIGJlIGVub3VnaCAKPiBpbmZvcm1hdGlvbiB0byB0ZWxsIHlvdSBpZiBkdWFsIHJv bGUgaXMgc3VwcG9ydGVkIG9yIG5vdC4KU29tZSBEdWFsLVJvbGUgY29udHJvbGxlciBkcml2ZXJz IGFscmVhZHkgdXNlZCBleHRjb24gZnJhbWV3b3JrIHRvCmhhbmRsZSByb2xlIHN3aXRjaCwgaWYg dHJ5IHRvIHN1cHBvcnQgdGhlIG5ldyBVU0IgUm9sZSBTd2l0Y2ggZnJhbWV3b3JrLAp0aGUgZHJp dmVyIG1heSB3YW50IHRvIGtub3cgd2hpY2ggd2F5IHdpbGwgYmUgdXNlZC4KClNvbWV0aW1lcyB1 c2VycyBhbHNvIHdhbnQgdG8gdXNlIGR1YWwtcm9sZSBldmVuIHVzZSB0aGUgdHlwZS1BLCBzdWNo IGFzCnVzZSBzeXMgaW50ZXJmYWNlIHRvIGhhbmRsZSByb2xlIHN3aXRjaCwgc28gb25seSBrbm93 aW5nIHRoZSBjb25uZWN0b3IKdHlwZSBjYW4ndCB0ZWxsIGRyaXZlciB3aGljaCB3YXkgdG8gdXNl Cj4gCj4gPiAgIC0gbWF4aW11bS1zcGVlZCA6IHZhbGlkIGFyZ3VtZW50cyBhcmUgInN1cGVyLXNw ZWVkIiwgImhpZ2gtc3BlZWQiIGFuZAo+ID4gIAkiZnVsbC1zcGVlZCI7IHJlZmVyIHRvIHVzYi9n ZW5lcmljLnR4dAo+ID4gICAtIGVuYWJsZS1tYW51YWwtZHJkIDogc3VwcG9ydHMgbWFudWFsIGR1 YWwtcm9sZSBzd2l0Y2ggdmlhIGRlYnVnZnM7IHVzdWFsbHkKPiA+IEBAIC02MSw2ICs2NCw5IEBA IFRoZSB4aGNpIHNob3VsZCBiZSBhZGRlZCBhcyBzdWJub2RlIHRvIG10dTMgYXMgc2hvd24gaW4g dGhlIGZvbGxvd2luZyBleGFtcGxlCj4gPiAgaWYgaG9zdCBtb2RlIGlzIGVuYWJsZWQuIFRoZSBE VCBiaW5kaW5nIGRldGFpbHMgb2YgeGhjaSBjYW4gYmUgZm91bmQgaW46Cj4gPiAgRG9jdW1lbnRh dGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3VzYi9tZWRpYXRlayxtdGsteGhjaS50eHQKPiA+ICAK PiA+ICtUaGUgcG9ydCB3b3VsZCBiZSBhZGRlZCBhcyBzdWJub2RlIGlmIHVzZSB1c2Itcm9sZS1z d2l0Y2ggcHJvcGVydHkKPiA+ICsJc2VlIGdyYXBoLnR4dAo+ID4gKwo+ID4gIEV4YW1wbGU6Cj4g PiAgc3N1c2I6IHVzYkAxMTI3MTAwMCB7Cj4gPiAgCWNvbXBhdGlibGUgPSAibWVkaWF0ZWssbXQ4 MTczLW10dTMiOwo+ID4gLS0gCj4gPiAyLjIxLjAKPiA+Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 340C7C43218 for ; Sun, 28 Apr 2019 12:16:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 053092075D for ; Sun, 28 Apr 2019 12:16:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="k0+qgg+m" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 053092075D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pCkelv9gmFeYMyWZA4yAqlP4me5ng8hCsP1T7VXxb7A=; b=k0+qgg+mKyvq6e VC5QgK46Ni2dPJ4tFQpslhIlcAeNtVNwRbskpj/YQnqnWZq0O+JX54ffRL4TKmB2YjHSEOuHDl/Bf pMY10ZJEayZ71gTQubZvpNmgw9y5fT/6/O2YoaywkrWp0NPKMyGp6CnqZ+HW4e9jsrRwZHgMS2sP2 LWlDCdZfb1S/fs6pZ9KSKCRXGdqiO3xzmJ/rC11GUm+rf/xipUzcuIvuz0iOEK5/1lmfDN7g6aa7n E+slcTW13VqY0vyRb5GL1MDzV4radsu/zh9HQ3VpZAca/NldI59zFQVaG7cQoUIgXYZ9iIo0kMxY+ Zo8suRuVtJA4bY/HQvAA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hKijc-0007lu-4z; Sun, 28 Apr 2019 12:16:44 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hKijY-0007lK-8p; Sun, 28 Apr 2019 12:16:42 +0000 X-UUID: 1365c26b1f17430cbfdf6a906d9253da-20190428 X-UUID: 1365c26b1f17430cbfdf6a906d9253da-20190428 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 13568862; Sun, 28 Apr 2019 04:16:33 -0800 Received: from MTKMBS31DR.mediatek.inc (172.27.6.102) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sun, 28 Apr 2019 05:16:32 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31DR.mediatek.inc (172.27.6.102) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sun, 28 Apr 2019 20:16:29 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Sun, 28 Apr 2019 20:16:28 +0800 Message-ID: <1556453788.10179.224.camel@mhfsdcap03> Subject: Re: [PATCH v4 3/6] dt-bindings: usb: mtu3: add properties about USB Role Switch From: Chunfeng Yun To: Rob Herring Date: Sun, 28 Apr 2019 20:16:28 +0800 In-Reply-To: <20190426204906.GB15074@bogus> References: <1556261237-13823-1-git-send-email-chunfeng.yun@mediatek.com> <1556261237-13823-4-git-send-email-chunfeng.yun@mediatek.com> <20190426204906.GB15074@bogus> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190428_051640_321406_015B8067 X-CRM114-Status: GOOD ( 24.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Heikki Krogerus , Hans de Goede , Greg Kroah-Hartman , Linus Walleij , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Biju Das , Badhri Jagan Sridharan , Andy Shevchenko , linux-mediatek@lists.infradead.org, Min Guo , Matthias Brugger , Adam Thomson , linux-arm-kernel@lists.infradead.org, Li Jun Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2019-04-26 at 15:49 -0500, Rob Herring wrote: > On Fri, Apr 26, 2019 at 02:47:14PM +0800, Chunfeng Yun wrote: > > Now the USB Role Switch is supported, so add properties about it > > > > Signed-off-by: Chunfeng Yun > > --- > > v4: no changes > > v3: no changes > > > > v2 changes: > > 1. fix typo > > 2. refer new binding about connector property > > --- > > .../devicetree/bindings/usb/mediatek,mtu3.txt | 10 ++++++++-- > > 1 file changed, 8 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt > > index 3382b5cb471d..6e004c4a89af 100644 > > --- a/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt > > +++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt > > @@ -27,7 +27,9 @@ Optional properties: > > - ranges : allows valid 1:1 translation between child's address space and > > parent's address space > > - extcon : external connector for vbus and idpin changes detection, needed > > - when supports dual-role mode. > > + when supports dual-role mode; it's consiedered valid for compatibility > > + reasons, and not allowed for new bindings, use the property > > + usb-role-switch instead. > > - vbus-supply : reference to the VBUS regulator, needed when supports > > dual-role mode. > > - pinctrl-names : a pinctrl state named "default" is optional, and need be > > @@ -36,7 +38,8 @@ Optional properties: > > is not set. > > - pinctrl-0 : pin control group > > See: Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt > > - > > + - usb-role-switch : use USB Role Switch to support dual-role switch, but > > + not extcon > > Coordinate with the Renesas and HiSilicon folks implementing the same > thing and put this in a common spot. I'll prepare a patch for it, and CC Biju and Yu > However, I think this should not > even be needed as knowing the controller capabilities (based on the > compatible) and knowing the type of connector should be enough > information to tell you if dual role is supported or not. Some Dual-Role controller drivers already used extcon framework to handle role switch, if try to support the new USB Role Switch framework, the driver may want to know which way will be used. Sometimes users also want to use dual-role even use the type-A, such as use sys interface to handle role switch, so only knowing the connector type can't tell driver which way to use > > > - maximum-speed : valid arguments are "super-speed", "high-speed" and > > "full-speed"; refer to usb/generic.txt > > - enable-manual-drd : supports manual dual-role switch via debugfs; usually > > @@ -61,6 +64,9 @@ The xhci should be added as subnode to mtu3 as shown in the following example > > if host mode is enabled. The DT binding details of xhci can be found in: > > Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt > > > > +The port would be added as subnode if use usb-role-switch property > > + see graph.txt > > + > > Example: > > ssusb: usb@11271000 { > > compatible = "mediatek,mt8173-mtu3"; > > -- > > 2.21.0 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel