From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jernej =?utf-8?B?xaBrcmFiZWM=?= Date: Wed, 02 May 2018 16:54:53 +0200 Subject: [U-Boot] [PATCH 0/2] video: dw_hdmi: fix HSYNC and VSYNC polarity settings In-Reply-To: References: <20180428215729.22048-1-anarsoul@gmail.com> <20180502130100.33afa49d@crub> Message-ID: <15565065.baLXvQDMhD@jernej-laptop> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, Dne sreda, 02. maj 2018 ob 16:47:07 CEST je Vasily Khoruzhick napisal(a): > On Wed, May 2, 2018 at 4:01 AM, Anatolij Gustschin wrote: > > Hi, > > > > On Sat, 28 Apr 2018 14:57:27 -0700 > > > > Vasily Khoruzhick anarsoul at gmail.com wrote: > >> Previous attempt to fix HSYNC and VSYNC polarity settings for dw_hdmi > >> was wrong - actual root cause wasn't in sunxi dw_hdmi glue code, but in > >> dw_hdmi driver itself. This series reverts previous attempt to fix the > >> issue and applies proper fix > >> > >> Vasily Khoruzhick (2): > >> Revert "sunxi: video: HDMI: split VSYNC and HSYNC polarity settings" > > > > is this revert needed? Shouldn't the flags be set separately like this > > commit does? > > Yes, revert is needed. Driver works fine without setting flags separately. I think patch is still needed. Code should be done in this way: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/? id=e420ccd66d36e4ac2035620286495ce13a40b7f7 Without this, different polarities didn't work for me in Linux DRM driver. Best regards, Jernej