From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eddie Huang Subject: Re: [PATCH v2 2/2] clk: reset: Modify reset-controller driver Date: Mon, 29 Apr 2019 14:35:51 +0800 Message-ID: <1556519751.15195.5.camel@mtksdaap41> References: <1556262618-14281-1-git-send-email-yong.liang@mediatek.com> <1556262618-14281-2-git-send-email-yong.liang@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1556262618-14281-2-git-send-email-yong.liang@mediatek.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Yong Liang Cc: "mark.rutland@arm.com" , JamesJJ Liao =?UTF-8?Q?=28=E5=BB=96=E5=BB=BA=E6=99=BA=29?= , "drinkcat@chromium.org" , Weiyi Lu =?UTF-8?Q?=28=E5=91=82=E5=A8=81=E5=84=80=29?= , "chunhui.dai@mediatek.com" , "sboyd@kernel.org" , "mturquette@baylibre.com" , "robh+dt@kernel.org" , "jasu@njomotys.info" , "matthias.bgg@gmail.com" , "linux-mediatek@lists.infradead.org" , Owen Chen =?UTF-8?Q?=28=E9=99=B3=E5=B3=BB=E6=96=8C=29?= , Erin Lo =?UTF-8?Q?=28=E7=BE=85=E9=9B=85=E9=BD=A1=29?= , "linux-arm-kernel@lists.infradead.org" List-Id: linux-mediatek@lists.infradead.org Hi Yong, Please add reset controller maintainer in this mailing loop Philipp Zabel On Fri, 2019-04-26 at 15:10 +0800, Yong Liang wrote: > From: "yong.liang" > > Set reset signal by a register and clear reset signal by > another register for 8183. You should move your signed-off-by here, then add --- in next line to avoid your notes appear in commit message when use git am to apply this patch > Base on https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git branch clk-next and https://patchwork.kernel.org/patch/10856987/ > > Changes in patch v2: > Rollback modify for "_tuner_en_bit, _pcw_reg, _pcw_shift," > in drivers/clk/mediatek/clk-mt8183.c > > Signed-off-by: yong.liang > --- > drivers/clk/mediatek/clk-mt8183.c | 10 ++- > drivers/clk/mediatek/clk-mtk.h | 3 + > drivers/clk/mediatek/reset.c | 53 +++++++++++- > .../dt-bindings/reset-controller/mt8183-resets.h | 89 ++++++++++++++++++++ > 4 files changed, 151 insertions(+), 4 deletions(-) > create mode 100644 include/dt-bindings/reset-controller/mt8183-resets.h > > diff --git a/drivers/clk/mediatek/clk-mt8183.c b/drivers/clk/mediatek/clk-mt8183.c > index 9d86510..cda5b91 100644 > --- a/drivers/clk/mediatek/clk-mt8183.c > +++ b/drivers/clk/mediatek/clk-mt8183.c > @@ -1156,6 +1156,7 @@ static int clk_mt8183_apmixed_probe(struct platform_device *pdev) > { > struct clk_onecell_data *clk_data; > struct device_node *node = pdev->dev.of_node; > + int r; > > clk_data = mtk_alloc_clk_data(CLK_APMIXED_NR_CLK); > > @@ -1164,7 +1165,14 @@ static int clk_mt8183_apmixed_probe(struct platform_device *pdev) > mtk_clk_register_gates(node, apmixed_clks, ARRAY_SIZE(apmixed_clks), > clk_data); > > - return of_clk_add_provider(node, of_clk_src_onecell_get, clk_data); > + r = of_clk_add_provider(node, of_clk_src_onecell_get, clk_data); > + if (r) > + dev_err(&pdev->dev, > + "%s(): could not register clock provider: %d\n",__func__, r); > + > + mtk_register_reset_controller_set_clr(node, 4, 0x120); > + > + return r; > } You should call mtk_register_reset_controller_set_clr function in clk_mt8183_infra_probe Eddie From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3107FC43219 for ; Mon, 29 Apr 2019 06:36:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0029D2087B for ; Mon, 29 Apr 2019 06:36:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="t0UZUhYm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0029D2087B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=os73UtLpcdJyskmflmQKMTka7zjdl8cXk6jhDzXE9ZU=; b=t0UZUhYmj3horX GOpzTuBsppbB8GZtaLCeW3mUfEc0UEHDbUnzw57FgrOoPfxqTBEQUSQs7+fvNL4enZEUObLk6VwEP l+FpP8aOOlKjXrSMp5YQvi+r4IUfx7uKv3eMgbQCT8BKYQv/G08YmbJKgXACa32pMOQ0t9u+U1ofr KKX7mYFCcvwOwNj6K5nuNf6kOHEssuIurVYPDJ+YtoNJwBqJvPYWwqtVr4xPLG8Lsvv36k8/xLHhh SVcYtb2p/vJLBD47qMGj6qmkTU6ZcVrUlzlmPvBopvlOSg0ngWvhNj2A+be7rnikxb0mkHrt+Ky+e vXv18xsRF1r4F3/Q5T4A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hKzu7-00058p-Pt; Mon, 29 Apr 2019 06:36:43 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hKzu4-00057S-BA; Mon, 29 Apr 2019 06:36:41 +0000 X-UUID: 33a79edcf875460594ecf9746ce6e65b-20190428 X-UUID: 33a79edcf875460594ecf9746ce6e65b-20190428 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1725050422; Sun, 28 Apr 2019 22:35:54 -0800 Received: from MTKMBS02N1.mediatek.inc (172.21.101.77) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sun, 28 Apr 2019 23:35:53 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs02n1.mediatek.inc (172.21.101.77) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 29 Apr 2019 14:35:51 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Mon, 29 Apr 2019 14:35:51 +0800 Message-ID: <1556519751.15195.5.camel@mtksdaap41> Subject: Re: [PATCH v2 2/2] clk: reset: Modify reset-controller driver From: Eddie Huang To: Yong Liang Date: Mon, 29 Apr 2019 14:35:51 +0800 In-Reply-To: <1556262618-14281-2-git-send-email-yong.liang@mediatek.com> References: <1556262618-14281-1-git-send-email-yong.liang@mediatek.com> <1556262618-14281-2-git-send-email-yong.liang@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190428_233640_381175_72E3B7F7 X-CRM114-Status: GOOD ( 16.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , JamesJJ Liao =?UTF-8?Q?=28=E5=BB=96=E5=BB=BA=E6=99=BA=29?= , "drinkcat@chromium.org" , Weiyi Lu =?UTF-8?Q?=28=E5=91=82=E5=A8=81=E5=84=80=29?= , "chunhui.dai@mediatek.com" , "sboyd@kernel.org" , "mturquette@baylibre.com" , "robh+dt@kernel.org" , "jasu@njomotys.info" , "matthias.bgg@gmail.com" , "linux-mediatek@lists.infradead.org" , Owen Chen =?UTF-8?Q?=28=E9=99=B3=E5=B3=BB=E6=96=8C=29?= , Erin Lo =?UTF-8?Q?=28=E7=BE=85=E9=9B=85=E9=BD=A1=29?= , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Yong, Please add reset controller maintainer in this mailing loop Philipp Zabel On Fri, 2019-04-26 at 15:10 +0800, Yong Liang wrote: > From: "yong.liang" > > Set reset signal by a register and clear reset signal by > another register for 8183. You should move your signed-off-by here, then add --- in next line to avoid your notes appear in commit message when use git am to apply this patch > Base on https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git branch clk-next and https://patchwork.kernel.org/patch/10856987/ > > Changes in patch v2: > Rollback modify for "_tuner_en_bit, _pcw_reg, _pcw_shift," > in drivers/clk/mediatek/clk-mt8183.c > > Signed-off-by: yong.liang > --- > drivers/clk/mediatek/clk-mt8183.c | 10 ++- > drivers/clk/mediatek/clk-mtk.h | 3 + > drivers/clk/mediatek/reset.c | 53 +++++++++++- > .../dt-bindings/reset-controller/mt8183-resets.h | 89 ++++++++++++++++++++ > 4 files changed, 151 insertions(+), 4 deletions(-) > create mode 100644 include/dt-bindings/reset-controller/mt8183-resets.h > > diff --git a/drivers/clk/mediatek/clk-mt8183.c b/drivers/clk/mediatek/clk-mt8183.c > index 9d86510..cda5b91 100644 > --- a/drivers/clk/mediatek/clk-mt8183.c > +++ b/drivers/clk/mediatek/clk-mt8183.c > @@ -1156,6 +1156,7 @@ static int clk_mt8183_apmixed_probe(struct platform_device *pdev) > { > struct clk_onecell_data *clk_data; > struct device_node *node = pdev->dev.of_node; > + int r; > > clk_data = mtk_alloc_clk_data(CLK_APMIXED_NR_CLK); > > @@ -1164,7 +1165,14 @@ static int clk_mt8183_apmixed_probe(struct platform_device *pdev) > mtk_clk_register_gates(node, apmixed_clks, ARRAY_SIZE(apmixed_clks), > clk_data); > > - return of_clk_add_provider(node, of_clk_src_onecell_get, clk_data); > + r = of_clk_add_provider(node, of_clk_src_onecell_get, clk_data); > + if (r) > + dev_err(&pdev->dev, > + "%s(): could not register clock provider: %d\n",__func__, r); > + > + mtk_register_reset_controller_set_clr(node, 4, 0x120); > + > + return r; > } You should call mtk_register_reset_controller_set_clr function in clk_mt8183_infra_probe Eddie _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel