From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stanley Chu Subject: Re: [PATCH v1 0/3] scsi: ufs: add error handlings of auto-hibern8 Date: Tue, 14 May 2019 14:25:01 +0800 Message-ID: <1557815101.24427.7.camel@mtkswgap22> References: <1557758186-18706-1-git-send-email-stanley.chu@mediatek.com> <55818bc4-d464-bb35-25bb-9ef87af8224e@free.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <55818bc4-d464-bb35-25bb-9ef87af8224e@free.fr> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Marc Gonzalez Cc: linux-scsi@vger.kernel.org, martin.petersen@oracle.com, vivek.gautam@codeaurora.org, andy.teng@mediatek.com, chun-hung.wu@mediatek.com, kuohong.wang@mediatek.com, subhashj@codeaurora.org, evgreen@chromium.org, avri.altman@wdc.com, linux-mediatek@lists.infradead.org, peter.wang@mediatek.com, alim.akhtar@samsung.com, matthias.bgg@gmail.com, sayalil@codeaurora.org, pedrom.sousa@synopsys.com, linux-arm-kernel@lists.infradead.org, beanhuo@micron.com List-Id: linux-scsi@vger.kernel.org Hi Marc, Thank you so much for below suggestions. I will fix them all in next version. On Mon, 2019-05-13 at 16:51 +0200, Marc Gonzalez wrote: > On 13/05/2019 16:36, Stanley Chu wrote: > > > Currently auto-hibern8 is activated if host supports > > auto-hibern8 capability. However no error handlings are existed thus > > this feature is kind of risky. > > This last sentence is not very idiomatic. > > I would suggest: > "However, error-handling is not implemented, which makes the feature > somewhat risky." > > > If "Hibernate Enter" or "Hibernate Exit" fail happens > > I would suggest: > If either "Hibernate Enter" or "Hibernate Exit" fail during ... > > > during auto-hibern8 flow, the corresponding interrupt > > "UIC_HIBERNATE_ENTER" or "UIC_HIBERNATE_EXIT" shall be raised > > according to UFS specification. > > > > This patch adds auto-hibern8 error handlings: > > error-handling > > > - Monitor "Hibernate Enter" and "Hibernate Exit" interrupts after > > auto-hibern8 feature is activated. > > I just want to take this opportunity to ask a rhetorical question. > > Who in the Great Heavens thought it would be a good idea to call the > feature "auto-hibern8" ? > > Was it really worth it to save 2 characters by writing "8" instead > of "ate" ? > > This bugs me so much that I just might send a patch to fix it up. As far as I know, the term "HIBERN8" is mentioned in all UFS related specifications, like UFS, UFSHCI, UniPro and M-PHY. So probably this abbreviation has existed for a long time. > > Regards. Thanks, Stanley From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5A0FC04AB4 for ; Tue, 14 May 2019 06:25:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BB6BB208CA for ; Tue, 14 May 2019 06:25:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QODlzhFH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB6BB208CA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/OhAI57Lmfy9N4FvzYMoO007SyIAdK8Zf5q7Hp8w/iM=; b=QODlzhFHzbpY0D DmP5sT3ahHhWRb8uY6QAKFQMZ+7fPZ5JeWpIEajvJKP2EgGhsLSAX7H4yhn7AwbyMQsiRKItEbdZ4 kv4Xf82MNp4x3UBJJ2jcNo0AFBZ8iA5DF8X5/Z/L1Hx/QzmfUY5fqq/BrcEi6VQsew3qj/xG4LQoG c9eFlDW3o3Zvug6IEqC8yH8UcOyvP9nBGj/ASMKK0B65J/JA9t9ZtkpxW570S7ZJ8ao1v4E0Tlv7f xwOb4wleEusslYpJHDNXBmNoUVz6OoJUwgDvGZ1SVt/cYRB4Fgj8SxT0cLNp1y1p62FM9ZMmowa5u 3Bx3yt/PzdHP4dnbu6/g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hQQsK-0007hO-DE; Tue, 14 May 2019 06:25:20 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hQQsH-0007gg-Pl; Tue, 14 May 2019 06:25:19 +0000 X-UUID: b2743fa7f40c4a73bc47338777f79f1b-20190513 X-UUID: b2743fa7f40c4a73bc47338777f79f1b-20190513 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1248924353; Mon, 13 May 2019 22:25:04 -0800 Received: from mtkmbs03n1.mediatek.inc (172.21.101.181) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 13 May 2019 23:25:03 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs03n1.mediatek.inc (172.21.101.181) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 14 May 2019 14:25:01 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 14 May 2019 14:25:01 +0800 Message-ID: <1557815101.24427.7.camel@mtkswgap22> Subject: Re: [PATCH v1 0/3] scsi: ufs: add error handlings of auto-hibern8 From: Stanley Chu To: Marc Gonzalez Date: Tue, 14 May 2019 14:25:01 +0800 In-Reply-To: <55818bc4-d464-bb35-25bb-9ef87af8224e@free.fr> References: <1557758186-18706-1-git-send-email-stanley.chu@mediatek.com> <55818bc4-d464-bb35-25bb-9ef87af8224e@free.fr> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190513_232517_841092_95DEC378 X-CRM114-Status: GOOD ( 16.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-scsi@vger.kernel.org, martin.petersen@oracle.com, vivek.gautam@codeaurora.org, andy.teng@mediatek.com, chun-hung.wu@mediatek.com, kuohong.wang@mediatek.com, subhashj@codeaurora.org, evgreen@chromium.org, avri.altman@wdc.com, linux-mediatek@lists.infradead.org, peter.wang@mediatek.com, alim.akhtar@samsung.com, matthias.bgg@gmail.com, sayalil@codeaurora.org, pedrom.sousa@synopsys.com, linux-arm-kernel@lists.infradead.org, beanhuo@micron.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marc, Thank you so much for below suggestions. I will fix them all in next version. On Mon, 2019-05-13 at 16:51 +0200, Marc Gonzalez wrote: > On 13/05/2019 16:36, Stanley Chu wrote: > > > Currently auto-hibern8 is activated if host supports > > auto-hibern8 capability. However no error handlings are existed thus > > this feature is kind of risky. > > This last sentence is not very idiomatic. > > I would suggest: > "However, error-handling is not implemented, which makes the feature > somewhat risky." > > > If "Hibernate Enter" or "Hibernate Exit" fail happens > > I would suggest: > If either "Hibernate Enter" or "Hibernate Exit" fail during ... > > > during auto-hibern8 flow, the corresponding interrupt > > "UIC_HIBERNATE_ENTER" or "UIC_HIBERNATE_EXIT" shall be raised > > according to UFS specification. > > > > This patch adds auto-hibern8 error handlings: > > error-handling > > > - Monitor "Hibernate Enter" and "Hibernate Exit" interrupts after > > auto-hibern8 feature is activated. > > I just want to take this opportunity to ask a rhetorical question. > > Who in the Great Heavens thought it would be a good idea to call the > feature "auto-hibern8" ? > > Was it really worth it to save 2 characters by writing "8" instead > of "ate" ? > > This bugs me so much that I just might send a patch to fix it up. As far as I know, the term "HIBERN8" is mentioned in all UFS related specifications, like UFS, UFSHCI, UniPro and M-PHY. So probably this abbreviation has existed for a long time. > > Regards. Thanks, Stanley _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel