All of lore.kernel.org
 help / color / mirror / Atom feed
From: Swati Sharma <swati2.sharma@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com
Subject: [v6][PATCH 01/12] drm/i915: Introduce vfunc read_luts() to create hw lut
Date: Tue, 14 May 2019 15:13:19 +0530	[thread overview]
Message-ID: <1557827010-24239-2-git-send-email-swati2.sharma@intel.com> (raw)
In-Reply-To: <1557827010-24239-1-git-send-email-swati2.sharma@intel.com>

In this patch, a vfunc read_luts() is introduced to create a hw lut
i.e. lut having values read from gamma/degamma registers which will
later be used to compare with sw lut to validate gamma/degamma lut values.

v3: -Rebase
v4: -Renamed intel_get_color_config to intel_color_get_config [Jani]
    -Wrapped get_color_config() [Jani]
v5: -Renamed intel_color_get_config() to intel_color_read_luts()
    -Renamed get_color_config to read_luts
v6: -Renamed intel_color_read_luts() back to intel_color_get_config()
     [Jani and Ville]

Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
 drivers/gpu/drm/i915/i915_drv.h    | 1 +
 drivers/gpu/drm/i915/intel_color.c | 8 ++++++++
 drivers/gpu/drm/i915/intel_color.h | 1 +
 3 files changed, 10 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index d025780..6343e70 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -343,6 +343,7 @@ struct drm_i915_display_funcs {
 	 * involved with the same commit.
 	 */
 	void (*load_luts)(const struct intel_crtc_state *crtc_state);
+	void (*read_luts)(struct intel_crtc_state *crtc_state);
 };
 
 struct intel_csr {
diff --git a/drivers/gpu/drm/i915/intel_color.c b/drivers/gpu/drm/i915/intel_color.c
index 962db12..50b98ee 100644
--- a/drivers/gpu/drm/i915/intel_color.c
+++ b/drivers/gpu/drm/i915/intel_color.c
@@ -879,6 +879,14 @@ int intel_color_check(struct intel_crtc_state *crtc_state)
 	return dev_priv->display.color_check(crtc_state);
 }
 
+void intel_color_get_config(struct intel_crtc_state *crtc_state)
+{
+	struct drm_i915_private *dev_priv = to_i915(crtc_state->base.crtc->dev);
+
+	if (dev_priv->display.read_luts)
+		dev_priv->display.read_luts(crtc_state);
+}
+
 static bool need_plane_update(struct intel_plane *plane,
 			      const struct intel_crtc_state *crtc_state)
 {
diff --git a/drivers/gpu/drm/i915/intel_color.h b/drivers/gpu/drm/i915/intel_color.h
index b8a3ce6..057e8ac 100644
--- a/drivers/gpu/drm/i915/intel_color.h
+++ b/drivers/gpu/drm/i915/intel_color.h
@@ -13,5 +13,6 @@
 int intel_color_check(struct intel_crtc_state *crtc_state);
 void intel_color_commit(const struct intel_crtc_state *crtc_state);
 void intel_color_load_luts(const struct intel_crtc_state *crtc_state);
+void intel_color_get_config(struct intel_crtc_state *crtc_state);
 
 #endif /* __INTEL_COLOR_H__ */
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-05-14  9:47 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-14  9:43 [PATCH 00/12] drm/i915: adding state checker for gamma lut values Swati Sharma
2019-05-14  9:43 ` Swati Sharma [this message]
2019-05-14 15:23   ` [v6][PATCH 01/12] drm/i915: Introduce vfunc read_luts() to create hw lut Ville Syrjälä
2019-05-15  7:45     ` Jani Nikula
2019-05-14  9:43 ` [v6][PATCH 02/12] drm/i915: Enable intel_color_get_config() Swati Sharma
2019-05-14  9:43 ` [v6][PATCH 03/12] drm/i915: Add intel_color_lut_equal() to compare hw and sw gamma/degamma lut values Swati Sharma
2019-05-14 16:10   ` Ville Syrjälä
2019-05-21 13:42     ` Sharma, Swati2
2019-05-24 15:25       ` Ville Syrjälä
2019-05-14  9:43 ` [v6][PATCH 04/12] drm/i915: Extract i9xx_read_luts() Swati Sharma
2019-05-14  9:43 ` [v6][PATCH 05/12] drm/i915: Extract chv_read_luts() Swati Sharma
2019-05-14  9:43 ` [v6][PATCH 06/12] drm/i915: Extract i965_read_luts() Swati Sharma
2019-05-14  9:43 ` [v6][PATCH 07/12] drm/i915: Extract icl_read_luts() Swati Sharma
2019-05-14  9:43 ` [v6][PATCH 08/12] drm/i915: Extract glk_read_luts() Swati Sharma
2019-05-14  9:43 ` [v6][PATCH 09/12] drm/i915: Extract bdw_read_luts() Swati Sharma
2019-05-14  9:43 ` [v6][PATCH 10/12] drm/i915: Extract ivb_read_luts() Swati Sharma
2019-05-14  9:43 ` [v6][PATCH 11/12] drm/i915: Extract ilk_read_luts() Swati Sharma
2019-05-14  9:43 ` [v6][PATCH 12/12] FOR_TESTING_ONLY: Print rgb values of hw and sw blobs Swati Sharma
2019-05-14 10:36 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: adding state checker for gamma lut values (rev8) Patchwork
2019-05-14 10:42 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-05-14 10:58 ` ✓ Fi.CI.BAT: success " Patchwork
2019-05-14 14:17 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-05-14 14:27 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: adding state checker for gamma lut values (rev9) Patchwork
2019-05-14 14:33 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-05-14 15:17 ` ✓ Fi.CI.BAT: success " Patchwork
2019-05-14 22:14 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1557827010-24239-2-git-send-email-swati2.sharma@intel.com \
    --to=swati2.sharma@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.