All of lore.kernel.org
 help / color / mirror / Atom feed
From: Uma Shankar <uma.shankar@intel.com>
To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: dcastagna@chromium.org, jonas@kwiboo.se, seanpaul@chromium.org
Subject: [v11 09/12] drm/i915:Enabled Modeset when HDR Infoframe changes
Date: Thu, 16 May 2019 19:40:14 +0530	[thread overview]
Message-ID: <1558015817-12025-10-git-send-email-uma.shankar@intel.com> (raw)
In-Reply-To: <1558015817-12025-1-git-send-email-uma.shankar@intel.com>

This patch enables modeset whenever HDR metadata
needs to be updated to sink.

v2: Addressed Shashank's review comments.

v3: Added Shashank's RB.

v4: Addressed Ville's review comments.

v5: Addressed Ville's review comments.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Uma Shankar <uma.shankar@intel.com>
Reviewed-by: Shashank Sharma <shashank.sharma@intel.com>
---
 drivers/gpu/drm/i915/intel_atomic.c | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_atomic.c b/drivers/gpu/drm/i915/intel_atomic.c
index 58b8049..6b985e8 100644
--- a/drivers/gpu/drm/i915/intel_atomic.c
+++ b/drivers/gpu/drm/i915/intel_atomic.c
@@ -105,6 +105,16 @@ int intel_digital_connector_atomic_set_property(struct drm_connector *connector,
 	return -EINVAL;
 }
 
+static bool blob_equal(const struct drm_property_blob *a,
+		       const struct drm_property_blob *b)
+{
+	if (a && b)
+		return a->length == b->length &&
+			!memcmp(a->data, b->data, a->length);
+
+	return !a == !b;
+}
+
 int intel_digital_connector_atomic_check(struct drm_connector *conn,
 					 struct drm_connector_state *new_state)
 {
@@ -132,7 +142,9 @@ int intel_digital_connector_atomic_check(struct drm_connector *conn,
 	    new_conn_state->base.colorspace != old_conn_state->base.colorspace ||
 	    new_conn_state->base.picture_aspect_ratio != old_conn_state->base.picture_aspect_ratio ||
 	    new_conn_state->base.content_type != old_conn_state->base.content_type ||
-	    new_conn_state->base.scaling_mode != old_conn_state->base.scaling_mode)
+	    new_conn_state->base.scaling_mode != old_conn_state->base.scaling_mode ||
+	    !blob_equal(new_conn_state->base.hdr_output_metadata,
+			old_conn_state->base.hdr_output_metadata))
 		crtc_state->mode_changed = true;
 
 	return 0;
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-05-16 14:10 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-16 14:10 [v11 00/12] Add HDR Metadata Parsing and handling in DRM layer Uma Shankar
2019-05-16 14:10 ` [v11 01/12] drm: Add HDR source metadata property Uma Shankar
2019-05-16 14:10 ` [v11 02/12] drm: Add reference counting on HDR metadata blob Uma Shankar
2019-05-16 14:10 ` [v11 03/12] drm: Parse HDR metadata info from EDID Uma Shankar
2019-05-16 14:10 ` [v11 04/12] drm: Enable HDR infoframe support Uma Shankar
2019-05-16 14:10 ` [v11 05/12] drm/i915: Attach HDR metadata property to connector Uma Shankar
2019-05-17 14:06   ` Ville Syrjälä
2019-05-17 16:19     ` [v12 " Uma Shankar
2019-05-16 14:10 ` [v11 06/12] drm/i915: Write HDR infoframe and send to panel Uma Shankar
2019-05-17 14:06   ` Ville Syrjälä
2019-05-17 16:20     ` [v12 " Uma Shankar
2019-05-18 10:39       ` [v13 " Uma Shankar
2019-05-16 14:10 ` [v11 07/12] drm: Add HLG EOTF Uma Shankar
2019-05-16 14:10 ` [v11 08/12] drm/i915: Enable infoframes on GLK+ for HDR Uma Shankar
2019-05-17 14:01   ` Ville Syrjälä
2019-05-17 16:22     ` [v12 " Uma Shankar
2019-05-16 14:10 ` Uma Shankar [this message]
2019-05-16 14:10 ` [v11 10/12] drm/i915: Added DRM Infoframe handling for BYT/CHT Uma Shankar
2019-05-16 14:10 ` [v11 11/12] video/hdmi: Add Unpack function for DRM infoframe Uma Shankar
2019-05-16 14:10 ` [v11 12/12] drm/i915: Add state readout " Uma Shankar
2019-05-16 14:12 ` ✗ Fi.CI.CHECKPATCH: warning for Add HDR Metadata Parsing and handling in DRM layer (rev11) Patchwork
2019-05-16 14:37 ` ✓ Fi.CI.BAT: success " Patchwork
2019-05-16 19:35 ` ✓ Fi.CI.IGT: " Patchwork
2019-05-17 16:07 ` ✗ Fi.CI.CHECKPATCH: warning for Add HDR Metadata Parsing and handling in DRM layer (rev14) Patchwork
2019-05-17 16:34 ` ✓ Fi.CI.BAT: success " Patchwork
2019-05-18  3:18 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-05-18 10:27 ` ✗ Fi.CI.CHECKPATCH: warning for Add HDR Metadata Parsing and handling in DRM layer (rev15) Patchwork
2019-05-18 10:47 ` ✓ Fi.CI.BAT: success " Patchwork
2019-05-18 15:47 ` ✓ Fi.CI.IGT: " Patchwork
2019-05-22 20:45 ` [v11 00/12] Add HDR Metadata Parsing and handling in DRM layer Ville Syrjälä
2019-05-23  8:09   ` Jani Nikula
2019-05-23  8:41     ` [Intel-gfx] " Daniel Vetter
2019-05-28 11:35   ` Maarten Lankhorst
2019-05-28 11:43     ` Shankar, Uma
2019-05-29  9:43 ` Daniel Vetter
2019-05-29 13:58   ` Shankar, Uma
2019-05-29 15:03     ` [Intel-gfx] " Daniel Vetter
2019-05-29 17:28       ` Shankar, Uma
2019-05-29 17:35         ` Daniel Vetter
2019-05-29 17:39           ` [Intel-gfx] " Shankar, Uma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1558015817-12025-10-git-send-email-uma.shankar@intel.com \
    --to=uma.shankar@intel.com \
    --cc=dcastagna@chromium.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jonas@kwiboo.se \
    --cc=seanpaul@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.