From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23044C04E87 for ; Tue, 21 May 2019 18:23:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 00EBA217D9 for ; Tue, 21 May 2019 18:23:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729273AbfEUSX6 convert rfc822-to-8bit (ORCPT ); Tue, 21 May 2019 14:23:58 -0400 Received: from mail.fireflyinternet.com ([109.228.58.192]:55916 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728457AbfEUSX5 (ORCPT ); Tue, 21 May 2019 14:23:57 -0400 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 16632229-1500050 for multiple; Tue, 21 May 2019 19:23:54 +0100 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT To: Rob Herring , Steven Price From: Chris Wilson In-Reply-To: Cc: Daniel Vetter , Tomeu Vizoso , Alyssa Rosenzweig , David Airlie , Inki Dae , Joonyoung Shim , Krzysztof Kozlowski , Kukjin Kim , Kyungmin Park , Maarten Lankhorst , Maxime Ripard , Sean Paul , Seung-Woo Kim , dri-devel , "linux-kernel@vger.kernel.org" References: <20190520092306.27633-1-steven.price@arm.com> <20190520092306.27633-3-steven.price@arm.com> Message-ID: <155846303227.23981.8007374203089408422@skylake-alporthouse-com> User-Agent: alot/0.6 Subject: Re: [PATCH v3 2/2] drm/panfrost: Use drm_gem_shmem_map_offset() Date: Tue, 21 May 2019 19:23:52 +0100 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Rob Herring (2019-05-21 16:24:27) > On Mon, May 20, 2019 at 4:23 AM Steven Price wrote: > > > > You forgot to update the subject. I can fixup when applying, but I'd > like an ack from Chris on patch 1. I still think it is incorrect as the limitation is purely an issue with the shmem backend and not a generic GEM limitation. It matters if you have a history of passing names and want a consistent api across objects when the apps themselves no longer can tell the difference, and certainly do not have access to the dmabuf fd. i915 provides an indirect mmap interface that uses the dma mapping regardless of source. -Chris