All of lore.kernel.org
 help / color / mirror / Atom feed
From: no-reply@patchew.org
To: wens@kernel.org
Cc: riku.voipio@iki.fi, qemu-devel@nongnu.org, wens@kernel.org,
	laurent@vivier.eu
Subject: Re: [Qemu-devel] [PATCH v3] linux-user: Pass through nanosecond timestamp components for stat syscalls
Date: Wed, 22 May 2019 10:15:13 -0700 (PDT)	[thread overview]
Message-ID: <155854531263.24.8817707922240677584@549697c9ad12> (raw)
In-Reply-To: <20190522162147.26303-1-wens@kernel.org>

Patchew URL: https://patchew.org/QEMU/20190522162147.26303-1-wens@kernel.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190522162147.26303-1-wens@kernel.org
Type: series
Subject: [Qemu-devel] [PATCH v3] linux-user: Pass through nanosecond timestamp components for stat syscalls

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]               patchew/20190522162147.26303-1-wens@kernel.org -> patchew/20190522162147.26303-1-wens@kernel.org
Switched to a new branch 'test'
6ec325f89c linux-user: Pass through nanosecond timestamp components for stat syscalls

=== OUTPUT BEGIN ===
ERROR: code indent should never use tabs
#104: FILE: linux-user/syscall_defs.h:1197:
+^Iabi_ulong  target_st_atime_nsec;$

ERROR: code indent should never use tabs
#107: FILE: linux-user/syscall_defs.h:1199:
+^Iabi_ulong  target_st_mtime_nsec;$

ERROR: code indent should never use tabs
#110: FILE: linux-user/syscall_defs.h:1201:
+^Iabi_ulong  target_st_ctime_nsec;$

ERROR: code indent should never use tabs
#119: FILE: linux-user/syscall_defs.h:1233:
+^Iabi_ulong^Itarget_st_atime_nsec;$

ERROR: code indent should never use tabs
#123: FILE: linux-user/syscall_defs.h:1236:
+^Iabi_ulong^Itarget_st_mtime_nsec;$

ERROR: code indent should never use tabs
#127: FILE: linux-user/syscall_defs.h:1239:
+^Iabi_ulong^Itarget_st_ctime_nsec;$

ERROR: code indent should never use tabs
#136: FILE: linux-user/syscall_defs.h:1318:
+^Iabi_ulong^Itarget_st_atime_nsec;$

ERROR: code indent should never use tabs
#140: FILE: linux-user/syscall_defs.h:1321:
+^Iabi_ulong^Itarget_st_mtime_nsec;$

ERROR: code indent should never use tabs
#144: FILE: linux-user/syscall_defs.h:1324:
+^Iabi_ulong^Itarget_st_ctime_nsec;$

ERROR: code indent should never use tabs
#160: FILE: linux-user/syscall_defs.h:1342:
+^Iabi_ulong^Itarget_st_atime_nsec;$

ERROR: code indent should never use tabs
#163: FILE: linux-user/syscall_defs.h:1344:
+^Iabi_ulong^Itarget_st_mtime_nsec;$

ERROR: code indent should never use tabs
#166: FILE: linux-user/syscall_defs.h:1346:
+^Iabi_ulong^Itarget_st_ctime_nsec;$

ERROR: code indent should never use tabs
#170: FILE: linux-user/syscall_defs.h:1349:
+^Iabi_ulong^I__unused1[2];$

ERROR: code indent should never use tabs
#179: FILE: linux-user/syscall_defs.h:1377:
+^Iunsigned int^Itarget_st_atime_nsec;$

ERROR: code indent should never use tabs
#183: FILE: linux-user/syscall_defs.h:1380:
+^Iunsigned int^Itarget_st_mtime_nsec;$

ERROR: code indent should never use tabs
#187: FILE: linux-user/syscall_defs.h:1383:
+^Iunsigned int^Itarget_st_ctime_nsec;$

ERROR: code indent should never use tabs
#191: FILE: linux-user/syscall_defs.h:1385:
+^Iunsigned int^I__unused1;$

ERROR: code indent should never use tabs
#192: FILE: linux-user/syscall_defs.h:1386:
+^Iunsigned int^I__unused2;$

total: 18 errors, 0 warnings, 211 lines checked

Commit 6ec325f89c06 (linux-user: Pass through nanosecond timestamp components for stat syscalls) has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190522162147.26303-1-wens@kernel.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

  reply	other threads:[~2019-05-22 17:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-22 16:21 [Qemu-devel] [PATCH v3] linux-user: Pass through nanosecond timestamp components for stat syscalls Chen-Yu Tsai
2019-05-22 17:15 ` no-reply [this message]
2019-05-23  9:06 ` Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=155854531263.24.8817707922240677584@549697c9ad12 \
    --to=no-reply@patchew.org \
    --cc=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    --cc=wens@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.