All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Lionel Landwerlin <lionel.g.landwerlin@intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: add syncobj timeline support
Date: Thu, 23 May 2019 12:52:10 +0100	[thread overview]
Message-ID: <155861233043.28319.5452168515708280707@skylake-alporthouse-com> (raw)
In-Reply-To: <20190523114620.19335-3-lionel.g.landwerlin@intel.com>

Quoting Lionel Landwerlin (2019-05-23 12:46:20)
> -               syncobj = drm_syncobj_find(file, fence.handle);
> -               if (!syncobj) {
> -                       DRM_DEBUG("Invalid syncobj handle provided\n");
> -                       err = -ENOENT;
> -                       goto err;
> +                       if (user_fence.flags & __I915_EXEC_FENCE_UNKNOWN_FLAGS) {
> +                               err = -EINVAL;
> +                               goto err;
> +                       }
> +
> +                       if (user_fence.flags & I915_EXEC_FENCE_WAIT) {
> +                               err = drm_syncobj_find_fence(
> +                                       file, user_fence.handle, user_fence.value,
> +                                       DRM_SYNCOBJ_WAIT_FLAGS_WAIT_FOR_SUBMIT,
> +                                       &syncobj, &fence);

Is this still a synchronous wait? That would be an unfortunate change in
behaviour and antithesis to having a scheduler.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-05-23 11:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-23 11:46 [PATCH 0/2] drm/i915: timeline semaphore support Lionel Landwerlin
2019-05-23 11:46 ` [PATCH 1/2] drm/syncobj: add an output syncobj parameter to find_fence Lionel Landwerlin
2019-05-23 12:11   ` Zhou, David(ChunMing)
2019-05-23 13:35     ` Lionel Landwerlin
2019-05-23 13:37       ` Lionel Landwerlin
2019-05-23 11:46 ` [PATCH 2/2] drm/i915: add syncobj timeline support Lionel Landwerlin
2019-05-23 11:52   ` Chris Wilson [this message]
2019-05-23 13:46     ` Lionel Landwerlin
2019-05-23 13:59       ` Chris Wilson
2019-05-23 14:15         ` Lionel Landwerlin
2019-06-03 16:29         ` Lionel Landwerlin
2019-05-23 15:44 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: timeline semaphore support Patchwork
2019-05-23 16:16 ` ✓ Fi.CI.BAT: success " Patchwork
2019-05-25  0:59 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=155861233043.28319.5452168515708280707@skylake-alporthouse-com \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lionel.g.landwerlin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.