From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752547AbbLIQcr (ORCPT ); Wed, 9 Dec 2015 11:32:47 -0500 Received: from mout.kundenserver.de ([217.72.192.73]:60125 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752451AbbLIQco (ORCPT ); Wed, 9 Dec 2015 11:32:44 -0500 From: Arnd Bergmann To: Johannes Weiner Cc: Andrew Morton , linux-mm@kvack.org, netdev@vger.kernel.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] mm: memcontrol: MEMCG no longer works with SLOB Date: Wed, 09 Dec 2015 17:32:39 +0100 Message-ID: <1558902.EBTjGmY9S2@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <2564892.qO1q7YJ6Nb@wuerfel> References: <1449588624-9220-1-git-send-email-hannes@cmpxchg.org> <2564892.qO1q7YJ6Nb@wuerfel> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:TcLbJsx3uyfS0dCgJxccBZj0Qqr1fx937fXLUIMM+/khDP1GMZG 1c6YTgGYR0j/XIg1dYaSwLvsox15f4EKvAcJg8HeMe98Mtft5dsxBu7xp+rLz9Y/SI96wAk 8kjojg7UtgMIxhgPj40NKhS7mAVLgn/O2npqGmHdePKmq9sof16t0TyVujbR4FZ1uSQetaK closwNh3X6q7d2YG/1bhA== X-UI-Out-Filterresults: notjunk:1;V01:K0:WDPKWZCXvjk=:omzQxfuznC9H/ElI1fbjZ4 rCDh0bchCns3kra49xKflo8kTTl5EAJFArRY59lV4W5pKT4FElAXtF1+n3D3omTrMOvpH0rzB ZHBwzzi2byVu/yWrIsBEsEmn8ixlui/KBIpp4nB2K3q7x+0m6LORDryokdgZ49b/fMYq7m8bB B0ugRGHzEtr3sNTPg6ZOR5b2JCLsiE/V8xSDNY+XFJMfMSzmtrbYioCYYIrKHZDZgZnQ+SLc5 KRu0yLSQl8djPp655Z6wdOey/o4d22C63Ygj9QQ/euyAubnPDzDv7QbG3xH7W8p1Nn2PUKfj3 9SFaQP2yqKlcGkFdPDP9Oer3FuDK3YOiTYre9agjD+jHFnMoToN6Q+32dyUpjwbK28toOGl+1 l7xqKBv3PvRfYXkGJMCGbX/O94J5/KFAWFPB8JDc5sPYdj26Dycj95f9P18gSXn6RDauKZD6R KTHX72kxa0WAaAmsD1NEMfVhJtyC7dvOmgAXEs0XHSOMZRTeLTkqeAmc2KpqPa7XUwiWLXsAz 08IZR3uNOfjoo+1T0Jq/JmaOFNtRuujIeNWexn6Aw+ZRB6tQB4fw5qv+6EQaGg4v48+5MruTv lFMgztu0nbAnkeS2PRe3609vnHXOaRw5KmNP2LtDmKqCbqLqfNulAGPwfQnuZTUmwTz64pspW INWOZpUe7OTYORd7435vVgVS+m9y7XLGYTwmQe3sbWKFA9cNT+7pucHIRwoYwXzYJxZoJkUEp n6NfmWleHuhpZ91O Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The change to move the kmem accounting into the normal memcg code means we can no longer use memcg with slob, which lacks the memcg_params member in its struct kmem_cache: ../mm/slab.h: In function 'is_root_cache': ../mm/slab.h:187:10: error: 'struct kmem_cache' has no member named 'memcg_params' This enforces the new dependency in Kconfig. Alternatively, we could change the slob code to allow using MEMCG. Signed-off-by: Arnd Bergmann Fixes: 6e6133536d82 ("mm: memcontrol: move kmem accounting code to CONFIG_MEMCG") diff --git a/init/Kconfig b/init/Kconfig index 4822bb359fea..f4d81d382608 100644 --- a/init/Kconfig +++ b/init/Kconfig @@ -999,6 +999,7 @@ config PAGE_COUNTER config MEMCG bool "Memory Resource Controller for Control Groups" + depends on SLAB || SLUB select PAGE_COUNTER select EVENTFD help @@ -1040,7 +1041,6 @@ config MEMCG_LEGACY_KMEM config MEMCG_KMEM bool "Legacy Memory Resource Controller Kernel Memory accounting" depends on MEMCG - depends on SLUB || SLAB select MEMCG_LEGACY_KMEM help The Kernel Memory extension for Memory Resource Controller can limit From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: [PATCH] mm: memcontrol: MEMCG no longer works with SLOB Date: Wed, 09 Dec 2015 17:32:39 +0100 Message-ID: <1558902.EBTjGmY9S2@wuerfel> References: <1449588624-9220-1-git-send-email-hannes@cmpxchg.org> <2564892.qO1q7YJ6Nb@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Andrew Morton , linux-mm@kvack.org, netdev@vger.kernel.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org To: Johannes Weiner Return-path: In-Reply-To: <2564892.qO1q7YJ6Nb@wuerfel> Sender: owner-linux-mm@kvack.org List-Id: netdev.vger.kernel.org The change to move the kmem accounting into the normal memcg code means we can no longer use memcg with slob, which lacks the memcg_params member in its struct kmem_cache: ../mm/slab.h: In function 'is_root_cache': ../mm/slab.h:187:10: error: 'struct kmem_cache' has no member named 'memcg_params' This enforces the new dependency in Kconfig. Alternatively, we could change the slob code to allow using MEMCG. Signed-off-by: Arnd Bergmann Fixes: 6e6133536d82 ("mm: memcontrol: move kmem accounting code to CONFIG_MEMCG") diff --git a/init/Kconfig b/init/Kconfig index 4822bb359fea..f4d81d382608 100644 --- a/init/Kconfig +++ b/init/Kconfig @@ -999,6 +999,7 @@ config PAGE_COUNTER config MEMCG bool "Memory Resource Controller for Control Groups" + depends on SLAB || SLUB select PAGE_COUNTER select EVENTFD help @@ -1040,7 +1041,6 @@ config MEMCG_LEGACY_KMEM config MEMCG_KMEM bool "Legacy Memory Resource Controller Kernel Memory accounting" depends on MEMCG - depends on SLUB || SLAB select MEMCG_LEGACY_KMEM help The Kernel Memory extension for Memory Resource Controller can limit -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org