From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2357C04AB6 for ; Tue, 28 May 2019 08:49:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D04FD2075B for ; Tue, 28 May 2019 08:49:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726658AbfE1Itz (ORCPT ); Tue, 28 May 2019 04:49:55 -0400 Received: from Mailgw01.mediatek.com ([1.203.163.78]:37616 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725943AbfE1Itz (ORCPT ); Tue, 28 May 2019 04:49:55 -0400 X-UUID: 5b9db79e0d1846f5987bb02cc58c0733-20190528 X-UUID: 5b9db79e0d1846f5987bb02cc58c0733-20190528 Received: from mtkcas34.mediatek.inc [(172.27.4.253)] by mailgw01.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 613910974; Tue, 28 May 2019 16:49:47 +0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS33N1.mediatek.inc (172.27.4.75) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 28 May 2019 16:49:45 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 28 May 2019 16:49:45 +0800 Message-ID: <1559033385.10179.443.camel@mhfsdcap03> Subject: Re: [v3 PATCH] usb: create usb_debug_root for gadget only From: Chunfeng Yun To: Felipe Balbi CC: Greg Kroah-Hartman , Matthias Brugger , Randy Dunlap , , , , Date: Tue, 28 May 2019 16:49:45 +0800 In-Reply-To: <87k1ebj8vt.fsf@linux.intel.com> References: <87k1ebj8vt.fsf@linux.intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Felipe, On Tue, 2019-05-28 at 11:11 +0300, Felipe Balbi wrote: > Hi, > > Chunfeng Yun writes: > > diff --git a/drivers/usb/core/usb.c b/drivers/usb/core/usb.c > > index 7fcb9f782931..88b3ee03a12d 100644 > > --- a/drivers/usb/core/usb.c > > +++ b/drivers/usb/core/usb.c > > @@ -1190,7 +1190,7 @@ EXPORT_SYMBOL_GPL(usb_debug_root); > > > > static void usb_debugfs_init(void) > > { > > - usb_debug_root = debugfs_create_dir("usb", NULL); > > + usb_debug_root = debugfs_create_dir(USB_DEBUG_ROOT_NAME, NULL); > > debugfs_create_file("devices", 0444, usb_debug_root, NULL, > > &usbfs_devices_fops); > > } > > might be a better idea to move this to usb common. Good idea, I forgot there is a common file. > Then have a function > which can be called by both host and gadget to maybe create the > directory: I'll try it. Thanks a lot > > static struct dentry *usb_debug_root; > > struct dentry *usb_debugfs_init(void) > { > if (!usb_debug_root) > usb_debug_root = debugfs_create_dir("usb", NULL); > > return usb_debug_root; > } > > > Then usb core would be updated to something like: > > static void usb_core_debugfs_init(void) > { > struct dentry *root = usb_debugfs_init(); > > debugfs_create_file("devices", 0444, root, NULL, &usbfs_devices_fops); > } > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chunfeng Yun Subject: Re: [v3 PATCH] usb: create usb_debug_root for gadget only Date: Tue, 28 May 2019 16:49:45 +0800 Message-ID: <1559033385.10179.443.camel@mhfsdcap03> References: <87k1ebj8vt.fsf@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <87k1ebj8vt.fsf@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Felipe Balbi Cc: Greg Kroah-Hartman , Matthias Brugger , Randy Dunlap , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: linux-mediatek@lists.infradead.org Hi Felipe, On Tue, 2019-05-28 at 11:11 +0300, Felipe Balbi wrote: > Hi, > > Chunfeng Yun writes: > > diff --git a/drivers/usb/core/usb.c b/drivers/usb/core/usb.c > > index 7fcb9f782931..88b3ee03a12d 100644 > > --- a/drivers/usb/core/usb.c > > +++ b/drivers/usb/core/usb.c > > @@ -1190,7 +1190,7 @@ EXPORT_SYMBOL_GPL(usb_debug_root); > > > > static void usb_debugfs_init(void) > > { > > - usb_debug_root = debugfs_create_dir("usb", NULL); > > + usb_debug_root = debugfs_create_dir(USB_DEBUG_ROOT_NAME, NULL); > > debugfs_create_file("devices", 0444, usb_debug_root, NULL, > > &usbfs_devices_fops); > > } > > might be a better idea to move this to usb common. Good idea, I forgot there is a common file. > Then have a function > which can be called by both host and gadget to maybe create the > directory: I'll try it. Thanks a lot > > static struct dentry *usb_debug_root; > > struct dentry *usb_debugfs_init(void) > { > if (!usb_debug_root) > usb_debug_root = debugfs_create_dir("usb", NULL); > > return usb_debug_root; > } > > > Then usb core would be updated to something like: > > static void usb_core_debugfs_init(void) > { > struct dentry *root = usb_debugfs_init(); > > debugfs_create_file("devices", 0444, root, NULL, &usbfs_devices_fops); > } > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBB10C04AB6 for ; Tue, 28 May 2019 08:50:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B08022075B for ; Tue, 28 May 2019 08:50:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ASWLeQOy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B08022075B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=krP9u0exyRZtnCDeaR61+cA+kYppZj4GHcufUCatWCo=; b=ASWLeQOyPotOEh zELMBnb9BauuWitlFWahSdDY8+XYv9FEsGbtSfxNb8JHoNVdrE7/geNiFQxW/EiuDrfcZJhWhKiVY HRg9KVl+upXjfZEP0IeaIizBvaUPKQfhl5q1hDHcBmT8m/doe6Mlb4ka8gz1LISSSveHRHE9Jjrkv ciXrL4N1ejhpJamgxp3nNzivQeKmE/GOn45BxNX8jrLYlgyGn66g9dI4THgArUdPU6Q4Ej6qRrNQW Awt6ogjKBJYIIyzy6gdh3bH+k28BOusF3CnpxOWzYXjUNAOBsRdU4TspVbIi6N6gyTaFxgVgo4xTY 9e4uh6rUL7Nl25IeqB5Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVXnz-0007Al-TJ; Tue, 28 May 2019 08:49:59 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVXnv-00079o-UR; Tue, 28 May 2019 08:49:57 +0000 X-UUID: 4ff82eb4044d4637a11b52928284921d-20190528 X-UUID: 4ff82eb4044d4637a11b52928284921d-20190528 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 977346562; Tue, 28 May 2019 00:49:49 -0800 Received: from MTKMBS33N1.mediatek.inc (172.27.4.75) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 28 May 2019 01:49:48 -0700 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS33N1.mediatek.inc (172.27.4.75) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 28 May 2019 16:49:45 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 28 May 2019 16:49:45 +0800 Message-ID: <1559033385.10179.443.camel@mhfsdcap03> Subject: Re: [v3 PATCH] usb: create usb_debug_root for gadget only From: Chunfeng Yun To: Felipe Balbi Date: Tue, 28 May 2019 16:49:45 +0800 In-Reply-To: <87k1ebj8vt.fsf@linux.intel.com> References: <87k1ebj8vt.fsf@linux.intel.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190528_014955_989203_51868E03 X-CRM114-Status: GOOD ( 12.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-usb@vger.kernel.org, Greg Kroah-Hartman , Randy Dunlap , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Felipe, On Tue, 2019-05-28 at 11:11 +0300, Felipe Balbi wrote: > Hi, > > Chunfeng Yun writes: > > diff --git a/drivers/usb/core/usb.c b/drivers/usb/core/usb.c > > index 7fcb9f782931..88b3ee03a12d 100644 > > --- a/drivers/usb/core/usb.c > > +++ b/drivers/usb/core/usb.c > > @@ -1190,7 +1190,7 @@ EXPORT_SYMBOL_GPL(usb_debug_root); > > > > static void usb_debugfs_init(void) > > { > > - usb_debug_root = debugfs_create_dir("usb", NULL); > > + usb_debug_root = debugfs_create_dir(USB_DEBUG_ROOT_NAME, NULL); > > debugfs_create_file("devices", 0444, usb_debug_root, NULL, > > &usbfs_devices_fops); > > } > > might be a better idea to move this to usb common. Good idea, I forgot there is a common file. > Then have a function > which can be called by both host and gadget to maybe create the > directory: I'll try it. Thanks a lot > > static struct dentry *usb_debug_root; > > struct dentry *usb_debugfs_init(void) > { > if (!usb_debug_root) > usb_debug_root = debugfs_create_dir("usb", NULL); > > return usb_debug_root; > } > > > Then usb core would be updated to something like: > > static void usb_core_debugfs_init(void) > { > struct dentry *root = usb_debugfs_init(); > > debugfs_create_file("devices", 0444, root, NULL, &usbfs_devices_fops); > } > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel