From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 912A1C072B1 for ; Tue, 28 May 2019 11:00:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 746EF2070D for ; Tue, 28 May 2019 11:00:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726688AbfE1LAF (ORCPT ); Tue, 28 May 2019 07:00:05 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:5043 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726305AbfE1LAE (ORCPT ); Tue, 28 May 2019 07:00:04 -0400 X-UUID: 37ca587f27c944d28c789b064b80d225-20190528 X-UUID: 37ca587f27c944d28c789b064b80d225-20190528 Received: from mtkexhb02.mediatek.inc [(172.21.101.103)] by mailgw01.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 1074950528; Tue, 28 May 2019 18:59:58 +0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 28 May 2019 18:59:56 +0800 Received: from [172.21.77.33] (172.21.77.33) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 28 May 2019 18:59:56 +0800 Message-ID: <1559041196.12867.3.camel@mtkswgap22> Subject: Re: [PATCH 3/4] iio: adc: mediatek: SET_LATE_SYSTEM_SLEEP_PM_OPS support From: Chun-Hung Wu To: Matthias Brugger , Jonathan Cameron CC: Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Rob Herring , Mark Rutland , , , , , , , , , , Date: Tue, 28 May 2019 18:59:56 +0800 In-Reply-To: <7838dcae-8a69-0297-718b-a061b14a456d@gmail.com> References: <1557994247-16739-1-git-send-email-chun-hung.wu@mediatek.com> <1557994247-16739-4-git-send-email-chun-hung.wu@mediatek.com> <20190518113527.5210b0bf@archlinux> <1558332205.11080.6.camel@mtkswgap22> <7838dcae-8a69-0297-718b-a061b14a456d@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Matthias: Thanks for your suggestion, I think device_links is a good way to make dependency of module's suspend/resume order. Hi Jonathan: Is it ok to keep using late_suspend and early_resume, or do you think it's better to use device_links? Thanks, Chun-Hung On Wed, 2019-05-22 at 18:28 +0200, Matthias Brugger wrote: > > On 20/05/2019 08:03, Chun-Hung Wu wrote: > > Hi Jonathan: > > > > Thanks for the prompt reply, > > > > On Sat, 2019-05-18 at 11:35 +0100, Jonathan Cameron wrote: > >> On Thu, 16 May 2019 16:10:46 +0800 > >> Chun-Hung Wu wrote: > >> > >>> Move suspend/resume to late_suspend and > >>> early_resume to gurantee users can use auxadc > >> guarantee > >> > > will fix it in next version. > >>> driver at suspend/resume stage. > >> No problem with the patch content, but we need a reason why they may > >> want to do so? > > Our thermal drivers uses auxadc at suspend/resume stage. > > In order to avoid auxadc suspended prior to thermal driver, > > we move auxadc to late_suspend and early_resume. > > > > That sounds like a user of device_links [1] to me. > > [1] https://www.kernel.org/doc/html/latest/driver-api/device_link.html > > > Thanks, > > Chun-Hung > >> > >> Thanks, > >> > >> Jonathan > >>> > >>> Signed-off-by: Chun-Hung Wu > >>> --- > >>> drivers/iio/adc/mt6577_auxadc.c | 7 ++++--- > >>> 1 file changed, 4 insertions(+), 3 deletions(-) > >>> > >>> diff --git a/drivers/iio/adc/mt6577_auxadc.c b/drivers/iio/adc/mt6577_auxadc.c > >>> index e1bdcc0..58d7cb2 100644 > >>> --- a/drivers/iio/adc/mt6577_auxadc.c > >>> +++ b/drivers/iio/adc/mt6577_auxadc.c > >>> @@ -326,9 +326,10 @@ static int mt6577_auxadc_remove(struct platform_device *pdev) > >>> return 0; > >>> } > >>> > >>> -static SIMPLE_DEV_PM_OPS(mt6577_auxadc_pm_ops, > >>> - mt6577_auxadc_suspend, > >>> - mt6577_auxadc_resume); > >>> +static const struct dev_pm_ops mt6577_auxadc_pm_ops = { > >>> + SET_LATE_SYSTEM_SLEEP_PM_OPS(mt6577_auxadc_suspend, > >>> + mt6577_auxadc_resume) > >>> +}; > >>> > >>> static const struct of_device_id mt6577_auxadc_of_match[] = { > >>> { .compatible = "mediatek,mt2701-auxadc", .data = &mt8173_compat}, > >> > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chun-Hung Wu Subject: Re: [PATCH 3/4] iio: adc: mediatek: SET_LATE_SYSTEM_SLEEP_PM_OPS support Date: Tue, 28 May 2019 18:59:56 +0800 Message-ID: <1559041196.12867.3.camel@mtkswgap22> References: <1557994247-16739-1-git-send-email-chun-hung.wu@mediatek.com> <1557994247-16739-4-git-send-email-chun-hung.wu@mediatek.com> <20190518113527.5210b0bf@archlinux> <1558332205.11080.6.camel@mtkswgap22> <7838dcae-8a69-0297-718b-a061b14a456d@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <7838dcae-8a69-0297-718b-a061b14a456d@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Matthias Brugger , Jonathan Cameron Cc: Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Rob Herring , Mark Rutland , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, wsd_upstream@mediatek.com, peter.wang@mediatek.com, kuohong.wang@mediatek.com, jg_poxu@mediatek.com, stanley.chu@mediatek.com List-Id: devicetree@vger.kernel.org Hi Matthias: Thanks for your suggestion, I think device_links is a good way to make dependency of module's suspend/resume order. Hi Jonathan: Is it ok to keep using late_suspend and early_resume, or do you think it's better to use device_links? Thanks, Chun-Hung On Wed, 2019-05-22 at 18:28 +0200, Matthias Brugger wrote: > > On 20/05/2019 08:03, Chun-Hung Wu wrote: > > Hi Jonathan: > > > > Thanks for the prompt reply, > > > > On Sat, 2019-05-18 at 11:35 +0100, Jonathan Cameron wrote: > >> On Thu, 16 May 2019 16:10:46 +0800 > >> Chun-Hung Wu wrote: > >> > >>> Move suspend/resume to late_suspend and > >>> early_resume to gurantee users can use auxadc > >> guarantee > >> > > will fix it in next version. > >>> driver at suspend/resume stage. > >> No problem with the patch content, but we need a reason why they may > >> want to do so? > > Our thermal drivers uses auxadc at suspend/resume stage. > > In order to avoid auxadc suspended prior to thermal driver, > > we move auxadc to late_suspend and early_resume. > > > > That sounds like a user of device_links [1] to me. > > [1] https://www.kernel.org/doc/html/latest/driver-api/device_link.html > > > Thanks, > > Chun-Hung > >> > >> Thanks, > >> > >> Jonathan > >>> > >>> Signed-off-by: Chun-Hung Wu > >>> --- > >>> drivers/iio/adc/mt6577_auxadc.c | 7 ++++--- > >>> 1 file changed, 4 insertions(+), 3 deletions(-) > >>> > >>> diff --git a/drivers/iio/adc/mt6577_auxadc.c b/drivers/iio/adc/mt6577_auxadc.c > >>> index e1bdcc0..58d7cb2 100644 > >>> --- a/drivers/iio/adc/mt6577_auxadc.c > >>> +++ b/drivers/iio/adc/mt6577_auxadc.c > >>> @@ -326,9 +326,10 @@ static int mt6577_auxadc_remove(struct platform_device *pdev) > >>> return 0; > >>> } > >>> > >>> -static SIMPLE_DEV_PM_OPS(mt6577_auxadc_pm_ops, > >>> - mt6577_auxadc_suspend, > >>> - mt6577_auxadc_resume); > >>> +static const struct dev_pm_ops mt6577_auxadc_pm_ops = { > >>> + SET_LATE_SYSTEM_SLEEP_PM_OPS(mt6577_auxadc_suspend, > >>> + mt6577_auxadc_resume) > >>> +}; > >>> > >>> static const struct of_device_id mt6577_auxadc_of_match[] = { > >>> { .compatible = "mediatek,mt2701-auxadc", .data = &mt8173_compat}, > >> > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72252C04AB6 for ; Tue, 28 May 2019 11:00:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 447EC2070D for ; Tue, 28 May 2019 11:00:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Srh1qV/r" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 447EC2070D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rT2uUsZbmDDM7hL4upq0xO8/F/3LAWyOmNAbA/h1WeU=; b=Srh1qV/rfmc922 n/+jYlCM8P4ZR7BIeGjSs5zqkc7lz8p2YAfw05AHCwB6EidDssMiYFkTiHOa7FJAiT16nYYZqcM0v 1drgBxMAzgEX0KuYk6T8/H7omj5SefxIkxVmplTBhjWNbt7yeERt+HBswbXtKrxvDOw6yU/AaaNTp L51i9pAEnXGOKnQNFmW45TLUPPvNBmw4mi2lIY2cboPB3wD2bbmIyjDiFzvBs/48ZTUSYPFOezJC1 lKPjGGMg/ZXduiPKq2w3rAsNRU1+7jwxwFwBTTrwFELYcc+8YlDMm3mCIx2TIXvSsv/IaAWBT4soV 6OeFHF1jh8qK8EkBxbtg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVZqG-0000nz-8v; Tue, 28 May 2019 11:00:28 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVZqC-0000nF-PQ; Tue, 28 May 2019 11:00:26 +0000 X-UUID: 1b025594fc4b4999a3ba59623e9c90f8-20190528 X-UUID: 1b025594fc4b4999a3ba59623e9c90f8-20190528 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1691529342; Tue, 28 May 2019 03:00:06 -0800 Received: from MTKMBS01N1.mediatek.inc (172.21.101.68) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 28 May 2019 04:00:04 -0700 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 28 May 2019 18:59:56 +0800 Received: from [172.21.77.33] (172.21.77.33) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 28 May 2019 18:59:56 +0800 Message-ID: <1559041196.12867.3.camel@mtkswgap22> Subject: Re: [PATCH 3/4] iio: adc: mediatek: SET_LATE_SYSTEM_SLEEP_PM_OPS support From: Chun-Hung Wu To: Matthias Brugger , Jonathan Cameron Date: Tue, 28 May 2019 18:59:56 +0800 In-Reply-To: <7838dcae-8a69-0297-718b-a061b14a456d@gmail.com> References: <1557994247-16739-1-git-send-email-chun-hung.wu@mediatek.com> <1557994247-16739-4-git-send-email-chun-hung.wu@mediatek.com> <20190518113527.5210b0bf@archlinux> <1558332205.11080.6.camel@mtkswgap22> <7838dcae-8a69-0297-718b-a061b14a456d@gmail.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190528_040024_829514_CC4280E7 X-CRM114-Status: GOOD ( 20.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Lars-Peter Clausen , wsd_upstream@mediatek.com, linux-iio@vger.kernel.org, kuohong.wang@mediatek.com, linux-kernel@vger.kernel.org, stanley.chu@mediatek.com, Rob Herring , linux-mediatek@lists.infradead.org, peter.wang@mediatek.com, Peter Meerwald-Stadler , Hartmut Knaack , jg_poxu@mediatek.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Matthias: Thanks for your suggestion, I think device_links is a good way to make dependency of module's suspend/resume order. Hi Jonathan: Is it ok to keep using late_suspend and early_resume, or do you think it's better to use device_links? Thanks, Chun-Hung On Wed, 2019-05-22 at 18:28 +0200, Matthias Brugger wrote: > > On 20/05/2019 08:03, Chun-Hung Wu wrote: > > Hi Jonathan: > > > > Thanks for the prompt reply, > > > > On Sat, 2019-05-18 at 11:35 +0100, Jonathan Cameron wrote: > >> On Thu, 16 May 2019 16:10:46 +0800 > >> Chun-Hung Wu wrote: > >> > >>> Move suspend/resume to late_suspend and > >>> early_resume to gurantee users can use auxadc > >> guarantee > >> > > will fix it in next version. > >>> driver at suspend/resume stage. > >> No problem with the patch content, but we need a reason why they may > >> want to do so? > > Our thermal drivers uses auxadc at suspend/resume stage. > > In order to avoid auxadc suspended prior to thermal driver, > > we move auxadc to late_suspend and early_resume. > > > > That sounds like a user of device_links [1] to me. > > [1] https://www.kernel.org/doc/html/latest/driver-api/device_link.html > > > Thanks, > > Chun-Hung > >> > >> Thanks, > >> > >> Jonathan > >>> > >>> Signed-off-by: Chun-Hung Wu > >>> --- > >>> drivers/iio/adc/mt6577_auxadc.c | 7 ++++--- > >>> 1 file changed, 4 insertions(+), 3 deletions(-) > >>> > >>> diff --git a/drivers/iio/adc/mt6577_auxadc.c b/drivers/iio/adc/mt6577_auxadc.c > >>> index e1bdcc0..58d7cb2 100644 > >>> --- a/drivers/iio/adc/mt6577_auxadc.c > >>> +++ b/drivers/iio/adc/mt6577_auxadc.c > >>> @@ -326,9 +326,10 @@ static int mt6577_auxadc_remove(struct platform_device *pdev) > >>> return 0; > >>> } > >>> > >>> -static SIMPLE_DEV_PM_OPS(mt6577_auxadc_pm_ops, > >>> - mt6577_auxadc_suspend, > >>> - mt6577_auxadc_resume); > >>> +static const struct dev_pm_ops mt6577_auxadc_pm_ops = { > >>> + SET_LATE_SYSTEM_SLEEP_PM_OPS(mt6577_auxadc_suspend, > >>> + mt6577_auxadc_resume) > >>> +}; > >>> > >>> static const struct of_device_id mt6577_auxadc_of_match[] = { > >>> { .compatible = "mediatek,mt2701-auxadc", .data = &mt8173_compat}, > >> > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel