From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65AA8C04AB6 for ; Tue, 28 May 2019 15:46:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3E84021473 for ; Tue, 28 May 2019 15:46:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726792AbfE1Pqv (ORCPT ); Tue, 28 May 2019 11:46:51 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:5115 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726243AbfE1Pqu (ORCPT ); Tue, 28 May 2019 11:46:50 -0400 X-UUID: 8dfb5a0ce4274b74b434e317d5e50b7d-20190528 X-UUID: 8dfb5a0ce4274b74b434e317d5e50b7d-20190528 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw02.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 1322292173; Tue, 28 May 2019 23:46:46 +0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 28 May 2019 23:46:45 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 28 May 2019 23:46:45 +0800 Message-ID: <1559058405.26151.6.camel@mtkswgap22> Subject: Re: [PATCH] arm64: mm: make CONFIG_ZONE_DMA32 configurable From: Miles Chen To: Robin Murphy CC: Catalin Marinas , Will Deacon , , , , Date: Tue, 28 May 2019 23:46:45 +0800 In-Reply-To: <814b9bd0-38de-4b8d-92b3-d663931d90bf@arm.com> References: <1558973315-19655-1-git-send-email-miles.chen@mediatek.com> <814b9bd0-38de-4b8d-92b3-d663931d90bf@arm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2019-05-28 at 11:43 +0100, Robin Murphy wrote: > On 27/05/2019 17:08, Miles Chen wrote: > > This change makes CONFIG_ZONE_DMA32 defuly y and allows users > > to overwrite it. > > > > For the SoCs that do not need CONFIG_ZONE_DMA32, this is the > > first step to manage all available memory by a single > > zone(normal zone) to reduce the overhead of multiple zones. > > > > The change also fixes a build error when CONFIG_NUMA=y and > > CONFIG_ZONE_DMA32=n. > > > > arch/arm64/mm/init.c:195:17: error: use of undeclared identifier 'ZONE_DMA32' > > max_zone_pfns[ZONE_DMA32] = PFN_DOWN(max_zone_dma_phys()); > > > > Signed-off-by: Miles Chen > > --- > > arch/arm64/Kconfig | 3 ++- > > arch/arm64/mm/init.c | 2 ++ > > 2 files changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > > index 76f6e4765f49..9d20a736d1d1 100644 > > --- a/arch/arm64/Kconfig > > +++ b/arch/arm64/Kconfig > > @@ -260,7 +260,8 @@ config GENERIC_CALIBRATE_DELAY > > def_bool y > > > > config ZONE_DMA32 > > - def_bool y > > + bool "Support DMA32 zone" > > This probably warrants an "if EMBEDDED" or "if EXPERT", since turning it > off produces a kernel which won't work at all on certain systems (I've > played around with this before...) Thanks for your comment. I'll put a "if EXPERT" here to avoid this case. > > > + default y > > > > config HAVE_GENERIC_GUP > > def_bool y > > diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c > > index d2adffb81b5d..96829ce21f99 100644 > > --- a/arch/arm64/mm/init.c > > +++ b/arch/arm64/mm/init.c > > @@ -191,8 +191,10 @@ static void __init zone_sizes_init(unsigned long min, unsigned long max) > > { > > unsigned long max_zone_pfns[MAX_NR_ZONES] = {0}; > > > > +#ifdef CONFIG_ZONE_DMA32 > > if (IS_ENABLED(CONFIG_ZONE_DMA32)) > > There's no point keeping the IS_ENABLED() check when it's entirely > redundant with the #ifdefs. I'll remove the IS_ENABLE() code in next patch. -Miles > > Robin. > > > max_zone_pfns[ZONE_DMA32] = PFN_DOWN(max_zone_dma_phys()); > > +#endif > > max_zone_pfns[ZONE_NORMAL] = max; > > > > free_area_init_nodes(max_zone_pfns); > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miles Chen Subject: Re: [PATCH] arm64: mm: make CONFIG_ZONE_DMA32 configurable Date: Tue, 28 May 2019 23:46:45 +0800 Message-ID: <1559058405.26151.6.camel@mtkswgap22> References: <1558973315-19655-1-git-send-email-miles.chen@mediatek.com> <814b9bd0-38de-4b8d-92b3-d663931d90bf@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <814b9bd0-38de-4b8d-92b3-d663931d90bf@arm.com> Sender: linux-kernel-owner@vger.kernel.org To: Robin Murphy Cc: Catalin Marinas , Will Deacon , linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, wsd_upstream@mediatek.com List-Id: linux-mediatek@lists.infradead.org On Tue, 2019-05-28 at 11:43 +0100, Robin Murphy wrote: > On 27/05/2019 17:08, Miles Chen wrote: > > This change makes CONFIG_ZONE_DMA32 defuly y and allows users > > to overwrite it. > > > > For the SoCs that do not need CONFIG_ZONE_DMA32, this is the > > first step to manage all available memory by a single > > zone(normal zone) to reduce the overhead of multiple zones. > > > > The change also fixes a build error when CONFIG_NUMA=y and > > CONFIG_ZONE_DMA32=n. > > > > arch/arm64/mm/init.c:195:17: error: use of undeclared identifier 'ZONE_DMA32' > > max_zone_pfns[ZONE_DMA32] = PFN_DOWN(max_zone_dma_phys()); > > > > Signed-off-by: Miles Chen > > --- > > arch/arm64/Kconfig | 3 ++- > > arch/arm64/mm/init.c | 2 ++ > > 2 files changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > > index 76f6e4765f49..9d20a736d1d1 100644 > > --- a/arch/arm64/Kconfig > > +++ b/arch/arm64/Kconfig > > @@ -260,7 +260,8 @@ config GENERIC_CALIBRATE_DELAY > > def_bool y > > > > config ZONE_DMA32 > > - def_bool y > > + bool "Support DMA32 zone" > > This probably warrants an "if EMBEDDED" or "if EXPERT", since turning it > off produces a kernel which won't work at all on certain systems (I've > played around with this before...) Thanks for your comment. I'll put a "if EXPERT" here to avoid this case. > > > + default y > > > > config HAVE_GENERIC_GUP > > def_bool y > > diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c > > index d2adffb81b5d..96829ce21f99 100644 > > --- a/arch/arm64/mm/init.c > > +++ b/arch/arm64/mm/init.c > > @@ -191,8 +191,10 @@ static void __init zone_sizes_init(unsigned long min, unsigned long max) > > { > > unsigned long max_zone_pfns[MAX_NR_ZONES] = {0}; > > > > +#ifdef CONFIG_ZONE_DMA32 > > if (IS_ENABLED(CONFIG_ZONE_DMA32)) > > There's no point keeping the IS_ENABLED() check when it's entirely > redundant with the #ifdefs. I'll remove the IS_ENABLE() code in next patch. -Miles > > Robin. > > > max_zone_pfns[ZONE_DMA32] = PFN_DOWN(max_zone_dma_phys()); > > +#endif > > max_zone_pfns[ZONE_NORMAL] = max; > > > > free_area_init_nodes(max_zone_pfns); > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE371C04AB6 for ; Tue, 28 May 2019 15:47:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9FCBB2075C for ; Tue, 28 May 2019 15:47:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BHmp/crD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9FCBB2075C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gleR6O66RAeLSPaMk6dcWZXSPgquYKXABDatRVPWfHE=; b=BHmp/crDFIe5tZ jJaGDLL34TQomj6zWLn0s/IVjtTm4w6dXelqCsvAb2+/xu+Exo+85o88rvxW4xYScSCgdP1ndDrzm tihPRGODb3helPoXWH8CM3btJi91mPzLmOOkoUZh1RekEFOiZFcP0EZTouT2PeOSdp+HFgUqG9I4s cF86ryEyVOB4Q4HV0wFk0uUbDsXHYP3g34TiSxwzSMw+oEu9QImj4f/YHY8BKhUhcmBTebHXZA4OT vBWhPTwZGzq8DLddiPsxdkxVP/DG8gZJIKJq8uPdMjQUinOqBkh7J1ulqYlwmGo+961K+xEFoQWGh tdhjXUMraatjJ13U7TaQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVeJd-0006Yy-EZ; Tue, 28 May 2019 15:47:05 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVeJW-0006UL-FT; Tue, 28 May 2019 15:47:03 +0000 X-UUID: deb7c255ae734f81abead77dacf636e3-20190528 X-UUID: deb7c255ae734f81abead77dacf636e3-20190528 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1967243365; Tue, 28 May 2019 07:46:48 -0800 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 28 May 2019 08:46:46 -0700 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 28 May 2019 23:46:45 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 28 May 2019 23:46:45 +0800 Message-ID: <1559058405.26151.6.camel@mtkswgap22> Subject: Re: [PATCH] arm64: mm: make CONFIG_ZONE_DMA32 configurable From: Miles Chen To: Robin Murphy Date: Tue, 28 May 2019 23:46:45 +0800 In-Reply-To: <814b9bd0-38de-4b8d-92b3-d663931d90bf@arm.com> References: <1558973315-19655-1-git-send-email-miles.chen@mediatek.com> <814b9bd0-38de-4b8d-92b3-d663931d90bf@arm.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190528_084658_517928_301D839E X-CRM114-Status: GOOD ( 20.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wsd_upstream@mediatek.com, Catalin Marinas , Will Deacon , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2019-05-28 at 11:43 +0100, Robin Murphy wrote: > On 27/05/2019 17:08, Miles Chen wrote: > > This change makes CONFIG_ZONE_DMA32 defuly y and allows users > > to overwrite it. > > > > For the SoCs that do not need CONFIG_ZONE_DMA32, this is the > > first step to manage all available memory by a single > > zone(normal zone) to reduce the overhead of multiple zones. > > > > The change also fixes a build error when CONFIG_NUMA=y and > > CONFIG_ZONE_DMA32=n. > > > > arch/arm64/mm/init.c:195:17: error: use of undeclared identifier 'ZONE_DMA32' > > max_zone_pfns[ZONE_DMA32] = PFN_DOWN(max_zone_dma_phys()); > > > > Signed-off-by: Miles Chen > > --- > > arch/arm64/Kconfig | 3 ++- > > arch/arm64/mm/init.c | 2 ++ > > 2 files changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > > index 76f6e4765f49..9d20a736d1d1 100644 > > --- a/arch/arm64/Kconfig > > +++ b/arch/arm64/Kconfig > > @@ -260,7 +260,8 @@ config GENERIC_CALIBRATE_DELAY > > def_bool y > > > > config ZONE_DMA32 > > - def_bool y > > + bool "Support DMA32 zone" > > This probably warrants an "if EMBEDDED" or "if EXPERT", since turning it > off produces a kernel which won't work at all on certain systems (I've > played around with this before...) Thanks for your comment. I'll put a "if EXPERT" here to avoid this case. > > > + default y > > > > config HAVE_GENERIC_GUP > > def_bool y > > diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c > > index d2adffb81b5d..96829ce21f99 100644 > > --- a/arch/arm64/mm/init.c > > +++ b/arch/arm64/mm/init.c > > @@ -191,8 +191,10 @@ static void __init zone_sizes_init(unsigned long min, unsigned long max) > > { > > unsigned long max_zone_pfns[MAX_NR_ZONES] = {0}; > > > > +#ifdef CONFIG_ZONE_DMA32 > > if (IS_ENABLED(CONFIG_ZONE_DMA32)) > > There's no point keeping the IS_ENABLED() check when it's entirely > redundant with the #ifdefs. I'll remove the IS_ENABLE() code in next patch. -Miles > > Robin. > > > max_zone_pfns[ZONE_DMA32] = PFN_DOWN(max_zone_dma_phys()); > > +#endif > > max_zone_pfns[ZONE_NORMAL] = max; > > > > free_area_init_nodes(max_zone_pfns); > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel