All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Hancock <hancock@sedsystems.ca>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] package/chrony: add option for debug logging
Date: Wed, 29 May 2019 17:18:06 -0600	[thread overview]
Message-ID: <1559171886-14446-1-git-send-email-hancock@sedsystems.ca> (raw)
In-Reply-To: <b96bc92f-ec2a-acec-9667-228014c12e3f@sedsystems.ca>

Add a BR2_PACKAGE_CHRONY_DEBUG_LOGGING config option to allow enabling
compiled-in support for debug logging in Chrony. Enable by default as
this makes it much easier to debug Chrony issues and should only be
disabled by those very sensitive to binary size.

Signed-off-by: Robert Hancock <hancock@sedsystems.ca>
---
 package/chrony/Config.in | 10 ++++++++++
 package/chrony/chrony.mk |  3 ++-
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/package/chrony/Config.in b/package/chrony/Config.in
index 05d6fc1..7d401627 100644
--- a/package/chrony/Config.in
+++ b/package/chrony/Config.in
@@ -6,3 +6,13 @@ config BR2_PACKAGE_CHRONY
 	  accuracy of the system clock.
 
 	  http://chrony.tuxfamily.org/
+
+config BR2_PACKAGE_CHRONY_DEBUG_LOGGING
+	bool "enable debug logging support"
+	default y
+	depends on BR2_PACKAGE_CHRONY
+	help
+	  Enable support for debug logging output from Chrony when enabled at
+	  runtime. If disabled, code for debug logging will not be compiled in.
+	  Enabling this option increases the installed Chrony binary size by
+	  approximately 15%.
diff --git a/package/chrony/chrony.mk b/package/chrony/chrony.mk
index b5821b2..2d03fce 100644
--- a/package/chrony/chrony.mk
+++ b/package/chrony/chrony.mk
@@ -13,7 +13,8 @@ CHRONY_CONF_OPTS = \
 	--host-system=Linux \
 	--host-machine=$(BR2_ARCH) \
 	--prefix=/usr \
-	--without-tomcrypt
+	--without-tomcrypt \
+	$(if $(BR2_PACKAGE_CHRONY_DEBUG_LOGGING),--enable-debug,--disable-debug)
 
 ifeq ($(BR2_PACKAGE_LIBCAP),y)
 CHRONY_DEPENDENCIES += libcap
-- 
1.8.3.1

  reply	other threads:[~2019-05-29 23:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-28 23:40 [Buildroot] [PATCH] package/chrony: add option for debug logging Robert Hancock
2019-05-29 21:01 ` Arnout Vandecappelle
2019-05-29 22:07   ` Robert Hancock
2019-05-29 23:18     ` Robert Hancock [this message]
2019-10-27 20:50       ` [Buildroot] [PATCH v2] " Arnout Vandecappelle
2019-05-31  8:46     ` [Buildroot] [PATCH] " Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1559171886-14446-1-git-send-email-hancock@sedsystems.ca \
    --to=hancock@sedsystems.ca \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.