From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAB47C28CC0 for ; Thu, 30 May 2019 02:29:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B863224436 for ; Thu, 30 May 2019 02:29:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727377AbfE3C3A (ORCPT ); Wed, 29 May 2019 22:29:00 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:14973 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726483AbfE3C27 (ORCPT ); Wed, 29 May 2019 22:28:59 -0400 X-UUID: b975914154764829a05b0c1d75133086-20190530 X-UUID: b975914154764829a05b0c1d75133086-20190530 Received: from mtkcas06.mediatek.inc [(172.21.101.30)] by mailgw02.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 1905035381; Thu, 30 May 2019 10:28:56 +0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 30 May 2019 10:28:54 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 30 May 2019 10:28:54 +0800 Message-ID: <1559183334.6868.3.camel@mtksdaap41> Subject: Re: [PATCH v2 4/4] drm: mediatek: clear num_pipes when unbind driver From: CK Hu To: Hsin-Yi Wang CC: , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , , , Date: Thu, 30 May 2019 10:28:54 +0800 In-Reply-To: <20190529102555.251579-5-hsinyi@chromium.org> References: <20190529102555.251579-1-hsinyi@chromium.org> <20190529102555.251579-5-hsinyi@chromium.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Hsin-Yi: On Wed, 2019-05-29 at 18:25 +0800, Hsin-Yi Wang wrote: > num_pipes is used for mutex created in mtk_drm_crtc_create(). If we > don't clear num_pipes count, when rebinding driver, the count will > be accumulated. From mtk_disp_mutex_get(), there can only be at most > 10 mutex id. Clear this number so it starts from 0 in every rebind. Reviewed-by: CK Hu > > Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.") > Signed-off-by: Hsin-Yi Wang > --- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > index 8718d123ccaa..bbfe3a464aea 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > @@ -400,6 +400,7 @@ static void mtk_drm_unbind(struct device *dev) > drm_dev_unregister(private->drm); > mtk_drm_kms_deinit(private->drm); > drm_dev_put(private->drm); > + private->num_pipes = 0; > private->drm = NULL; > } > From mboxrd@z Thu Jan 1 00:00:00 1970 From: CK Hu Subject: Re: [PATCH v2 4/4] drm: mediatek: clear num_pipes when unbind driver Date: Thu, 30 May 2019 10:28:54 +0800 Message-ID: <1559183334.6868.3.camel@mtksdaap41> References: <20190529102555.251579-1-hsinyi@chromium.org> <20190529102555.251579-5-hsinyi@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190529102555.251579-5-hsinyi@chromium.org> Sender: linux-kernel-owner@vger.kernel.org To: Hsin-Yi Wang Cc: linux-arm-kernel@lists.infradead.org, Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: linux-mediatek@lists.infradead.org Hi, Hsin-Yi: On Wed, 2019-05-29 at 18:25 +0800, Hsin-Yi Wang wrote: > num_pipes is used for mutex created in mtk_drm_crtc_create(). If we > don't clear num_pipes count, when rebinding driver, the count will > be accumulated. From mtk_disp_mutex_get(), there can only be at most > 10 mutex id. Clear this number so it starts from 0 in every rebind. Reviewed-by: CK Hu > > Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.") > Signed-off-by: Hsin-Yi Wang > --- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > index 8718d123ccaa..bbfe3a464aea 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > @@ -400,6 +400,7 @@ static void mtk_drm_unbind(struct device *dev) > drm_dev_unregister(private->drm); > mtk_drm_kms_deinit(private->drm); > drm_dev_put(private->drm); > + private->num_pipes = 0; > private->drm = NULL; > } > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C61E1C28CC0 for ; Thu, 30 May 2019 02:29:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A07924436 for ; Thu, 30 May 2019 02:29:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uuAKKNcx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A07924436 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5rHq8YBxSiPzlMp+iiAzRhKIf36KM5I6GC8fnMsotZA=; b=uuAKKNcxcrK/H+ wxFkBryU2DoLdTI/9iHFRPrZGfFPyOd3ysx2doqISBAouft282GI160UXuCLl0MMaH/61nYtPIixy bpm1BBxfrA+7ujKcMgL/ABDquYLwZrEQkwZd2ksuwjlSUsB3aJiSOqVHq7ZkAvQY8HWjwL72ceBZt D0RkaW90W1qAYx+C3nFhvOVkdu0nT9roeluL/j2SBXT0sODhzt9kguYzvoxW+hjUrPecHfCDOOYea r9/4hf9pH67DC18f9fYb66+qmDleO/2MXcaJq9RulAWUa7rVYkJtLtaMwHWCST4rCM9hirHeVcWKb 0o56hFzjP3zzy/jfyq9Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWAoe-0008SN-3C; Thu, 30 May 2019 02:29:16 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWAoZ-0008RU-Jb; Thu, 30 May 2019 02:29:13 +0000 X-UUID: 86650867fb694ef09a4889f1a06574cf-20190529 X-UUID: 86650867fb694ef09a4889f1a06574cf-20190529 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1377117187; Wed, 29 May 2019 18:29:03 -0800 Received: from MTKMBS01N1.mediatek.inc (172.21.101.68) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 29 May 2019 19:29:02 -0700 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 30 May 2019 10:28:54 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 30 May 2019 10:28:54 +0800 Message-ID: <1559183334.6868.3.camel@mtksdaap41> Subject: Re: [PATCH v2 4/4] drm: mediatek: clear num_pipes when unbind driver From: CK Hu To: Hsin-Yi Wang Date: Thu, 30 May 2019 10:28:54 +0800 In-Reply-To: <20190529102555.251579-5-hsinyi@chromium.org> References: <20190529102555.251579-1-hsinyi@chromium.org> <20190529102555.251579-5-hsinyi@chromium.org> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190529_192911_652856_179BE5CD X-CRM114-Status: GOOD ( 14.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Philipp Zabel , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, Daniel Vetter , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Hsin-Yi: On Wed, 2019-05-29 at 18:25 +0800, Hsin-Yi Wang wrote: > num_pipes is used for mutex created in mtk_drm_crtc_create(). If we > don't clear num_pipes count, when rebinding driver, the count will > be accumulated. From mtk_disp_mutex_get(), there can only be at most > 10 mutex id. Clear this number so it starts from 0 in every rebind. Reviewed-by: CK Hu > > Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.") > Signed-off-by: Hsin-Yi Wang > --- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > index 8718d123ccaa..bbfe3a464aea 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > @@ -400,6 +400,7 @@ static void mtk_drm_unbind(struct device *dev) > drm_dev_unregister(private->drm); > mtk_drm_kms_deinit(private->drm); > drm_dev_put(private->drm); > + private->num_pipes = 0; > private->drm = NULL; > } > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel