All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Andrew Morton <akpm@linux-foundation.org>,
	Matthew Wilcox <willy@infradead.org>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Cc: Matthew Wilcox <willy@infradead.org>,
	"Kirill A. Shutemov" <kirill@shutemov.name>,
	Hugh Dickins <hughd@google.com>, Jan Kara <jack@suse.cz>,
	Song Liu <liu.song.a23@gmail.com>
Subject: Re: [PATCH v4] page cache: Store only head pages in i_pages
Date: Sat, 01 Jun 2019 10:26:21 +0100	[thread overview]
Message-ID: <155938118174.22493.11599751119608173366@skylake-alporthouse-com> (raw)
In-Reply-To: <20190307153051.18815-1-willy@infradead.org>

Quoting Matthew Wilcox (2019-03-07 15:30:51)
> Transparent Huge Pages are currently stored in i_pages as pointers to
> consecutive subpages.  This patch changes that to storing consecutive
> pointers to the head page in preparation for storing huge pages more
> efficiently in i_pages.
> 
> Large parts of this are "inspired" by Kirill's patch
> https://lore.kernel.org/lkml/20170126115819.58875-2-kirill.shutemov@linux.intel.com/
> 
> Signed-off-by: Matthew Wilcox <willy@infradead.org>
> Acked-by: Jan Kara <jack@suse.cz>
> Reviewed-by: Kirill Shutemov <kirill@shutemov.name>
> Reviewed-and-tested-by: Song Liu <songliubraving@fb.com>
> Tested-by: William Kucharski <william.kucharski@oracle.com>
> Reviewed-by: William Kucharski <william.kucharski@oracle.com>

I've bisected some new softlockups under THP mempressure to this patch.
They are all rcu stalls that look similar to:
[  242.645276] rcu: INFO: rcu_preempt detected stalls on CPUs/tasks:
[  242.645293] rcu: 	Tasks blocked on level-0 rcu_node (CPUs 0-3): P828
[  242.645301] 	(detected by 1, t=5252 jiffies, g=55501, q=221)
[  242.645307] gem_syslatency  R  running task        0   828    815 0x00004000
[  242.645315] Call Trace:
[  242.645326]  ? __schedule+0x1a0/0x440
[  242.645332]  ? preempt_schedule_irq+0x27/0x50
[  242.645337]  ? apic_timer_interrupt+0xa/0x20
[  242.645342]  ? xas_load+0x3c/0x80
[  242.645347]  ? xas_load+0x8/0x80
[  242.645353]  ? find_get_entry+0x4f/0x130
[  242.645358]  ? pagecache_get_page+0x2b/0x210
[  242.645364]  ? lookup_swap_cache+0x42/0x100
[  242.645371]  ? do_swap_page+0x6f/0x600
[  242.645375]  ? unmap_region+0xc2/0xe0
[  242.645380]  ? __handle_mm_fault+0x7a9/0xfa0
[  242.645385]  ? handle_mm_fault+0xc2/0x1c0
[  242.645393]  ? __do_page_fault+0x198/0x410
[  242.645399]  ? page_fault+0x5/0x20
[  242.645404]  ? page_fault+0x1b/0x20

Any suggestions as to what information you might want?
-Chris

  reply	other threads:[~2019-06-01  9:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-07 15:30 Matthew Wilcox
2019-06-01  9:26 ` Chris Wilson [this message]
2019-06-01 11:44   ` Chris Wilson
2019-06-02 10:51     ` Matthew Wilcox
2019-06-02 13:11       ` Chris Wilson
2019-06-02 19:28       ` Chris Wilson
2019-06-02 21:47 ` Chris Wilson
2019-06-12  1:46   ` Kirill A. Shutemov
2019-06-12  7:42     ` Chris Wilson
2019-06-19 10:04       ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=155938118174.22493.11599751119608173366@skylake-alporthouse-com \
    --to=chris@chris-wilson.co.uk \
    --cc=akpm@linux-foundation.org \
    --cc=hughd@google.com \
    --cc=jack@suse.cz \
    --cc=kirill@shutemov.name \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=liu.song.a23@gmail.com \
    --cc=willy@infradead.org \
    --subject='Re: [PATCH v4] page cache: Store only head pages in i_pages' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.