Re: [Qemu-devel] [PATCH v20 00/24] Add RX archtecture support

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/20190616142836.10614-1-ysato@users.sourceforge.jp/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190616142836.10614-1-ysato@users.sourceforge.jp
Type: series
Subject: [Qemu-devel] [PATCH v20 00/24] Add RX archtecture support

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
63acf99 BootLinuxConsoleTest: Test the RX-Virt machine
55c11a3 MAINTAINERS: Add RX
e70d51d Add rx-softmmu
92d29e0 hw/registerfields.h: Add 8bit and 16bit register macros
daf1337 qemu/bitops.h: Add extract8 and extract16
2d9c0d6 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
ce5f6c3 hw/rx: Honor -accel qtest
a22cc3b target/rx: Move rx_load_image to rx-virt.
8736a61 hw/rx: RX Target hardware definition
dc2af92 hw/char: RX62N serial communication interface (SCI)
f3d48c1 hw/timer: RX62N internal timer modules
4a32817 hw/intc: RX62N interrupt controller (ICUa)
99e0a91 target/rx: Dump bytes for each insn during disassembly
92fc3b3 target/rx: Collect all bytes during disassembly
ba396eb target/rx: Emit all disassembly in one prt()
e0ed57b target/rx: Use prt_ldmi for XCHG_mr disassembly
44ee1c7 target/rx: Replace operand with prt_ldmi in disassembler
c62d37a target/rx: Disassemble rx_index_addr into a string
7f19f36 target/rx: RX disassembler
0998f1a target/rx: simplify rx_cpu_class_by_name
b5e3446 target/rx: Follow the change of tcg.
5338b4d target/rx: CPU definition
3f32ebc target/rx: TCG helper
af95d40 target/rx: TCG translation

=== OUTPUT BEGIN ===
1/24 Checking commit af95d40319c1 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 3065 lines checked

Patch 1/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/24 Checking commit 3f32ebceb081 (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 649 lines checked

Patch 2/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/24 Checking commit 5338b4d31288 (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 645 lines checked

Patch 3/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/24 Checking commit b5e3446977c2 (target/rx: Follow the change of tcg.)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15: 
new file mode 100644

total: 0 errors, 1 warnings, 121 lines checked

Patch 4/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/24 Checking commit 0998f1ad7b92 (target/rx: simplify rx_cpu_class_by_name)
6/24 Checking commit 7f19f364a358 (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

total: 0 errors, 1 warnings, 1497 lines checked

Patch 6/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/24 Checking commit c62d37a04fd1 (target/rx: Disassemble rx_index_addr into a string)
8/24 Checking commit 44ee1c75bf83 (target/rx: Replace operand with prt_ldmi in disassembler)
9/24 Checking commit e0ed57b911f8 (target/rx: Use prt_ldmi for XCHG_mr disassembly)
10/24 Checking commit ba396eb8d526 (target/rx: Emit all disassembly in one prt())
11/24 Checking commit 92fc3b3987e0 (target/rx: Collect all bytes during disassembly)
12/24 Checking commit 99e0a9185550 (target/rx: Dump bytes for each insn during disassembly)
13/24 Checking commit 4a32817f6463 (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
new file mode 100644

total: 0 errors, 1 warnings, 442 lines checked

Patch 13/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/24 Checking commit f3d48c1450ab (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

total: 0 errors, 1 warnings, 839 lines checked

Patch 14/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/24 Checking commit dc2af9256d00 (hw/char: RX62N serial communication interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43: 
new file mode 100644

total: 0 errors, 1 warnings, 398 lines checked

Patch 15/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/24 Checking commit 8736a613a5c4 (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21: 
new file mode 100644

total: 0 errors, 1 warnings, 457 lines checked

Patch 16/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/24 Checking commit a22cc3bcd07b (target/rx: Move rx_load_image to rx-virt.)
18/24 Checking commit ce5f6c3b497e (hw/rx: Honor -accel qtest)
19/24 Checking commit 2d9c0d66093a (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core)
20/24 Checking commit daf1337ffd47 (qemu/bitops.h: Add extract8 and extract16)
21/24 Checking commit 92d29e02f00c (hw/registerfields.h: Add 8bit and 16bit register macros)
Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2467.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) };

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) / 2 };

total: 2 errors, 0 warnings, 56 lines checked

Patch 21/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

22/24 Checking commit e70d51decf77 (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#61: 
new file mode 100644

total: 0 errors, 1 warnings, 73 lines checked

Patch 22/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
23/24 Checking commit 55c11a37d1e4 (MAINTAINERS: Add RX)
24/24 Checking commit 63acf9992300 (BootLinuxConsoleTest: Test the RX-Virt machine)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190616142836.10614-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com