From: ben.hutchings@codethink.co.uk (Ben Hutchings)
To: cip-dev@lists.cip-project.org
Subject: [cip-dev] [cip-kernel-sec 1/3] remotes: check that remotes exist
Date: Tue, 18 Jun 2019 16:07:15 +0100 [thread overview]
Message-ID: <1560870435.21054.38.camel@codethink.co.uk> (raw)
In-Reply-To: <20190618024025.8274-2-daniel.sangorrin@toshiba.co.jp>
This mostly looks fine, except:
On Tue, 2019-06-18 at 11:40 +0900, Daniel Sangorrin wrote:
[...]
> --- /dev/null
> +++ b/scripts/prepare_remotes.py
[...]
> +def main(git_repo, remotes, debug=False):
> +????kernel_sec.branch.check_git_repo(git_repo, remotes, create=True)
The debug flag doesn't have any effect...
[...]
> +????parser.add_argument('--debug',
> +????????????????????????dest='debug', action='store_true',
> +????????????????????????help='enable debugging output')
[...]
...so neither does the --debug option.
I think you can remove them both.
Ben.
--
Ben Hutchings, Software Developer ? Codethink Ltd
https://www.codethink.co.uk/ Dale House, 35 Dale Street
Manchester, M1 2HF, United Kingdom
next prev parent reply other threads:[~2019-06-18 15:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 2:40 [cip-dev] patches to check remotes Daniel Sangorrin
2019-06-18 2:40 ` [cip-dev] [cip-kernel-sec 1/3] remotes: check that remotes exist Daniel Sangorrin
2019-06-18 15:07 ` Ben Hutchings [this message]
2019-06-20 5:54 ` daniel.sangorrin at toshiba.co.jp
2019-06-18 2:40 ` [cip-dev] [cip-kernel-sec 2/3] branch: fix remotes mapping Daniel Sangorrin
2019-06-18 15:08 ` Ben Hutchings
2019-06-18 2:40 ` [cip-dev] [cip-kernel-sec 3/3] help:remote_name: use colon instead of equal Daniel Sangorrin
2019-06-18 15:08 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1560870435.21054.38.camel@codethink.co.uk \
--to=ben.hutchings@codethink.co.uk \
--cc=cip-dev@lists.cip-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.