All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] btrfs: Select LIBCRC32C again
@ 2019-07-08 13:43 Guenter Roeck
  2019-07-09 16:10 ` Guenter Roeck
  2019-07-17 14:10 ` David Sterba
  0 siblings, 2 replies; 3+ messages in thread
From: Guenter Roeck @ 2019-07-08 13:43 UTC (permalink / raw)
  To: Chris Mason, Josef Bacik
  Cc: linux-btrfs, linux-kernel, Guenter Roeck, David Sterba

With CONFIG_BTRFS_FS=y and CONFIG_CRYPTO_CRC32C=m, we get:

fs/btrfs/super.o: In function `btrfs_mount_root':
fs/btrfs/super.c:1557: undefined reference to `crc32c_impl'
fs/btrfs/super.o: In function `btrfs_print_mod_info':
fs/btrfs/super.c:2348: undefined reference to `crc32c_impl'
fs/btrfs/extent-tree.o: In function `btrfs_crc32c':
fs/btrfs/ctree.h:2609: undefined reference to `crc32c'
fs/btrfs/ctree.h:2609: undefined reference to `crc32c'
fs/btrfs/ctree.h:2609: undefined reference to `crc32c'
fs/btrfs/dir-item.o: In function `btrfs_name_hash':
fs/btrfs/ctree.h:2619: undefined reference to `crc32c'
fs/btrfs/ctree.h:2619: undefined reference to `crc32c'

and more.

Note that the comment in the offending commit "The module dependency on
crc32c is preserved via MODULE_SOFTDEP("pre: crc32c"), which was previously
provided by LIBCRC32C config option doing the same." is wrong, since it
permits CONFIG_BTRFS_FS=y in combination with CONFIG_CRYPTO_CRC32C=m.

Cc: David Sterba <dsterba@suse.com>
Fixes: d5178578bcd4 ("btrfs: directly call into crypto framework for checksumming")
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 fs/btrfs/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/btrfs/Kconfig b/fs/btrfs/Kconfig
index 212b4a854f2c..4c80c70597f9 100644
--- a/fs/btrfs/Kconfig
+++ b/fs/btrfs/Kconfig
@@ -2,6 +2,7 @@
 
 config BTRFS_FS
 	tristate "Btrfs filesystem support"
+	select LIBCRC32C
 	select CRYPTO
 	select CRYPTO_CRC32C
 	select ZLIB_INFLATE
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] btrfs: Select LIBCRC32C again
  2019-07-08 13:43 [PATCH -next] btrfs: Select LIBCRC32C again Guenter Roeck
@ 2019-07-09 16:10 ` Guenter Roeck
  2019-07-17 14:10 ` David Sterba
  1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2019-07-09 16:10 UTC (permalink / raw)
  To: Chris Mason, Josef Bacik; +Cc: linux-btrfs, linux-kernel, David Sterba

On Mon, Jul 08, 2019 at 06:43:23AM -0700, Guenter Roeck wrote:
> With CONFIG_BTRFS_FS=y and CONFIG_CRYPTO_CRC32C=m, we get:
> 
> fs/btrfs/super.o: In function `btrfs_mount_root':
> fs/btrfs/super.c:1557: undefined reference to `crc32c_impl'
> fs/btrfs/super.o: In function `btrfs_print_mod_info':
> fs/btrfs/super.c:2348: undefined reference to `crc32c_impl'
> fs/btrfs/extent-tree.o: In function `btrfs_crc32c':
> fs/btrfs/ctree.h:2609: undefined reference to `crc32c'
> fs/btrfs/ctree.h:2609: undefined reference to `crc32c'
> fs/btrfs/ctree.h:2609: undefined reference to `crc32c'
> fs/btrfs/dir-item.o: In function `btrfs_name_hash':
> fs/btrfs/ctree.h:2619: undefined reference to `crc32c'
> fs/btrfs/ctree.h:2619: undefined reference to `crc32c'
> 
> and more.
> 
> Note that the comment in the offending commit "The module dependency on
> crc32c is preserved via MODULE_SOFTDEP("pre: crc32c"), which was previously
> provided by LIBCRC32C config option doing the same." is wrong, since it
> permits CONFIG_BTRFS_FS=y in combination with CONFIG_CRYPTO_CRC32C=m.
> 

Meh, that should have been CONFIG_LIBCRC32C=m. Sorry for the confusion.

Anyway, I'll select CONFIG_LIBCRC32C=y in conjunction with CONFIG_BTRFS_FS=y
in my own build/boot tests going forward. That won't fix the problem, but
it will avoid loss of test coverage.

Guenter

> Cc: David Sterba <dsterba@suse.com>
> Fixes: d5178578bcd4 ("btrfs: directly call into crypto framework for checksumming")
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
>  fs/btrfs/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/btrfs/Kconfig b/fs/btrfs/Kconfig
> index 212b4a854f2c..4c80c70597f9 100644
> --- a/fs/btrfs/Kconfig
> +++ b/fs/btrfs/Kconfig
> @@ -2,6 +2,7 @@
>  
>  config BTRFS_FS
>  	tristate "Btrfs filesystem support"
> +	select LIBCRC32C
>  	select CRYPTO
>  	select CRYPTO_CRC32C
>  	select ZLIB_INFLATE
> -- 
> 2.7.4
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] btrfs: Select LIBCRC32C again
  2019-07-08 13:43 [PATCH -next] btrfs: Select LIBCRC32C again Guenter Roeck
  2019-07-09 16:10 ` Guenter Roeck
@ 2019-07-17 14:10 ` David Sterba
  1 sibling, 0 replies; 3+ messages in thread
From: David Sterba @ 2019-07-17 14:10 UTC (permalink / raw)
  To: Guenter Roeck
  Cc: Chris Mason, Josef Bacik, linux-btrfs, linux-kernel, David Sterba

On Mon, Jul 08, 2019 at 06:43:23AM -0700, Guenter Roeck wrote:
> With CONFIG_BTRFS_FS=y and CONFIG_CRYPTO_CRC32C=m, we get:
> 
> fs/btrfs/super.o: In function `btrfs_mount_root':
> fs/btrfs/super.c:1557: undefined reference to `crc32c_impl'
> fs/btrfs/super.o: In function `btrfs_print_mod_info':
> fs/btrfs/super.c:2348: undefined reference to `crc32c_impl'
> fs/btrfs/extent-tree.o: In function `btrfs_crc32c':
> fs/btrfs/ctree.h:2609: undefined reference to `crc32c'
> fs/btrfs/ctree.h:2609: undefined reference to `crc32c'
> fs/btrfs/ctree.h:2609: undefined reference to `crc32c'
> fs/btrfs/dir-item.o: In function `btrfs_name_hash':
> fs/btrfs/ctree.h:2619: undefined reference to `crc32c'
> fs/btrfs/ctree.h:2619: undefined reference to `crc32c'
> 
> and more.
> 
> Note that the comment in the offending commit "The module dependency on
> crc32c is preserved via MODULE_SOFTDEP("pre: crc32c"), which was previously
> provided by LIBCRC32C config option doing the same." is wrong, since it
> permits CONFIG_BTRFS_FS=y in combination with CONFIG_CRYPTO_CRC32C=m.
> 
> Cc: David Sterba <dsterba@suse.com>
> Fixes: d5178578bcd4 ("btrfs: directly call into crypto framework for checksumming")
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

We already got another fix that is scheduled for post rc1 pull request.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-07-17 14:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-08 13:43 [PATCH -next] btrfs: Select LIBCRC32C again Guenter Roeck
2019-07-09 16:10 ` Guenter Roeck
2019-07-17 14:10 ` David Sterba

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.