Re: [PATCH 2/2] drm/i915/guc: Turn on GuC/HuC auto mode

[Joonas Lahtinen <joonas.lahtinen@linux.intel.com>]

Better subject would be: "Enable HuC (through GuC) on supported platforms"

Quoting Michal Wajdeczko (2019-07-03 14:36:40)
> GuC firmware is now mature, so let it run by default.

That's bit of a misleading statement (in more than one way).

"Enable loading HuC firmware (through GuC) to unlock
advanced video codecs on supported platforms.

GuC firmware is required to authenticate the HuC firmware,
which is a requirement for it to operate."

Has the most recent firmware been merged to linux-firmware and
is it present in our CI systems?

It would also be good to list what kind of tests have been run
to ensure that there are no regressions, and which platforms
this change affects.

Regards, Joonas

> Note that today GuC is only used for HuC authentication.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  drivers/gpu/drm/i915/i915_params.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
> index d29ade3b7de6..5736c55694fe 100644
> --- a/drivers/gpu/drm/i915/i915_params.h
> +++ b/drivers/gpu/drm/i915/i915_params.h
> @@ -54,7 +54,7 @@ struct drm_printer;
>         param(int, disable_power_well, -1) \
>         param(int, enable_ips, 1) \
>         param(int, invert_brightness, 0) \
> -       param(int, enable_guc, 0) \
> +       param(int, enable_guc, -1) \
>         param(int, guc_log_level, -1) \
>         param(char *, guc_firmware_path, NULL) \
>         param(char *, huc_firmware_path, NULL) \
> -- 
> 2.19.2
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx