From: Chris Wilson <chris@chris-wilson.co.uk>
To: "Koenig, Christian" <Christian.Koenig@amd.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Cc: "intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"Daenzer, Michel" <Michel.Daenzer@amd.com>
Subject: Re: [PATCH 1/2] dma-buf: Expand reservation_list to fill allocation
Date: Mon, 15 Jul 2019 11:58:42 +0100 [thread overview]
Message-ID: <156318832239.9436.16287182586090174666@skylake-alporthouse-com> (raw)
In-Reply-To: <d6d1b44d-bec1-6a46-bcd4-5790bf7b6347@amd.com>
Quoting Koenig, Christian (2019-07-14 08:37:47)
> Am 12.07.19 um 10:03 schrieb Chris Wilson:
> > Since kmalloc() will round up the allocation to the next slab size or
> > page, it will normally return a pointer to a memory block bigger than we
> > asked for. We can query for the actual size of the allocated block using
> > ksize() and expand our variable size reservation_list to take advantage
> > of that extra space.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Christian König <christian.koenig@amd.com>
> > Cc: Michel Dänzer <michel.daenzer@amd.com>
>
> Reviewed-by: Christian König <christian.koenig@amd.com>
>
> BTW: I was wondering if we shouldn't replace the reservation_object_list
> with a dma_fence_chain.
I thought the dma_fence_chain tracked points (naturally ordered) along a
singe timeline, whereas the reservation list tracked parallel timelines.
Seems like a semantic mismatch?
(Making lookup slower would not be pleasant, tbh, both waiting on and
updating are an issue with the severe amount of reservation_objects we
currently process per execbuf.)
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-07-15 10:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 8:03 [PATCH 1/2] dma-buf: Expand reservation_list to fill allocation Chris Wilson
2019-07-12 8:03 ` [PATCH 2/2] dma-buf: Relax the write-seqlock for reallocating the shared fence list Chris Wilson
2019-07-16 9:21 ` Daniel Vetter
2019-07-16 20:05 ` Chris Wilson
2019-07-12 8:33 ` [PATCH 1/2] dma-buf: Expand reservation_list to fill allocation Michel Dänzer
2019-07-12 8:56 ` ✓ Fi.CI.BAT: success for series starting with [1/2] " Patchwork
2019-07-13 15:38 ` ✓ Fi.CI.IGT: " Patchwork
2019-07-14 7:37 ` [PATCH 1/2] " Koenig, Christian
2019-07-15 10:58 ` Chris Wilson [this message]
2019-07-15 11:11 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=156318832239.9436.16287182586090174666@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=Christian.Koenig@amd.com \
--cc=Michel.Daenzer@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.