From: Chris Wilson <chris@chris-wilson.co.uk>
To: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>,
Lucas De Marchi <lucas.demarchi@intel.com>,
igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH 2/5] i915/gem_mocs_settings: do not set undefined entries to PTE
Date: Fri, 26 Jul 2019 21:57:24 +0100 [thread overview]
Message-ID: <156417464432.21451.7245606376501365382@skylake-alporthouse-com> (raw)
In-Reply-To: <ca157c90-292f-9a13-aeb2-a434b1b51e02@intel.com>
Quoting Daniele Ceraolo Spurio (2019-07-26 21:49:28)
>
>
> On 7/25/19 1:33 PM, Lucas De Marchi wrote:
> > In the Ice Lake table we are setting all undefined entries to PTE.
> > With Tiger Lake this won't be true anymore. Even if for test in IGT we
> > add a new table for Tiger Lake, in kernel they can be shares since they
> > are supposedly compatible (only unused entries were added or became
> > unused).
> >
> > Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>
> And we shouldn't be guaranteeing that unused entries are set to
> something sensible as part of the ABI.
Better rephrased as undefined values are undefined.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-07-26 20:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 20:33 [igt-dev] [PATCH 1/5] i915/gem_mocs_settings: log the engine and MOCS index Lucas De Marchi
2019-07-25 20:33 ` [igt-dev] [PATCH 2/5] i915/gem_mocs_settings: do not set undefined entries to PTE Lucas De Marchi
2019-07-26 20:49 ` Daniele Ceraolo Spurio
2019-07-26 20:57 ` Chris Wilson [this message]
2019-07-25 20:33 ` [igt-dev] [PATCH 3/5] i915/gem_mocs_settings: add MOCS table for Tiger Lake Lucas De Marchi
2019-07-27 0:16 ` Daniele Ceraolo Spurio
2019-07-25 20:33 ` [igt-dev] [PATCH 4/5] i915/gem_mocs_settings: fix global MOCS on gen 11 Lucas De Marchi
2019-07-29 20:53 ` Kumar Valsan, Prathap
2019-07-25 20:33 ` [igt-dev] [PATCH 5/5] i915/gem_mocs_settings: add support for Tiger Lake Lucas De Marchi
2019-07-27 0:23 ` Daniele Ceraolo Spurio
2019-07-25 21:12 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [1/5] i915/gem_mocs_settings: log the engine and MOCS index Patchwork
2019-07-25 21:45 ` [igt-dev] [PATCH 1/5] " Lucas De Marchi
2019-07-26 12:39 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [1/5] " Patchwork
2019-07-26 23:26 ` Daniele Ceraolo Spurio
2019-07-26 23:49 ` Lucas De Marchi
2019-07-26 23:54 ` Daniele Ceraolo Spurio
2019-07-27 0:04 ` Lucas De Marchi
2019-07-26 23:23 ` [igt-dev] [PATCH 1/5] " Daniele Ceraolo Spurio
2019-07-26 23:35 ` Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=156417464432.21451.7245606376501365382@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=daniele.ceraolospurio@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.