From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtps.newmedia-net.de ([185.84.6.167]:39350 "EHLO webmail.newmedia-net.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751538AbdJUH6K (ORCPT ); Sat, 21 Oct 2017 03:58:10 -0400 Subject: Re: [PATCH] ath10k: rebuild crypto header in RX data frames To: Kalle Valo , Jasmine Strong Cc: ath10k , "linux-wireless@vger.kernel.org" References: <150851690590.5158.11970481736247725763.stgit@potku.adurom.net> <877evpdscc.fsf@kamboji.qca.qualcomm.com> From: Sebastian Gottschall Message-ID: <1564413e-41d7-1ad9-261e-38515382b059@dd-wrt.com> (sfid-20171021_095840_143151_89C5AE40) Date: Sat, 21 Oct 2017 09:58:04 +0200 MIME-Version: 1.0 In-Reply-To: <877evpdscc.fsf@kamboji.qca.qualcomm.com> Content-Type: text/plain; charset=utf-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: even if he used my patch. my patch should have no influence to wpa2 ccmp. it just adds the new ccmp 256 + gcmp modes Am 21.10.2017 um 06:42 schrieb Kalle Valo: > Jasmine Strong writes: > >> When we tried this patch, it completely broke all wpa2-ccmp-aes >> traffic. > Which patch, Vasanth's or Sebastian's? I even tested myself, with both > CCMP and TKIP on both AP and client modes, and didn't see see any > problems. What kind of setup you have? > > I tested on a x86 laptop and current ath.git master branch: > > ath10k_pci 0000:02:00.0: pci irq msi oper_irq_mode 2 irq_mode 0 reset_mode 0 > ath10k_pci 0000:02:00.0: qca988x hw2.0 target 0x4100016c chip_id 0x043202ff sub 0000:0000 > ath10k_pci 0000:02:00.0: kconfig debug 1 debugfs 1 tracing 1 dfs 1 testmode 1 > ath10k_pci 0000:02:00.0: firmware ver 10.2.4.70.66 api 5 features no-p2p,raw-mode,mfp,allows-mesh-bcast crc32 c2dd2ad5 > ath10k_pci 0000:02:00.0: board_file api 1 bmi_id N/A crc32 bebc7c08 > > And my hostapd.conf: > > driver=nl80211 > hw_mode=a > channel=36 > ieee80211n=1 > interface=wlan0 > ctrl_interface=/var/run/hostapd > ctrl_interface_group=adm > ssid=test-psk > wpa=2 > wpa_key_mgmt=WPA-PSK > wpa_pairwise=CCMP > wpa_passphrase=12345678 > > -- Mit freundlichen Grüssen / Regards Sebastian Gottschall / CTO NewMedia-NET GmbH - DD-WRT Firmensitz: Stubenwaldallee 21a, 64625 Bensheim Registergericht: Amtsgericht Darmstadt, HRB 25473 Geschäftsführer: Peter Steinhäuser, Christian Scheele http://www.dd-wrt.com email: s.gottschall@dd-wrt.com Tel.: +496251-582650 / Fax: +496251-5826565 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtps.newmedia-net.de ([2a05:a1c0:0:de::167] helo=webmail.newmedia-net.de) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1e5ofw-0006VB-Jw for ath10k@lists.infradead.org; Sat, 21 Oct 2017 07:58:35 +0000 Subject: Re: [PATCH] ath10k: rebuild crypto header in RX data frames References: <150851690590.5158.11970481736247725763.stgit@potku.adurom.net> <877evpdscc.fsf@kamboji.qca.qualcomm.com> From: Sebastian Gottschall Message-ID: <1564413e-41d7-1ad9-261e-38515382b059@dd-wrt.com> Date: Sat, 21 Oct 2017 09:58:04 +0200 MIME-Version: 1.0 In-Reply-To: <877evpdscc.fsf@kamboji.qca.qualcomm.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Kalle Valo , Jasmine Strong Cc: "linux-wireless@vger.kernel.org" , ath10k ZXZlbiBpZiBoZSB1c2VkIG15IHBhdGNoLiBteSBwYXRjaCBzaG91bGQgaGF2ZSBubyBpbmZsdWVu Y2UgdG8gd3BhMiAKY2NtcC4gaXQganVzdCBhZGRzIHRoZSBuZXcgY2NtcCAyNTYgKyBnY21wIG1v ZGVzCgpBbSAyMS4xMC4yMDE3IHVtIDA2OjQyIHNjaHJpZWIgS2FsbGUgVmFsbzoKPiBKYXNtaW5l IFN0cm9uZyA8amFzQGVlcm8uY29tPiB3cml0ZXM6Cj4KPj4gV2hlbiB3ZSB0cmllZCB0aGlzIHBh dGNoLCBpdCBjb21wbGV0ZWx5IGJyb2tlIGFsbCB3cGEyLWNjbXAtYWVzCj4+IHRyYWZmaWMuCj4g V2hpY2ggcGF0Y2gsIFZhc2FudGgncyBvciBTZWJhc3RpYW4ncz8gSSBldmVuIHRlc3RlZCBteXNl bGYsIHdpdGggYm90aAo+IENDTVAgYW5kIFRLSVAgb24gYm90aCBBUCBhbmQgY2xpZW50IG1vZGVz LCBhbmQgZGlkbid0IHNlZSBzZWUgYW55Cj4gcHJvYmxlbXMuIFdoYXQga2luZCBvZiBzZXR1cCB5 b3UgaGF2ZT8KPgo+IEkgdGVzdGVkIG9uIGEgeDg2IGxhcHRvcCBhbmQgY3VycmVudCBhdGguZ2l0 IG1hc3RlciBicmFuY2g6Cj4KPiBhdGgxMGtfcGNpIDAwMDA6MDI6MDAuMDogcGNpIGlycSBtc2kg b3Blcl9pcnFfbW9kZSAyIGlycV9tb2RlIDAgcmVzZXRfbW9kZSAwCj4gYXRoMTBrX3BjaSAwMDAw OjAyOjAwLjA6IHFjYTk4OHggaHcyLjAgdGFyZ2V0IDB4NDEwMDAxNmMgY2hpcF9pZCAweDA0MzIw MmZmIHN1YiAwMDAwOjAwMDAKPiBhdGgxMGtfcGNpIDAwMDA6MDI6MDAuMDoga2NvbmZpZyBkZWJ1 ZyAxIGRlYnVnZnMgMSB0cmFjaW5nIDEgZGZzIDEgdGVzdG1vZGUgMQo+IGF0aDEwa19wY2kgMDAw MDowMjowMC4wOiBmaXJtd2FyZSB2ZXIgMTAuMi40LjcwLjY2IGFwaSA1IGZlYXR1cmVzIG5vLXAy cCxyYXctbW9kZSxtZnAsYWxsb3dzLW1lc2gtYmNhc3QgY3JjMzIgYzJkZDJhZDUKPiBhdGgxMGtf cGNpIDAwMDA6MDI6MDAuMDogYm9hcmRfZmlsZSBhcGkgMSBibWlfaWQgTi9BIGNyYzMyIGJlYmM3 YzA4Cj4KPiBBbmQgbXkgaG9zdGFwZC5jb25mOgo+Cj4gZHJpdmVyPW5sODAyMTEKPiBod19tb2Rl PWEKPiBjaGFubmVsPTM2Cj4gaWVlZTgwMjExbj0xCj4gaW50ZXJmYWNlPXdsYW4wCj4gY3RybF9p bnRlcmZhY2U9L3Zhci9ydW4vaG9zdGFwZAo+IGN0cmxfaW50ZXJmYWNlX2dyb3VwPWFkbQo+IHNz aWQ9dGVzdC1wc2sKPiB3cGE9Mgo+IHdwYV9rZXlfbWdtdD1XUEEtUFNLCj4gd3BhX3BhaXJ3aXNl PUNDTVAKPiB3cGFfcGFzc3BocmFzZT0xMjM0NTY3OAo+Cj4KCi0tIApNaXQgZnJldW5kbGljaGVu IEdyw7xzc2VuIC8gUmVnYXJkcwoKU2ViYXN0aWFuIEdvdHRzY2hhbGwgLyBDVE8KCk5ld01lZGlh LU5FVCBHbWJIIC0gREQtV1JUCkZpcm1lbnNpdHo6ICBTdHViZW53YWxkYWxsZWUgMjFhLCA2NDYy NSBCZW5zaGVpbQpSZWdpc3RlcmdlcmljaHQ6IEFtdHNnZXJpY2h0IERhcm1zdGFkdCwgSFJCIDI1 NDczCkdlc2Now6RmdHNmw7xocmVyOiBQZXRlciBTdGVpbmjDpHVzZXIsIENocmlzdGlhbiBTY2hl ZWxlCmh0dHA6Ly93d3cuZGQtd3J0LmNvbQplbWFpbDogcy5nb3R0c2NoYWxsQGRkLXdydC5jb20K VGVsLjogKzQ5NjI1MS01ODI2NTAgLyBGYXg6ICs0OTYyNTEtNTgyNjU2NQoKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmF0aDEwayBtYWlsaW5nIGxpc3QK YXRoMTBrQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9hdGgxMGsK