From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH 04/17] drm/i915: Use drm_i915_private
 directly from drv_get_drvdata()
Date: Mon, 05 Aug 2019 19:01:09 +0100
Message-ID: <156502806938.28464.16991774838070624696@skylake-alporthouse-com>
References: <20190730133035.1977-1-chris@chris-wilson.co.uk>
 <20190730133035.1977-5-chris@chris-wilson.co.uk>
 <20190805170533.GA19007@intel.intel>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192])
 by gabe.freedesktop.org (Postfix) with ESMTPS id CAA7089F6D
 for <intel-gfx@lists.freedesktop.org>; Mon,  5 Aug 2019 18:01:25 +0000 (UTC)
In-Reply-To: <20190805170533.GA19007@intel.intel>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Andi Shyti <andi.shyti@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

UXVvdGluZyBBbmRpIFNoeXRpICgyMDE5LTA4LTA1IDE4OjA1OjMzKQo+IEhpIENocmlzLAo+IAo+
ID4gIHN0YXRpYyB2b2lkIGk5MTVfc3dpdGNoZXJvb19zZXRfc3RhdGUoc3RydWN0IHBjaV9kZXYg
KnBkZXYsIGVudW0gdmdhX3N3aXRjaGVyb29fc3RhdGUgc3RhdGUpCj4gPiAgewo+ID4gLSAgICAg
c3RydWN0IGRybV9kZXZpY2UgKmRldiA9IHBjaV9nZXRfZHJ2ZGF0YShwZGV2KTsKPiA+ICsgICAg
IHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1ID0gcGRldl90b19pOTE1KHBkZXYpOwo+ID4g
ICAgICAgcG1fbWVzc2FnZV90IHBtbSA9IHsgLmV2ZW50ID0gUE1fRVZFTlRfU1VTUEVORCB9Owo+
ID4gIAo+ID4gKyAgICAgaWYgKCFpOTE1KSB7Cj4gPiArICAgICAgICAgICAgIGRldl9lcnIoJnBk
ZXYtPmRldiwgIkRSTSBub3QgaW5pdGlhbGl6ZWQsIGFib3J0aW5nIHN3aXRjaC5cbiIpOwo+ID4g
KyAgICAgICAgICAgICByZXR1cm47Cj4gPiArICAgICB9Cj4gPiArCj4gPiAgICAgICBpZiAoc3Rh
dGUgPT0gVkdBX1NXSVRDSEVST09fT04pIHsKPiA+ICAgICAgICAgICAgICAgcHJfaW5mbygic3dp
dGNoZWQgb25cbiIpOwo+ID4gLSAgICAgICAgICAgICBkZXYtPnN3aXRjaF9wb3dlcl9zdGF0ZSA9
IERSTV9TV0lUQ0hfUE9XRVJfQ0hBTkdJTkc7Cj4gPiArICAgICAgICAgICAgIGk5MTUtPmRybS5z
d2l0Y2hfcG93ZXJfc3RhdGUgPSBEUk1fU1dJVENIX1BPV0VSX0NIQU5HSU5HOwo+ID4gICAgICAg
ICAgICAgICAvKiBpOTE1IHJlc3VtZSBoYW5kbGVyIGRvZXNuJ3Qgc2V0IHRvIEQwICovCj4gPiAg
ICAgICAgICAgICAgIHBjaV9zZXRfcG93ZXJfc3RhdGUocGRldiwgUENJX0QwKTsKPiA+IC0gICAg
ICAgICAgICAgaTkxNV9yZXN1bWVfc3dpdGNoZXJvbyhkZXYpOwo+ID4gLSAgICAgICAgICAgICBk
ZXYtPnN3aXRjaF9wb3dlcl9zdGF0ZSA9IERSTV9TV0lUQ0hfUE9XRVJfT047Cj4gPiArICAgICAg
ICAgICAgIGk5MTVfcmVzdW1lX3N3aXRjaGVyb28oaTkxNSk7Cj4gPiArICAgICAgICAgICAgIGk5
MTUtPmRybS5zd2l0Y2hfcG93ZXJfc3RhdGUgPSBEUk1fU1dJVENIX1BPV0VSX09OOwo+ID4gICAg
ICAgfSBlbHNlIHsKPiA+ICAgICAgICAgICAgICAgcHJfaW5mbygic3dpdGNoZWQgb2ZmXG4iKTsK
PiA+IC0gICAgICAgICAgICAgZGV2LT5zd2l0Y2hfcG93ZXJfc3RhdGUgPSBEUk1fU1dJVENIX1BP
V0VSX0NIQU5HSU5HOwo+ID4gLSAgICAgICAgICAgICBpOTE1X3N1c3BlbmRfc3dpdGNoZXJvbyhk
ZXYsIHBtbSk7Cj4gPiAtICAgICAgICAgICAgIGRldi0+c3dpdGNoX3Bvd2VyX3N0YXRlID0gRFJN
X1NXSVRDSF9QT1dFUl9PRkY7Cj4gPiArICAgICAgICAgICAgIGk5MTUtPmRybS5zd2l0Y2hfcG93
ZXJfc3RhdGUgPSBEUk1fU1dJVENIX1BPV0VSX0NIQU5HSU5HOwo+ID4gKyAgICAgICAgICAgICBp
OTE1X3N1c3BlbmRfc3dpdGNoZXJvbyhpOTE1LCBwbW0pOwo+ID4gKyAgICAgICAgICAgICBpOTE1
LT5kcm0uc3dpdGNoX3Bvd2VyX3N0YXRlID0gRFJNX1NXSVRDSF9QT1dFUl9PRkY7Cj4gCj4gZG9l
c24ndCBoYXZlIGFueXRoaW5nIHRvIGRvIHdpdGggdGhpcyBwYXRjaCwgYnV0IGRvbid0IHdlIGNh
cmUgYWJvdXQKPiB0aGUgcmVzdW1lIGFuZCBzdXNwZW5kIGZhaWx1cmVzPwoKR28gb24sIHB1dCBh
IE1hY0Jvb2sgaW4gQ0ksIEkgZGFyZSB5b3UuIEFuZCBmb3IgYSBkb3VibGUgZGFyZSwgd3JpdGUg
c29tZQppZ3QgdG8gcG9rZSBhdCB2Z2Fzd2l0Y2hlcm9vLiBJdCdzIGhhcyBuZXZlciBiZWVuIGEg
cHJpb3JpdHkgZm9yIHVzLCBhbmQKSSd2ZSBuZXZlciBldmVuIHNlZW4gYSB2Z2Fzd2l0Y2hlcm9v
IGRldmljZSB0byB0cnkgaXQgb3V0LgoKPiA+ICBzdGF0aWMgY29uc3Qgc3RydWN0IHZnYV9zd2l0
Y2hlcm9vX2NsaWVudF9vcHMgaTkxNV9zd2l0Y2hlcm9vX29wcyA9IHsKPiA+IEBAIC0xODQxLDcg
KzE4NDcsOCBAQCBpOTE1X2RyaXZlcl9jcmVhdGUoc3RydWN0IHBjaV9kZXYgKnBkZXYsIGNvbnN0
IHN0cnVjdCBwY2lfZGV2aWNlX2lkICplbnQpCj4gPiAgCj4gPiAgICAgICBpOTE1LT5kcm0ucGRl
diA9IHBkZXY7Cj4gPiAgICAgICBpOTE1LT5kcm0uZGV2X3ByaXZhdGUgPSBpOTE1Owo+ID4gLSAg
ICAgcGNpX3NldF9kcnZkYXRhKHBkZXYsICZpOTE1LT5kcm0pOwo+ID4gKyAgICAgQlVJTERfQlVH
X09OKG9mZnNldG9mKHR5cGVvZigqaTkxNSksIGRybSkpOwo+ID4gKyAgICAgcGNpX3NldF9kcnZk
YXRhKHBkZXYsIGk5MTUpOwo+IAo+IFRoaXMgbG9va3MgYSBiaXQgdG9vIGZyYWdpbGUgdG8gbWUg
YW5kIGl0J3Mgbm90IGRvY3VtZW50ZWQKPiBhbnl3aGVyZSB0aGF0IG5lZWQgdG8gaGF2ZSAiZHJt
IiBpbiBhIHNwZWNpZmljIHBvc2l0aW9uLgoKQmxpbmtzLiBNeSBtZW1vcnkgc2F5cyBJIHB1dCBp
dCBhdCB0aGUgc3RhcnQgc28gdGhhdCB3ZSBjb3VsZCByZWx5IG9uIHRoZQplcXVpdmFsZW5jZSBi
ZXR3ZWVuIGEgTlVMTCBkcm1fZGV2aWNlIGFuZCBhIE5VTEwgaTkxNV9kZXZpY2UuIEkgZmluZCBu
bwpldmlkZW5jZSB0aGF0IHdlIGNhcmVkIHRob3VnaC4KCkhvd2V2ZXIsIGJlY2F1c2UgSSBkaWRu
J3Qgd2FudCB0byBndWFyYW50ZWUgdGhhdCBJIGhhZCBmaXhlZCB1cCBhbGwgY29kZQp0aGF0IGFz
c3VtZWQgYW55dGhpbmcgYWJvdXQgZGV2X2dldF9kcnZkYXRhLCBJIHRob3VnaHQgZG9jdW1lbnRp
bmcgdGhlCmVxdWl2YWxlbmNlIGhlcmUgd291bGQgZXhwbGFpbiB3aHkgaXQgaXMgdXNlZC4KCj4g
QXQgdGhlIGVuZCBJIHdvbmRlciwgd2h5IGRvIHdlIG5lZWQgImRybSIgdG8gYmUgdGhlcmU/IFVu
bGVzcyBJCj4gbWlzc2VkIGl0LCBJIGhhdmVuJ3Qgc2VlbiBhbnl3aGVyZSBhbnkgZG91YmxlIHJl
ZmVyZW5jZSB0bwo+ICJpOTE2Ii8iZHJtIi4KCk1heWJlLCBidXQgaWYgeW91IHB1dCBzb21ldGhp
bmcgZWxzZSBhdCAwLCB5b3UnbGwgaGF2ZSB0byBleHBsYWluIHdoeQp5b3VyIGZhdm91cml0ZSBp
dCB0aGUgcmlnaHQgY2hvaWNlIDopCi1DaHJpcwpfX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0
cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s
aXN0aW5mby9pbnRlbC1nZng=