All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: "Bloomfield, Jon" <jon.bloomfield@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 5/5] drm/i915: Cancel non-persistent contexts on close
Date: Wed, 07 Aug 2019 16:08:01 +0100	[thread overview]
Message-ID: <156519048120.6198.8160520723086584407@skylake-alporthouse-com> (raw)
In-Reply-To: <AD48BB7FB99B174FBCC69E228F58B3B68B3AACF2@fmsmsx120.amr.corp.intel.com>

Quoting Bloomfield, Jon (2019-08-07 15:33:51)
[skip to end]
> We didn't explore the idea of terminating orphaned contexts though (where none of their resources are referenced by any other contexts). Is there a reason why this is not feasible? In the case of compute (certainly HPC) workloads, there would be no compositor taking the output so this might be a solution.

Sounds easier said than done. We have to go through each request and
determine it if has an external reference (or if the object holding the
reference has an external reference) to see if the output would be
visible to a third party. Sounds like a conservative GC :| 
(Coming to that conclusion suggests that we should structure the request
tracking to make reparenting easier.)

We could take a pid-1 approach and move all the orphan timelines over to
a new parent purely responsible for them. That honestly doesn't seem to
achieve anything. (We are still stuck with tasks on the GPU and no way
to kill them.)

In comparison, persistence is a rarely used "feature" and cleaning up on
context close fits in nicely with the process model. It just works as
most users/clients would expect. (Although running in non-persistent
by default hasn't show anything to explode on the desktop, it's too easy
to construct scenarios where persistence turns out to be an advantage,
particularly with chains of clients (the compositor model).) Between the
two modes, we should have most bases covered, it's hard to argue for a
third way (that is until someone has a usecase!)
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-08-07 15:10 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-06 13:47 [PATCH 1/5] drm/i915: Only enqueue already completed requests Chris Wilson
2019-08-06 13:47 ` [PATCH 2/5] drm/i915/execlists: Force preemption Chris Wilson
2019-08-06 13:47 ` [PATCH 3/5] drm/i915: Mark up "sentinel" requests Chris Wilson
2019-08-06 14:29   ` Mika Kuoppala
2019-08-06 14:47     ` Chris Wilson
2019-08-06 13:47 ` [PATCH 4/5] drm/i915/execlists: Cancel banned contexts on schedule-out Chris Wilson
2019-08-06 13:47 ` [PATCH 5/5] drm/i915: Cancel non-persistent contexts on close Chris Wilson
2019-08-06 14:11   ` Chris Wilson
2019-08-06 14:26   ` Bloomfield, Jon
2019-08-06 14:41     ` Chris Wilson
2019-08-07 13:22   ` Chris Wilson
2019-08-07 14:04     ` Bloomfield, Jon
2019-08-07 14:14       ` Chris Wilson
2019-08-07 14:33         ` Bloomfield, Jon
2019-08-07 15:08           ` Chris Wilson [this message]
2019-08-07 15:29             ` Bloomfield, Jon
2019-08-07 15:38               ` Chris Wilson
2019-08-07 16:51               ` Chris Wilson
2019-08-07 17:12                 ` Bloomfield, Jon
2019-08-09 23:34   ` Chris Wilson
2019-08-12 14:39     ` Bloomfield, Jon
2019-08-12 14:51       ` Chris Wilson
2019-08-06 14:25 ` [PATCH 1/5] drm/i915: Only enqueue already completed requests Mika Kuoppala
2019-08-06 14:44   ` Chris Wilson
2019-08-06 14:51 ` ✗ Fi.CI.BAT: failure for series starting with [1/5] " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=156519048120.6198.8160520723086584407@skylake-alporthouse-com \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jon.bloomfield@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.