From: Chris Wilson <chris@chris-wilson.co.uk>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm/i915: Markup expected timeline locks for i915_active
Date: Fri, 16 Aug 2019 13:06:00 +0100 [thread overview]
Message-ID: <156595716034.11610.2731422977702685044@skylake-alporthouse-com> (raw)
In-Reply-To: <87lfvt5nea.fsf@gaia.fi.intel.com>
Quoting Mika Kuoppala (2019-08-16 13:02:21)
> > diff --git a/drivers/gpu/drm/i915/i915_active_types.h b/drivers/gpu/drm/i915/i915_active_types.h
> > index ae3ee441c114..d857bd12aa7e 100644
> > --- a/drivers/gpu/drm/i915/i915_active_types.h
> > +++ b/drivers/gpu/drm/i915/i915_active_types.h
> > @@ -24,6 +24,9 @@ struct i915_active_request {
> > struct i915_request __rcu *request;
> > struct list_head link;
> > i915_active_retire_fn retire;
> > +#if IS_ENABLED(CONFIG_DRM_I915_DEBUG_GEM)
> > + struct mutex *lock;
>
> Checkpatch thinks the usage should be somehow stated with comment.
>
> So put something like
> /* Incorporeal. Ref piggypacking timeline for lockdep */
I'm using incorporeal. :)
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-08-16 12:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-16 9:24 [PATCH 1/3] drm/i915/execlists: Lift process_csb() out of the irq-off spinlock Chris Wilson
2019-08-16 9:24 ` [PATCH 2/3] drm/i915/gt: Mark context->active_count as protected by timeline->mutex Chris Wilson
2019-08-16 11:48 ` Mika Kuoppala
2019-08-16 9:24 ` [PATCH 3/3] drm/i915: Markup expected timeline locks for i915_active Chris Wilson
2019-08-16 12:02 ` Mika Kuoppala
2019-08-16 12:06 ` Chris Wilson [this message]
2019-08-16 11:05 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/execlists: Lift process_csb() out of the irq-off spinlock Patchwork
2019-08-16 11:26 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-08-16 11:28 ` Chris Wilson
2019-08-16 11:38 ` [PATCH 1/3] " Mika Kuoppala
2019-08-16 11:49 ` [PATCH] " Chris Wilson
2019-08-16 16:16 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with drm/i915/execlists: Lift process_csb() out of the irq-off spinlock (rev2) Patchwork
2019-08-16 16:37 ` ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=156595716034.11610.2731422977702685044@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.