From: Aaron Armstrong Skomra <skomra@gmail.com>
To: sashal@kernel.org, linux-input@vger.kernel.org, jikos@kernel.org,
benjamin.tissoires@redhat.com, ping.cheng@wacom.com,
jason.gerecke@wacom.com
Cc: Aaron Armstrong Skomra <aaron.skomra@wacom.com>,
"# v4 . 3+" <stable@vger.kernel.org>
Subject: [PATCH] HID: wacom: correct misreported EKR ring values
Date: Mon, 19 Aug 2019 10:20:30 -0700 [thread overview]
Message-ID: <1566235230-11617-1-git-send-email-aaron.skomra@wacom.com> (raw)
In-Reply-To: <20190817181109.33F1B2173B@mail.kernel.org>
The EKR ring claims a range of 0 to 71 but actually reports
values 1 to 72. The ring is used in relative mode so this
change should not affect users.
Signed-off-by: Aaron Armstrong Skomra <aaron.skomra@wacom.com>
Fixes: 72b236d60218f ("HID: wacom: Add support for Express Key Remote.")
Cc: <stable@vger.kernel.org> # v4.3+
Reviewed-by: Ping Cheng <ping.cheng@wacom.com>
Reviewed-by: Jason Gerecke <jason.gerecke@wacom.com>
---
My first attempt at sending this
patch specifically targeted to v4.9.189
neglected the "in-reply-to" in git send-email. My apologies.
drivers/hid/wacom_wac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c
index 6c3bf8846b52..949761dd29ca 100644
--- a/drivers/hid/wacom_wac.c
+++ b/drivers/hid/wacom_wac.c
@@ -819,7 +819,7 @@ static int wacom_remote_irq(struct wacom_wac *wacom_wac, size_t len)
input_report_key(input, BTN_BASE2, (data[11] & 0x02));
if (data[12] & 0x80)
- input_report_abs(input, ABS_WHEEL, (data[12] & 0x7f));
+ input_report_abs(input, ABS_WHEEL, (data[12] & 0x7f) - 1);
else
input_report_abs(input, ABS_WHEEL, 0);
--
2.17.1
next parent reply other threads:[~2019-08-19 17:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190817181109.33F1B2173B@mail.kernel.org>
2019-08-19 17:20 ` Aaron Armstrong Skomra [this message]
2019-08-19 16:41 [PATCH] HID: wacom: correct misreported EKR ring values Aaron Armstrong Skomra
2019-08-19 17:02 ` Sasha Levin
2019-08-19 17:02 ` Sasha Levin
[not found] ` <CAEoswT3mvABD7T_0WkwrAOe1PHO62jZ63tUb2UBQLm_Tqu-guw@mail.gmail.com>
2019-08-19 19:03 ` Sasha Levin
2019-08-19 19:03 ` Sasha Levin
-- strict thread matches above, loose matches on Subject: below --
2019-08-16 19:00 Aaron Armstrong Skomra
2019-08-20 8:43 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1566235230-11617-1-git-send-email-aaron.skomra@wacom.com \
--to=skomra@gmail.com \
--cc=aaron.skomra@wacom.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jason.gerecke@wacom.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=ping.cheng@wacom.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.