All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>,
	intel-gfx@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@intel.com>
Subject: Re: [PATCH v2 1/2] drm/i915: Dynamically allocate s0ix struct for VLV
Date: Tue, 20 Aug 2019 12:14:03 +0100	[thread overview]
Message-ID: <156629964319.1374.5752199343673724939@skylake-alporthouse-com> (raw)
In-Reply-To: <20190820020147.5667-1-daniele.ceraolospurio@intel.com>

Quoting Daniele Ceraolo Spurio (2019-08-20 03:01:46)
> This is only required for a single platform so no need to reserve the
> memory on all of them.
> 
> This removes the last direct dependency of i915_drv.h on i915_reg.h
> (apart from the i915_reg_t definition).
> 
> v2: drop unneeded diff, keep the vlv prefix, call functions
>     unconditionally (Jani), fwd declaration of the struct (Chris)
> 
> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Imre Deak <imre.deak@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>

Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Any chance we can move this to vlv_s0ix.c? Or perhaps
vlv_suspend.c, or vlv_pm.c?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-08-20 11:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-20  2:01 [PATCH v2 1/2] drm/i915: Dynamically allocate s0ix struct for VLV Daniele Ceraolo Spurio
2019-08-20  2:01 ` [PATCH v2 2/2] drm/i915: Introduce intel_reg_types.h Daniele Ceraolo Spurio
2019-08-20 11:16   ` Chris Wilson
2019-08-20 14:26     ` Chris Wilson
2019-08-20 15:42   ` Michal Wajdeczko
2019-08-20 18:00     ` Daniele Ceraolo Spurio
2019-08-22 21:16       ` Daniele Ceraolo Spurio
2019-08-23 12:10         ` Jani Nikula
2019-08-23 12:36           ` Jani Nikula
2019-08-23 14:55             ` Daniele Ceraolo Spurio
2019-08-23 16:13               ` Michal Wajdeczko
2019-08-20  2:23 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/2] drm/i915: Dynamically allocate s0ix struct for VLV Patchwork
2019-08-20  2:44 ` ✓ Fi.CI.BAT: success " Patchwork
2019-08-20 11:14 ` Chris Wilson [this message]
2019-08-20 12:43 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=156629964319.1374.5752199343673724939@skylake-alporthouse-com \
    --to=chris@chris-wilson.co.uk \
    --cc=daniele.ceraolospurio@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.