From: Chris Wilson <chris@chris-wilson.co.uk>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 06/15] drm/i915: Mark up obj->pin_global as being atomic
Date: Fri, 23 Aug 2019 17:03:46 +0100 [thread overview]
Message-ID: <156657622663.4019.7120019667773615280@skylake-alporthouse-com> (raw)
In-Reply-To: <87o90fub1z.fsf@gaia.fi.intel.com>
Quoting Mika Kuoppala (2019-08-23 17:00:08)
> Chris Wilson <chris@chris-wilson.co.uk> writes:
>
> > Coming up next, we will want to manipulate the pin_global counter
> > outside of the principle locks, so convert it to an atomic.
> >
>
> I am not yet up to speed on pin_global but
> being part of a series where where this needs
> to be atomic, the patch does what it says on the tin.
pin_global really started off life as a means to keep the shrinker at
bay. It then grew as a marker for display objects in GEM, but really we
can use obj->frontbuffer now for that role. And we already use
obj->frontbuffer to delay shrinking of those objects.
Hmm. That might work.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-08-23 16:03 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 13:26 vm->mutex Chris Wilson
2019-08-23 13:26 ` [PATCH 01/15] drm/i915: Hold irq-off for the entire fake lock period Chris Wilson
2019-08-23 13:26 ` [PATCH 02/15] drm/i915/gtt: Preallocate Braswell top-level page directory Chris Wilson
2019-08-23 14:14 ` [PATCH v3] Do we need to posting-read after ggtt insert-page? Chris Wilson
2019-08-23 14:14 ` Chris Wilson
2019-08-23 14:14 ` [PATCH v3] drm/i915/gtt: Preallocate Braswell top-level page directory Chris Wilson
2019-08-23 13:26 ` [PATCH 03/15] drm/i915/selftests: Teach igt_gpu_fill_dw() to take intel_context Chris Wilson
2019-08-23 16:45 ` [PATCH] " Chris Wilson
2019-08-23 13:26 ` [PATCH 04/15] dma-fence: Serialise signal enabling (dma_fence_enable_sw_signaling) Chris Wilson
2019-08-23 13:26 ` [PATCH 05/15] drm/i915: Make shrink/unshrink be atomic Chris Wilson
2019-08-23 13:26 ` [PATCH 06/15] drm/i915: Mark up obj->pin_global as being atomic Chris Wilson
2019-08-23 16:00 ` Mika Kuoppala
2019-08-23 16:03 ` Chris Wilson [this message]
2019-08-23 13:26 ` [PATCH 07/15] drm/i915: Only track bound elements of the GTT Chris Wilson
2019-08-23 13:26 ` [PATCH 08/15] drm/i915: Make i915_vma.flags atomic_t for mutex reduction Chris Wilson
2019-08-23 13:26 ` [PATCH 09/15] drm/i915: Mark up address spaces that may need to allocate Chris Wilson
2019-08-23 13:26 ` [PATCH 10/15] drm/i915: Pull i915_vma_pin under the vm->mutex Chris Wilson
2019-08-23 13:26 ` [PATCH 11/15] drm/i915: Push the i915_active.retire into a worker Chris Wilson
2019-08-23 13:26 ` [PATCH 12/15] drm/i915: Coordinate i915_active with its own mutex Chris Wilson
2019-08-23 13:26 ` [PATCH 13/15] drm/i915: Move idle barrier cleanup into engine-pm Chris Wilson
2019-08-23 13:26 ` [PATCH 14/15] drm/i915: Drop struct_mutex from around i915_retire_requests() Chris Wilson
2019-08-23 13:27 ` [PATCH 15/15] drm/i915: Serialise the fill BLT with the vma pinning Chris Wilson
2019-08-23 16:48 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/15] drm/i915: Hold irq-off for the entire fake lock period (rev3) Patchwork
2019-08-23 17:43 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-08-23 20:06 ` ✗ Fi.CI.BAT: failure for series starting with [01/15] drm/i915: Hold irq-off for the entire fake lock period (rev4) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=156657622663.4019.7120019667773615280@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.