From: Chris Wilson <chris@chris-wilson.co.uk>
To: Stuart Summers <stuart.summers@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 07/11] drm/i915: Use subslice stride to set subslices for a given slice
Date: Fri, 23 Aug 2019 17:06:08 +0100 [thread overview]
Message-ID: <156657636827.4019.3949216198348163988@skylake-alporthouse-com> (raw)
In-Reply-To: <20190823160307.180813-8-stuart.summers@intel.com>
Quoting Stuart Summers (2019-08-23 17:03:03)
> Add a subslice stride calculation when setting subslices. This
> aligns more closely with the userspace expectation of the subslice
> mask structure.
>
> v2: Use local variable for subslice_mask on HSW and
> clean up a few other subslice_mask local variable
> changes
> v3: Add GEM_BUG_ON for ss_stride to prevent array overflow (Chris)
> Split main set function and refactors in intel_device_info.c
> into separate patches (Chris)
> v4: Reduce ss_stride size check when setting subslices per slice
> based on actual expected max stride (Chris)
> Move that GEM_BUG_ON check for the ss_stride out to the patch
> which adds the ss_stride
> v5: Use memcpy instead of looping through each stride index
>
> Signed-off-by: Stuart Summers <stuart.summers@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-08-23 16:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 16:02 [PATCH 00/11] Refactor to expand subslice mask (rev 2) Stuart Summers
2019-08-23 16:02 ` [PATCH 01/11] drm/i915: Use variable for debugfs device status Stuart Summers
2019-08-23 16:02 ` [PATCH 02/11] drm/i915: Add function to set SSEU info per platform Stuart Summers
2019-08-23 16:02 ` [PATCH 03/11] drm/i915: Add subslice stride runtime parameter Stuart Summers
2019-08-23 16:03 ` [PATCH 04/11] drm/i915: Add EU " Stuart Summers
2019-08-23 16:03 ` [PATCH 05/11] drm/i915: Use local variables for subslice_mask for device info Stuart Summers
2019-08-23 16:03 ` [PATCH 06/11] drm/i915: Add function to set subslices Stuart Summers
2019-08-23 16:03 ` [PATCH 07/11] drm/i915: Use subslice stride to set subslices for a given slice Stuart Summers
2019-08-23 16:06 ` Chris Wilson [this message]
2019-08-23 16:03 ` [PATCH 08/11] drm/i915: Add function to determine if a slice has a subslice Stuart Summers
2019-08-23 16:03 ` [PATCH 09/11] drm/i915: Refactor instdone loops on new subslice functions Stuart Summers
2019-08-23 16:03 ` [PATCH 10/11] drm/i915: Add new function to copy subslices for a slice Stuart Summers
2019-08-23 16:03 ` [PATCH 11/11] drm/i915: Expand subslice mask Stuart Summers
2019-08-23 17:41 ` ✗ Fi.CI.CHECKPATCH: warning for Refactor to expand subslice mask (rev 2) Patchwork
2019-08-23 18:11 ` ✓ Fi.CI.BAT: success " Patchwork
2019-08-23 18:15 ` Chris Wilson
2019-08-24 18:47 ` ✓ Fi.CI.IGT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2019-08-22 18:32 [PATCH 00/11] " Stuart Summers
2019-08-22 18:32 ` [PATCH 07/11] drm/i915: Use subslice stride to set subslices for a given slice Stuart Summers
2019-08-22 22:43 ` Chris Wilson
2019-08-23 15:59 ` Summers, Stuart
2019-08-20 23:05 [PATCH 00/11] Refactor to expand subslice mask (rev 2) Stuart Summers
2019-08-20 23:05 ` [PATCH 07/11] drm/i915: Use subslice stride to set subslices for a given slice Stuart Summers
2019-08-21 22:36 ` Chris Wilson
2019-08-21 22:46 ` Summers, Stuart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=156657636827.4019.3949216198348163988@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stuart.summers@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.