Re: [Qemu-devel] [PATCH v3 0/4] colo: Add support for continious replication

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/cover.1567500411.git.lukasstraub2@web.de/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v3 0/4] colo: Add support for continious replication
Type: series
Message-id: cover.1567500411.git.lukasstraub2@web.de

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
0a1cf27 colo: Update Documentation for continious replication
c789287 net/filter.c: Add Options to insert filters anywhere in the filter list
81d0607 tests/test-replication.c: Add test for ignoring requests after failover
a177f86 block/replication.c: Ignore requests after failover

=== OUTPUT BEGIN ===
1/4 Checking commit a177f86211a7 (block/replication.c: Ignore requests after failover)
2/4 Checking commit 81d060732781 (tests/test-replication.c: Add test for ignoring requests after failover)
ERROR: space prohibited after that open parenthesis '('
#41: FILE: tests/test-replication.c:514:
+    replication_stop_all( true, &local_err);

ERROR: space prohibited after that open parenthesis '('
#55: FILE: tests/test-replication.c:528:
+    replication_stop_all( true, &local_err);

total: 2 errors, 0 warnings, 64 lines checked

Patch 2/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/4 Checking commit c78928785a9f (net/filter.c: Add Options to insert filters anywhere in the filter list)
4/4 Checking commit 0a1cf27070de (colo: Update Documentation for continious replication)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/cover.1567500411.git.lukasstraub2@web.de/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com