From: "Rafał Miłecki" <zajec5@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH net-next 0/4] net: dsa: b53: Clean up CPU/IMP ports
Date: Fri, 17 Sep 2021 00:19:02 +0200 [thread overview]
Message-ID: <1568bbc3-1652-7d01-2fc7-cb4189c71ad2@gmail.com> (raw)
In-Reply-To: <a8a684ce-bede-b1f1-1f7a-31e71dca3fd3@gmail.com>
On 16.09.2021 23:46, Florian Fainelli wrote:
> On 9/16/21 9:23 AM, Florian Fainelli wrote:
>> On 9/16/21 5:03 AM, Rafał Miłecki wrote:
>>> From: Rafał Miłecki <rafal@milecki.pl>
>>>
>>> This has been tested on:
>>>
>>> 1. Luxul XBR-4500 with used CPU port 5
>>> [ 8.361438] b53-srab-switch 18007000.ethernet-switch: found switch: BCM53012, rev 0
>>>
>>> 2. Netgear R8000 with used CPU port 8
>>> [ 4.453858] b53-srab-switch 18007000.ethernet-switch: found switch: BCM53012, rev 5
>>
>> These look good at first glance, let me give them a try on 7445 and 7278
>> at least before responding with Reviewed-by/Tested-by tags, thanks!
>>
> Found some issues on 7445 and 7278 while moving to the latest net-next
> which I will be addressing but this worked nicely.
>
> What do you think about removing dev->enabled_ports and
> b53_for_each_port entirely and using a DSA helper that iterates over the
> switch's port list? Now that we have dev->num_ports accurately reflect
> the number of ports it should be equivalent.
The limitation I see in DSA is skipping unavailable ports. E.g. BCM5301x
switches that don't have port 6. The closest match for such case I found
is DSA_PORT_TYPE_UNUSED but I'm not sure if it's enough to handle those
cases.
That DSA_PORT_TYPE_UNUSED would probably require investigating DSA & b53
behaviour *and* discussing it with DSA maintainer to make sure we don't
abuse that.
next prev parent reply other threads:[~2021-09-16 22:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 12:03 [PATCH net-next 0/4] net: dsa: b53: Clean up CPU/IMP ports Rafał Miłecki
2021-09-16 12:03 ` [PATCH net-next 1/4] net: dsa: b53: Include all ports in "enabled_ports" Rafał Miłecki
2021-09-16 21:44 ` Florian Fainelli
2021-09-16 12:03 ` [PATCH net-next 2/4] net: dsa: b53: Drop BCM5301x workaround for a wrong CPU/IMP port Rafał Miłecki
2021-09-16 21:44 ` Florian Fainelli
2021-09-16 12:03 ` [PATCH net-next 3/4] net: dsa: b53: Improve flow control setup on BCM5301x Rafał Miłecki
2021-09-16 21:44 ` Florian Fainelli
2021-09-16 12:03 ` [PATCH net-next 4/4] net: dsa: b53: Drop unused "cpu_port" field Rafał Miłecki
2021-09-16 21:44 ` Florian Fainelli
2021-09-16 16:23 ` [PATCH net-next 0/4] net: dsa: b53: Clean up CPU/IMP ports Florian Fainelli
2021-09-16 21:46 ` Florian Fainelli
2021-09-16 22:19 ` Rafał Miłecki [this message]
2021-09-17 10:00 ` Vladimir Oltean
2021-09-17 12:21 ` Andrew Lunn
2021-09-17 12:31 ` Vladimir Oltean
2021-09-17 16:39 ` Florian Fainelli
2021-09-17 2:58 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1568bbc3-1652-7d01-2fc7-cb4189c71ad2@gmail.com \
--to=zajec5@gmail.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=rafal@milecki.pl \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.