All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] drivers: firmware: xilinx: Add support for versal soc
@ 2019-09-27 19:40 ` Jolly Shah
  0 siblings, 0 replies; 12+ messages in thread
From: Jolly Shah @ 2019-09-27 19:40 UTC (permalink / raw)
  To: ard.biesheuvel, mingo, gregkh, matt, sudeep.holla, hkallweit1,
	keescook, dmitry.torokhov, michal.simek
  Cc: rajanv, linux-arm-kernel, linux-kernel, Jolly Shah

Versal is xilinx's next generation soc. This patch adds
driver support required to be compatible with versal device.

Jolly Shah (2):
  dt-bindings: firmware: Add bindings for Versal firmware
  drivers: firmware: xilinx: Add support for versal soc

 .../bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt    | 16 +++++++++++++++-
 drivers/firmware/xilinx/zynqmp.c                         |  8 ++++++--
 2 files changed, 21 insertions(+), 3 deletions(-)

-- 
2.7.4


^ permalink raw reply	[flat|nested] 12+ messages in thread
* [PATCH 0/2] drivers: firmware: xilinx: Add support for versal soc
@ 2019-09-27 19:40 ` Jolly Shah
  0 siblings, 0 replies; 12+ messages in thread
From: Jolly Shah @ 2019-09-27 19:40 UTC (permalink / raw)
  To: ard.biesheuvel, mingo, gregkh, matt, sudeep.holla, hkallweit1,
	keescook, dmitry.torokhov, michal.simek
  Cc: Jolly Shah, rajanv, linux-kernel, linux-arm-kernel

Versal is xilinx's next generation soc. This patch adds
driver support required to be compatible with versal device.

Jolly Shah (2):
  dt-bindings: firmware: Add bindings for Versal firmware
  drivers: firmware: xilinx: Add support for versal soc

 .../bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt    | 16 +++++++++++++++-
 drivers/firmware/xilinx/zynqmp.c                         |  8 ++++++--
 2 files changed, 21 insertions(+), 3 deletions(-)

-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [PATCH 1/2] dt-bindings: firmware: Add bindings for Versal firmware
  2019-09-27 19:40 ` Jolly Shah
@ 2019-09-27 19:40   ` Jolly Shah
  -1 siblings, 0 replies; 12+ messages in thread
From: Jolly Shah @ 2019-09-27 19:40 UTC (permalink / raw)
  To: ard.biesheuvel, mingo, gregkh, matt, sudeep.holla, hkallweit1,
	keescook, dmitry.torokhov, michal.simek
  Cc: rajanv, linux-arm-kernel, linux-kernel, Jolly Shah

ZynqMP firmware driver can be used for versal also.
Add versal compatible string to zynqmp firmware driver
doc.

Signed-off-by: Jolly Shah <jolly.shah@xilinx.com>
---
 .../bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt    | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt
index a4fe136..18c3aea 100644
--- a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt
+++ b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt
@@ -11,7 +11,9 @@ power management service, FPGA service and other platform management
 services.
 
 Required properties:
- - compatible:	Must contain:	"xlnx,zynqmp-firmware"
+ - compatible:	Must contain any of below:
+		"xlnx,zynqmp-firmware" for Zynq Ultrascale+ MPSoC
+		"xlnx,versal-firmware" for Versal
  - method:	The method of calling the PM-API firmware layer.
 		Permitted values are:
 		  - "smc" : SMC #0, following the SMCCC
@@ -21,6 +23,8 @@ Required properties:
 Example
 -------
 
+Zynq Ultrascale+ MPSoC
+----------------------
 firmware {
 	zynqmp_firmware: zynqmp-firmware {
 		compatible = "xlnx,zynqmp-firmware";
@@ -28,3 +32,13 @@ firmware {
 		...
 	};
 };
+
+Versal
+------
+firmware {
+	versal_firmware: versal-firmware {
+		compatible = "xlnx,versal-firmware";
+		method = "smc";
+		...
+	};
+};
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH 1/2] dt-bindings: firmware: Add bindings for Versal firmware
@ 2019-09-27 19:40   ` Jolly Shah
  0 siblings, 0 replies; 12+ messages in thread
From: Jolly Shah @ 2019-09-27 19:40 UTC (permalink / raw)
  To: ard.biesheuvel, mingo, gregkh, matt, sudeep.holla, hkallweit1,
	keescook, dmitry.torokhov, michal.simek
  Cc: Jolly Shah, rajanv, linux-kernel, linux-arm-kernel

ZynqMP firmware driver can be used for versal also.
Add versal compatible string to zynqmp firmware driver
doc.

Signed-off-by: Jolly Shah <jolly.shah@xilinx.com>
---
 .../bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt    | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt
index a4fe136..18c3aea 100644
--- a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt
+++ b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt
@@ -11,7 +11,9 @@ power management service, FPGA service and other platform management
 services.
 
 Required properties:
- - compatible:	Must contain:	"xlnx,zynqmp-firmware"
+ - compatible:	Must contain any of below:
+		"xlnx,zynqmp-firmware" for Zynq Ultrascale+ MPSoC
+		"xlnx,versal-firmware" for Versal
  - method:	The method of calling the PM-API firmware layer.
 		Permitted values are:
 		  - "smc" : SMC #0, following the SMCCC
@@ -21,6 +23,8 @@ Required properties:
 Example
 -------
 
+Zynq Ultrascale+ MPSoC
+----------------------
 firmware {
 	zynqmp_firmware: zynqmp-firmware {
 		compatible = "xlnx,zynqmp-firmware";
@@ -28,3 +32,13 @@ firmware {
 		...
 	};
 };
+
+Versal
+------
+firmware {
+	versal_firmware: versal-firmware {
+		compatible = "xlnx,versal-firmware";
+		method = "smc";
+		...
+	};
+};
-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH 2/2] drivers: firmware: xilinx: Add support for versal soc
  2019-09-27 19:40 ` Jolly Shah
@ 2019-09-27 19:40   ` Jolly Shah
  -1 siblings, 0 replies; 12+ messages in thread
From: Jolly Shah @ 2019-09-27 19:40 UTC (permalink / raw)
  To: ard.biesheuvel, mingo, gregkh, matt, sudeep.holla, hkallweit1,
	keescook, dmitry.torokhov, michal.simek
  Cc: rajanv, linux-arm-kernel, linux-kernel, Jolly Shah

Versal is xilinx's next generation soc. This patch adds
driver support required to be compatible with versal device.

Signed-off-by: Jolly Shah <jolly.shah@xilinx.com>
---
 drivers/firmware/xilinx/zynqmp.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c
index fd3d837..75bdfaa 100644
--- a/drivers/firmware/xilinx/zynqmp.c
+++ b/drivers/firmware/xilinx/zynqmp.c
@@ -711,8 +711,11 @@ static int zynqmp_firmware_probe(struct platform_device *pdev)
 	int ret;
 
 	np = of_find_compatible_node(NULL, NULL, "xlnx,zynqmp");
-	if (!np)
-		return 0;
+	if (!np) {
+		np = of_find_compatible_node(NULL, NULL, "xlnx,versal");
+		if (!np)
+			return 0;
+	}
 	of_node_put(np);
 
 	ret = get_set_conduit_method(dev->of_node);
@@ -770,6 +773,7 @@ static int zynqmp_firmware_remove(struct platform_device *pdev)
 
 static const struct of_device_id zynqmp_firmware_of_match[] = {
 	{.compatible = "xlnx,zynqmp-firmware"},
+	{.compatible = "xlnx,versal-firmware"},
 	{},
 };
 MODULE_DEVICE_TABLE(of, zynqmp_firmware_of_match);
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH 2/2] drivers: firmware: xilinx: Add support for versal soc
@ 2019-09-27 19:40   ` Jolly Shah
  0 siblings, 0 replies; 12+ messages in thread
From: Jolly Shah @ 2019-09-27 19:40 UTC (permalink / raw)
  To: ard.biesheuvel, mingo, gregkh, matt, sudeep.holla, hkallweit1,
	keescook, dmitry.torokhov, michal.simek
  Cc: Jolly Shah, rajanv, linux-kernel, linux-arm-kernel

Versal is xilinx's next generation soc. This patch adds
driver support required to be compatible with versal device.

Signed-off-by: Jolly Shah <jolly.shah@xilinx.com>
---
 drivers/firmware/xilinx/zynqmp.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c
index fd3d837..75bdfaa 100644
--- a/drivers/firmware/xilinx/zynqmp.c
+++ b/drivers/firmware/xilinx/zynqmp.c
@@ -711,8 +711,11 @@ static int zynqmp_firmware_probe(struct platform_device *pdev)
 	int ret;
 
 	np = of_find_compatible_node(NULL, NULL, "xlnx,zynqmp");
-	if (!np)
-		return 0;
+	if (!np) {
+		np = of_find_compatible_node(NULL, NULL, "xlnx,versal");
+		if (!np)
+			return 0;
+	}
 	of_node_put(np);
 
 	ret = get_set_conduit_method(dev->of_node);
@@ -770,6 +773,7 @@ static int zynqmp_firmware_remove(struct platform_device *pdev)
 
 static const struct of_device_id zynqmp_firmware_of_match[] = {
 	{.compatible = "xlnx,zynqmp-firmware"},
+	{.compatible = "xlnx,versal-firmware"},
 	{},
 };
 MODULE_DEVICE_TABLE(of, zynqmp_firmware_of_match);
-- 
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] dt-bindings: firmware: Add bindings for Versal firmware
  2019-09-27 19:40   ` Jolly Shah
@ 2019-10-04 16:18     ` Greg KH
  -1 siblings, 0 replies; 12+ messages in thread
From: Greg KH @ 2019-10-04 16:18 UTC (permalink / raw)
  To: Jolly Shah
  Cc: ard.biesheuvel, mingo, matt, sudeep.holla, hkallweit1, keescook,
	dmitry.torokhov, michal.simek, rajanv, linux-arm-kernel,
	linux-kernel

On Fri, Sep 27, 2019 at 12:40:05PM -0700, Jolly Shah wrote:
> ZynqMP firmware driver can be used for versal also.
> Add versal compatible string to zynqmp firmware driver
> doc.
> 
> Signed-off-by: Jolly Shah <jolly.shah@xilinx.com>
> ---
>  .../bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt    | 16 +++++++++++++++-
>  1 file changed, 15 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt
> index a4fe136..18c3aea 100644
> --- a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt
> +++ b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt
> @@ -11,7 +11,9 @@ power management service, FPGA service and other platform management
>  services.
>  
>  Required properties:
> - - compatible:	Must contain:	"xlnx,zynqmp-firmware"
> + - compatible:	Must contain any of below:
> +		"xlnx,zynqmp-firmware" for Zynq Ultrascale+ MPSoC
> +		"xlnx,versal-firmware" for Versal
>   - method:	The method of calling the PM-API firmware layer.
>  		Permitted values are:
>  		  - "smc" : SMC #0, following the SMCCC
> @@ -21,6 +23,8 @@ Required properties:
>  Example
>  -------
>  
> +Zynq Ultrascale+ MPSoC
> +----------------------
>  firmware {
>  	zynqmp_firmware: zynqmp-firmware {
>  		compatible = "xlnx,zynqmp-firmware";
> @@ -28,3 +32,13 @@ firmware {
>  		...
>  	};
>  };
> +
> +Versal
> +------
> +firmware {
> +	versal_firmware: versal-firmware {
> +		compatible = "xlnx,versal-firmware";
> +		method = "smc";
> +		...
> +	};
> +};
> -- 
> 2.7.4
> 


For new dt bindings, don't you have to cc: the dt maintainers and
mailing list?  I can't take the patch until I get an ack from them.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] dt-bindings: firmware: Add bindings for Versal firmware
@ 2019-10-04 16:18     ` Greg KH
  0 siblings, 0 replies; 12+ messages in thread
From: Greg KH @ 2019-10-04 16:18 UTC (permalink / raw)
  To: Jolly Shah
  Cc: keescook, ard.biesheuvel, matt, dmitry.torokhov, michal.simek,
	linux-kernel, rajanv, sudeep.holla, mingo, linux-arm-kernel,
	hkallweit1

On Fri, Sep 27, 2019 at 12:40:05PM -0700, Jolly Shah wrote:
> ZynqMP firmware driver can be used for versal also.
> Add versal compatible string to zynqmp firmware driver
> doc.
> 
> Signed-off-by: Jolly Shah <jolly.shah@xilinx.com>
> ---
>  .../bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt    | 16 +++++++++++++++-
>  1 file changed, 15 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt
> index a4fe136..18c3aea 100644
> --- a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt
> +++ b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt
> @@ -11,7 +11,9 @@ power management service, FPGA service and other platform management
>  services.
>  
>  Required properties:
> - - compatible:	Must contain:	"xlnx,zynqmp-firmware"
> + - compatible:	Must contain any of below:
> +		"xlnx,zynqmp-firmware" for Zynq Ultrascale+ MPSoC
> +		"xlnx,versal-firmware" for Versal
>   - method:	The method of calling the PM-API firmware layer.
>  		Permitted values are:
>  		  - "smc" : SMC #0, following the SMCCC
> @@ -21,6 +23,8 @@ Required properties:
>  Example
>  -------
>  
> +Zynq Ultrascale+ MPSoC
> +----------------------
>  firmware {
>  	zynqmp_firmware: zynqmp-firmware {
>  		compatible = "xlnx,zynqmp-firmware";
> @@ -28,3 +32,13 @@ firmware {
>  		...
>  	};
>  };
> +
> +Versal
> +------
> +firmware {
> +	versal_firmware: versal-firmware {
> +		compatible = "xlnx,versal-firmware";
> +		method = "smc";
> +		...
> +	};
> +};
> -- 
> 2.7.4
> 


For new dt bindings, don't you have to cc: the dt maintainers and
mailing list?  I can't take the patch until I get an ack from them.

thanks,

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] dt-bindings: firmware: Add bindings for Versal firmware
  2019-10-04 16:18     ` Greg KH
@ 2019-10-07  6:14       ` Michal Simek
  -1 siblings, 0 replies; 12+ messages in thread
From: Michal Simek @ 2019-10-07  6:14 UTC (permalink / raw)
  To: Greg KH, Jolly Shah
  Cc: ard.biesheuvel, mingo, matt, sudeep.holla, hkallweit1, keescook,
	dmitry.torokhov, michal.simek, rajanv, linux-arm-kernel,
	linux-kernel

On 04. 10. 19 18:18, Greg KH wrote:
> On Fri, Sep 27, 2019 at 12:40:05PM -0700, Jolly Shah wrote:
>> ZynqMP firmware driver can be used for versal also.
>> Add versal compatible string to zynqmp firmware driver
>> doc.
>>
>> Signed-off-by: Jolly Shah <jolly.shah@xilinx.com>
>> ---
>>  .../bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt    | 16 +++++++++++++++-
>>  1 file changed, 15 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt
>> index a4fe136..18c3aea 100644
>> --- a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt
>> +++ b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt
>> @@ -11,7 +11,9 @@ power management service, FPGA service and other platform management
>>  services.
>>  
>>  Required properties:
>> - - compatible:	Must contain:	"xlnx,zynqmp-firmware"
>> + - compatible:	Must contain any of below:
>> +		"xlnx,zynqmp-firmware" for Zynq Ultrascale+ MPSoC
>> +		"xlnx,versal-firmware" for Versal
>>   - method:	The method of calling the PM-API firmware layer.
>>  		Permitted values are:
>>  		  - "smc" : SMC #0, following the SMCCC
>> @@ -21,6 +23,8 @@ Required properties:
>>  Example
>>  -------
>>  
>> +Zynq Ultrascale+ MPSoC
>> +----------------------
>>  firmware {
>>  	zynqmp_firmware: zynqmp-firmware {
>>  		compatible = "xlnx,zynqmp-firmware";
>> @@ -28,3 +32,13 @@ firmware {
>>  		...
>>  	};
>>  };
>> +
>> +Versal
>> +------
>> +firmware {
>> +	versal_firmware: versal-firmware {
>> +		compatible = "xlnx,versal-firmware";
>> +		method = "smc";
>> +		...
>> +	};
>> +};
>> -- 
>> 2.7.4
>>
> 
> 
> For new dt bindings, don't you have to cc: the dt maintainers and
> mailing list?  I can't take the patch until I get an ack from them.

Yes dt guys should be in CC and normally I am taking this via ARM soc tree.

Jolly: Please resend

Thanks,
Michal

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] dt-bindings: firmware: Add bindings for Versal firmware
@ 2019-10-07  6:14       ` Michal Simek
  0 siblings, 0 replies; 12+ messages in thread
From: Michal Simek @ 2019-10-07  6:14 UTC (permalink / raw)
  To: Greg KH, Jolly Shah
  Cc: keescook, ard.biesheuvel, matt, dmitry.torokhov, michal.simek,
	linux-kernel, rajanv, sudeep.holla, mingo, linux-arm-kernel,
	hkallweit1

On 04. 10. 19 18:18, Greg KH wrote:
> On Fri, Sep 27, 2019 at 12:40:05PM -0700, Jolly Shah wrote:
>> ZynqMP firmware driver can be used for versal also.
>> Add versal compatible string to zynqmp firmware driver
>> doc.
>>
>> Signed-off-by: Jolly Shah <jolly.shah@xilinx.com>
>> ---
>>  .../bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt    | 16 +++++++++++++++-
>>  1 file changed, 15 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt
>> index a4fe136..18c3aea 100644
>> --- a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt
>> +++ b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt
>> @@ -11,7 +11,9 @@ power management service, FPGA service and other platform management
>>  services.
>>  
>>  Required properties:
>> - - compatible:	Must contain:	"xlnx,zynqmp-firmware"
>> + - compatible:	Must contain any of below:
>> +		"xlnx,zynqmp-firmware" for Zynq Ultrascale+ MPSoC
>> +		"xlnx,versal-firmware" for Versal
>>   - method:	The method of calling the PM-API firmware layer.
>>  		Permitted values are:
>>  		  - "smc" : SMC #0, following the SMCCC
>> @@ -21,6 +23,8 @@ Required properties:
>>  Example
>>  -------
>>  
>> +Zynq Ultrascale+ MPSoC
>> +----------------------
>>  firmware {
>>  	zynqmp_firmware: zynqmp-firmware {
>>  		compatible = "xlnx,zynqmp-firmware";
>> @@ -28,3 +32,13 @@ firmware {
>>  		...
>>  	};
>>  };
>> +
>> +Versal
>> +------
>> +firmware {
>> +	versal_firmware: versal-firmware {
>> +		compatible = "xlnx,versal-firmware";
>> +		method = "smc";
>> +		...
>> +	};
>> +};
>> -- 
>> 2.7.4
>>
> 
> 
> For new dt bindings, don't you have to cc: the dt maintainers and
> mailing list?  I can't take the patch until I get an ack from them.

Yes dt guys should be in CC and normally I am taking this via ARM soc tree.

Jolly: Please resend

Thanks,
Michal

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 12+ messages in thread
* RE: [PATCH 1/2] dt-bindings: firmware: Add bindings for Versal firmware
  2019-10-07  6:14       ` Michal Simek
@ 2019-10-07 18:57         ` Jolly Shah
  -1 siblings, 0 replies; 12+ messages in thread
From: Jolly Shah @ 2019-10-07 18:57 UTC (permalink / raw)
  To: Michal Simek, Greg KH
  Cc: ard.biesheuvel, mingo, matt, sudeep.holla, hkallweit1, keescook,
	dmitry.torokhov, Michal Simek, Rajan Vaja, linux-arm-kernel,
	linux-kernel

Hi Michal and Greg,

> -----Original Message-----
> From: Michal Simek <michal.simek@xilinx.com>
> Sent: Sunday, October 06, 2019 11:14 PM
> To: Greg KH <gregkh@linuxfoundation.org>; Jolly Shah <JOLLYS@xilinx.com>
> Cc: ard.biesheuvel@linaro.org; mingo@kernel.org; matt@codeblueprint.co.uk;
> sudeep.holla@arm.com; hkallweit1@gmail.com; keescook@chromium.org;
> dmitry.torokhov@gmail.com; Michal Simek <michals@xilinx.com>; Rajan Vaja
> <RAJANV@xilinx.com>; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH 1/2] dt-bindings: firmware: Add bindings for Versal firmware
> 
> On 04. 10. 19 18:18, Greg KH wrote:
> > On Fri, Sep 27, 2019 at 12:40:05PM -0700, Jolly Shah wrote:
> >> ZynqMP firmware driver can be used for versal also.
> >> Add versal compatible string to zynqmp firmware driver
> >> doc.
> >>
> >> Signed-off-by: Jolly Shah <jolly.shah@xilinx.com>
> >> ---
> >>  .../bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt    | 16
> +++++++++++++++-
> >>  1 file changed, 15 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-
> firmware.txt
> b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-
> firmware.txt
> >> index a4fe136..18c3aea 100644
> >> --- a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-
> firmware.txt
> >> +++ b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-
> firmware.txt
> >> @@ -11,7 +11,9 @@ power management service, FPGA service and other
> platform management
> >>  services.
> >>
> >>  Required properties:
> >> - - compatible:	Must contain:	"xlnx,zynqmp-firmware"
> >> + - compatible:	Must contain any of below:
> >> +		"xlnx,zynqmp-firmware" for Zynq Ultrascale+ MPSoC
> >> +		"xlnx,versal-firmware" for Versal
> >>   - method:	The method of calling the PM-API firmware layer.
> >>  		Permitted values are:
> >>  		  - "smc" : SMC #0, following the SMCCC
> >> @@ -21,6 +23,8 @@ Required properties:
> >>  Example
> >>  -------
> >>
> >> +Zynq Ultrascale+ MPSoC
> >> +----------------------
> >>  firmware {
> >>  	zynqmp_firmware: zynqmp-firmware {
> >>  		compatible = "xlnx,zynqmp-firmware";
> >> @@ -28,3 +32,13 @@ firmware {
> >>  		...
> >>  	};
> >>  };
> >> +
> >> +Versal
> >> +------
> >> +firmware {
> >> +	versal_firmware: versal-firmware {
> >> +		compatible = "xlnx,versal-firmware";
> >> +		method = "smc";
> >> +		...
> >> +	};
> >> +};
> >> --
> >> 2.7.4
> >>
> >
> >
> > For new dt bindings, don't you have to cc: the dt maintainers and
> > mailing list?  I can't take the patch until I get an ack from them.
> 
> Yes dt guys should be in CC and normally I am taking this via ARM soc tree.
> 
> Jolly: Please resend
> 

Sorry missed it earlier. Sent v2 including DT maintainers.

Thanks,
Jolly Shah

> Thanks,
> Michal

^ permalink raw reply	[flat|nested] 12+ messages in thread
* RE: [PATCH 1/2] dt-bindings: firmware: Add bindings for Versal firmware
@ 2019-10-07 18:57         ` Jolly Shah
  0 siblings, 0 replies; 12+ messages in thread
From: Jolly Shah @ 2019-10-07 18:57 UTC (permalink / raw)
  To: Michal Simek, Greg KH
  Cc: keescook, ard.biesheuvel, matt, dmitry.torokhov, linux-kernel,
	Rajan Vaja, Michal Simek, sudeep.holla, mingo, linux-arm-kernel,
	hkallweit1

Hi Michal and Greg,

> -----Original Message-----
> From: Michal Simek <michal.simek@xilinx.com>
> Sent: Sunday, October 06, 2019 11:14 PM
> To: Greg KH <gregkh@linuxfoundation.org>; Jolly Shah <JOLLYS@xilinx.com>
> Cc: ard.biesheuvel@linaro.org; mingo@kernel.org; matt@codeblueprint.co.uk;
> sudeep.holla@arm.com; hkallweit1@gmail.com; keescook@chromium.org;
> dmitry.torokhov@gmail.com; Michal Simek <michals@xilinx.com>; Rajan Vaja
> <RAJANV@xilinx.com>; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH 1/2] dt-bindings: firmware: Add bindings for Versal firmware
> 
> On 04. 10. 19 18:18, Greg KH wrote:
> > On Fri, Sep 27, 2019 at 12:40:05PM -0700, Jolly Shah wrote:
> >> ZynqMP firmware driver can be used for versal also.
> >> Add versal compatible string to zynqmp firmware driver
> >> doc.
> >>
> >> Signed-off-by: Jolly Shah <jolly.shah@xilinx.com>
> >> ---
> >>  .../bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt    | 16
> +++++++++++++++-
> >>  1 file changed, 15 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-
> firmware.txt
> b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-
> firmware.txt
> >> index a4fe136..18c3aea 100644
> >> --- a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-
> firmware.txt
> >> +++ b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-
> firmware.txt
> >> @@ -11,7 +11,9 @@ power management service, FPGA service and other
> platform management
> >>  services.
> >>
> >>  Required properties:
> >> - - compatible:	Must contain:	"xlnx,zynqmp-firmware"
> >> + - compatible:	Must contain any of below:
> >> +		"xlnx,zynqmp-firmware" for Zynq Ultrascale+ MPSoC
> >> +		"xlnx,versal-firmware" for Versal
> >>   - method:	The method of calling the PM-API firmware layer.
> >>  		Permitted values are:
> >>  		  - "smc" : SMC #0, following the SMCCC
> >> @@ -21,6 +23,8 @@ Required properties:
> >>  Example
> >>  -------
> >>
> >> +Zynq Ultrascale+ MPSoC
> >> +----------------------
> >>  firmware {
> >>  	zynqmp_firmware: zynqmp-firmware {
> >>  		compatible = "xlnx,zynqmp-firmware";
> >> @@ -28,3 +32,13 @@ firmware {
> >>  		...
> >>  	};
> >>  };
> >> +
> >> +Versal
> >> +------
> >> +firmware {
> >> +	versal_firmware: versal-firmware {
> >> +		compatible = "xlnx,versal-firmware";
> >> +		method = "smc";
> >> +		...
> >> +	};
> >> +};
> >> --
> >> 2.7.4
> >>
> >
> >
> > For new dt bindings, don't you have to cc: the dt maintainers and
> > mailing list?  I can't take the patch until I get an ack from them.
> 
> Yes dt guys should be in CC and normally I am taking this via ARM soc tree.
> 
> Jolly: Please resend
> 

Sorry missed it earlier. Sent v2 including DT maintainers.

Thanks,
Jolly Shah

> Thanks,
> Michal
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 12+ messages in thread
end of thread, other threads:[~2019-10-07 18:57 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-27 19:40 [PATCH 0/2] drivers: firmware: xilinx: Add support for versal soc Jolly Shah
2019-09-27 19:40 ` Jolly Shah
2019-09-27 19:40 ` [PATCH 1/2] dt-bindings: firmware: Add bindings for Versal firmware Jolly Shah
2019-09-27 19:40   ` Jolly Shah
2019-10-04 16:18   ` Greg KH
2019-10-04 16:18     ` Greg KH
2019-10-07  6:14     ` Michal Simek
2019-10-07  6:14       ` Michal Simek
2019-10-07 18:57       ` Jolly Shah
2019-10-07 18:57         ` Jolly Shah
2019-09-27 19:40 ` [PATCH 2/2] drivers: firmware: xilinx: Add support for versal soc Jolly Shah
2019-09-27 19:40   ` Jolly Shah

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.