From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFA8DC3F2CD for ; Mon, 2 Mar 2020 15:44:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AD6A922B48 for ; Mon, 2 Mar 2020 15:44:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727092AbgCBPoo (ORCPT ); Mon, 2 Mar 2020 10:44:44 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:32707 "EHLO relay1-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727083AbgCBPoo (ORCPT ); Mon, 2 Mar 2020 10:44:44 -0500 X-Originating-IP: 83.155.44.161 Received: from classic (mon69-7-83-155-44-161.fbx.proxad.net [83.155.44.161]) (Authenticated sender: hadess@hadess.net) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id AA12D240010; Mon, 2 Mar 2020 15:44:41 +0000 (UTC) Message-ID: <156a1f5fb89ccb8108d54376b45de6af93525368.camel@hadess.net> Subject: Re: [PATCH resend 04/10] Input: goodix - Add support for getting IRQ + reset GPIOs on Cherry Trail devices From: Bastien Nocera To: Hans de Goede , Dmitry Torokhov Cc: linux-input@vger.kernel.org, Dmitry Mastykin Date: Mon, 02 Mar 2020 16:44:41 +0100 In-Reply-To: <1b90d2d4-5cf4-3017-9e06-6a9187a73ca5@redhat.com> References: <20200221164735.508324-1-hdegoede@redhat.com> <20200221164735.508324-4-hdegoede@redhat.com> <1b90d2d4-5cf4-3017-9e06-6a9187a73ca5@redhat.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.35.92 (3.35.92-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Mon, 2020-03-02 at 16:40 +0100, Hans de Goede wrote: > > Does this mean we retry at most once? > > > Yes, we are not really "retrying", we are doing a 2 step > > probe: > > > > 1) First try to get the GPIOs without having done our heuristics and > > without having called devm_acpi_dev_add_driver_gpios(). This is for > > ACPI platforms extra GPIO info (including names) using the special > > ACPI "daffd814-6eba-4d8c-8a91-bc9bbf4aa301" UUID method. > > > > 2) If this fails then we add our own name to index mappings and > > get the GPIOs using those. Is there a better way to communicate that? Using a separate function for that piece of code, and maybe some comments to clarify what it's doing. Thanks for the other explanations.