All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 2/2] tests/kms_rotation_crc: Check requested format/mod combo is supported
Date: Mon,  7 Oct 2019 22:52:34 +0300	[thread overview]
Message-ID: <1570477954-3047-2-git-send-email-juhapekka.heikkila@gmail.com> (raw)
In-Reply-To: <1570477954-3047-1-git-send-email-juhapekka.heikkila@gmail.com>

Avoid failing test for wrong reasons.

Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
 tests/kms_rotation_crc.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
index 668c173..fe63311 100644
--- a/tests/kms_rotation_crc.c
+++ b/tests/kms_rotation_crc.c
@@ -251,6 +251,12 @@ static void prepare_fbs(data_t *data, igt_output_t *output,
 		igt_swap(w, h);
 	}
 
+	/* 
+	 * Just try here if requested tiling format is generally available,
+	 * if one format fail it will skip entire subtest.
+	 */
+	igt_require(igt_display_has_format_mod(display, pixel_format, tiling));
+
 	/*
 	 * Create a reference software rotated flip framebuffer.
 	 */
-- 
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2019-10-07 19:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-07 19:52 [igt-dev] [PATCH i-g-t 1/2] tests/kms_flip_tiling: Check requested format/mod combo is supported Juha-Pekka Heikkila
2019-10-07 19:52 ` Juha-Pekka Heikkila [this message]
2019-10-08 10:54   ` [igt-dev] [PATCH i-g-t 2/2] tests/kms_rotation_crc: " Kahola, Mika
2019-10-07 20:46 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/2] tests/kms_flip_tiling: " Patchwork
2019-10-07 22:16 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] tests/kms_flip_tiling: Check requested format/mod combo is supported (rev2) Patchwork
2019-10-08  3:42 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2019-10-08  5:21 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] tests/kms_flip_tiling: Check requested format/mod combo is supported (rev3) Patchwork
2019-10-08  6:43 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2019-10-08 10:52 ` [igt-dev] [PATCH i-g-t 1/2] tests/kms_flip_tiling: Check requested format/mod combo is supported Kahola, Mika

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1570477954-3047-2-git-send-email-juhapekka.heikkila@gmail.com \
    --to=juhapekka.heikkila@gmail.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.