From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 09/10] drm/i915: Replace hangcheck by heartbeats Date: Fri, 11 Oct 2019 16:06:03 +0100 Message-ID: <157080636308.31572.4047266278658870717@skylake-alporthouse-com> References: <20191010071434.31195-1-chris@chris-wilson.co.uk> <20191010071434.31195-9-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id 822EA6EC4F for ; Fri, 11 Oct 2019 15:06:08 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org UXVvdGluZyBUdnJ0a28gVXJzdWxpbiAoMjAxOS0xMC0xMSAxNToyNDoyMSkKPiAKPiBPbiAxMC8x MC8yMDE5IDA4OjE0LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gPiArY29uZmlnIERSTV9JOTE1X0hF QVJUQkVBVF9JTlRFUlZBTAo+ID4gKyAgICAgaW50ICJJbnRlcnZhbCBiZXR3ZWVuIGhlYXJ0YmVh dCBwdWxzZXMgKG1zKSIKPiA+ICsgICAgIGRlZmF1bHQgMjUwMCAjIG1pbGxpc2Vjb25kcwo+ID4g KyAgICAgaGVscAo+ID4gKyAgICAgICBXaGlsZSBhY3RpdmUgdGhlIGRyaXZlciB1c2VzIGEgcGVy aW9kaWMgcmVxdWVzdCwgYSBoZWFydGJlYXQsIHRvCj4gPiArICAgICAgIGNoZWNrIHRoZSB3ZWxs bmVzcyBvZiB0aGUgR1BVIGFuZCB0byByZWd1bGFybHkgZmx1c2ggc3RhdGUgY2hhbmdlcwo+ID4g KyAgICAgICAoaWRsZSBiYXJyaWVycykuCj4gCj4gU2hvdWxkIHRoaXMgYmUgc29tZWhvdyByZXdv cmRlZCB0byBiZSBtb3JlIGVuZCB1c2VyIGZyaWVuZGx5PyBNeSBpZGVhLCAKPiBtYXkgbmVlZCB0 byBiZSBjb3JyZWN0ZWQgZm9yIGJhZCBFbmdsaXNoOgoKRW5kIHVzZXIgZnJpZW5kbHkuIFN1cmUs IGJ1dCB0aGF0IG1lYW5zIEkgZGlkbid0IGhpZGUgdGhpcyB3ZWxsIGVub3VnaAo7KQogCj4gVGhl IGRyaXZlciBzZW5kcyBhIHBlcmlvZGljIGhlYXJ0YmVhdCBkb3duIGFsbCBhY3RpdmUgR1QgZW5n aW5lcyB0byAKPiBjaGVjayB0aGUgaGVhbHRoIG9mIHRoZSBHUFUgYW5kIHVuZGVydGFrZSByZWd1 bGFyIGhvdXNlLWtlZXBpbmcgb2YgCj4gaW50ZXJuYWwgZHJpdmVyIHN0YXRlLgo+IAo+IE1haW4g cG9pbnRzIGZyb20gdGhlIHVzZXIgcGVyc3BlY3RpdmU6ICJyZXF1ZXN0IiAtIHdoYWF0PyAiaWRs ZSAKPiBiYXJyaWVycyIgLSBkaXR0by4gIldlbGxuZXNzIiAtIGEgYml0IHVudXN1YWwgaW4gdGhp cyBjb250ZXh0LCBubz8KCj4gPiArc3RhdGljIHZvaWQgaGVhcnRiZWF0KHN0cnVjdCB3b3JrX3N0 cnVjdCAqd3JrKQo+ID4gK3sKPiA+ICsgICAgIHN0cnVjdCBpOTE1X3NjaGVkX2F0dHIgYXR0ciA9 IHsKPiA+ICsgICAgICAgICAgICAgLnByaW9yaXR5ID0gSTkxNV9VU0VSX1BSSU9SSVRZKEk5MTVf UFJJT1JJVFlfTUlOKSwKPiAKPiBZb3Ugd2VyZSBzYXlpbmcgaXQncyBiZXR0ZXIgdG8gc3RhcnQg ZnJvbSB6ZXJvLCByaWdodD8KClRoZSBmaXJzdCBidW1wLiBTdGFydGluZyBhdCBsb3dlc3QsIG1l YW5zIHJ1biB3aGVuIGZpcnN0IGlkbGUuIFRoZW4gd2UKanVtcCB0byAwIGFuZCBiZSBzY2hlZHVs ZWQgbGlrZSBhbnkgb3RoZXIgbm9ybWFsIHVzZXIuCgo+ID4gKyAgICAgfTsKPiA+ICsgICAgIHN0 cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSA9Cj4gPiArICAgICAgICAgICAgIGNvbnRhaW5l cl9vZih3cmssIHR5cGVvZigqZW5naW5lKSwgaGVhcnRiZWF0Lndvcmsud29yayk7Cj4gPiArICAg ICBzdHJ1Y3QgaW50ZWxfY29udGV4dCAqY2UgPSBlbmdpbmUtPmtlcm5lbF9jb250ZXh0Owo+ID4g KyAgICAgc3RydWN0IGk5MTVfcmVxdWVzdCAqcnE7Cj4gPiArCj4gPiArICAgICBpZiAoIWludGVs X2VuZ2luZV9wbV9nZXRfaWZfYXdha2UoZW5naW5lKSkKPiA+ICsgICAgICAgICAgICAgcmV0dXJu Owo+ID4gKwo+ID4gKyAgICAgcnEgPSBlbmdpbmUtPmhlYXJ0YmVhdC5zeXN0b2xlOwo+ID4gKyAg ICAgaWYgKHJxICYmIGk5MTVfcmVxdWVzdF9jb21wbGV0ZWQocnEpKSB7Cj4gPiArICAgICAgICAg ICAgIGk5MTVfcmVxdWVzdF9wdXQocnEpOwo+ID4gKyAgICAgICAgICAgICBlbmdpbmUtPmhlYXJ0 YmVhdC5zeXN0b2xlID0gTlVMTDsKPiA+ICsgICAgIH0KPiA+ICsKPiA+ICsgICAgIGlmIChpbnRl bF9ndF9pc193ZWRnZWQoZW5naW5lLT5ndCkpCj4gPiArICAgICAgICAgICAgIGdvdG8gb3V0Owo+ ID4gKwo+ID4gKyAgICAgaWYgKGVuZ2luZS0+aGVhcnRiZWF0LnN5c3RvbGUpIHsKPiA+ICsgICAg ICAgICAgICAgaWYgKElTX0VOQUJMRUQoQ09ORklHX0RSTV9JOTE1X0RFQlVHX0dFTSkpIHsKPiA+ ICsgICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgZHJtX3ByaW50ZXIgcCA9IGRybV9kZWJ1Z19w cmludGVyKF9fZnVuY19fKTsKPiA+ICsKPiA+ICsgICAgICAgICAgICAgICAgICAgICBpbnRlbF9l bmdpbmVfZHVtcChlbmdpbmUsICZwLAo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICIlcyBoZWFydGJlYXQgbm90IHRpY2tpbmdcbiIsCj4gPiArICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgZW5naW5lLT5uYW1lKTsKPiAKPiBUaGlzIGNvdWxk IHBlcmhhcHMgYmUgYmV0dGVyIG9ubHkgd2hlbiB3ZSBoYXZlIHJlYWNoZWQgYSBoaWdoZXIgcHJp b3JpdHkgCj4gYXR0ZW1wdC4gT2theSBpdCdzIHVuZGVyIERFQlVHX0dFTSBidXQgc3RpbGwsIG5v dCBzdXJlIHRoZXJlIGlzIHZhbHVlIGluIAo+IGJlaW5nIHNvIHBhbmlja3kgaWYgZm9yIGFueSBy ZWFzb24gcHJlZW1wdGlvbiBkb2VzIG5vdCB3b3JrLiBIZWFydGJlYXQgCj4gZG9lcyBub3QgZGVw ZW5kIG9uIHByZWVtcHRpb24gYXMgZmFyIGFzIEkgY291bGQgc3BvdCwgcmlnaHQ/CgpUaGUgY2hh bGxlbmdlIGlzIGV2aWRlbnQgYnkgdGhlIGVsc2UgcGF0aCB3aGVyZSB3ZSBpbW1lZGlhdGVseSBy ZXNldC4KSWYgd2UgY2F1c2UgYSBwcmVlbXB0aW9uIGV2ZW50IGZyb20gdGhlIGhlYXJ0YmVhdCAo ZXZlbiBzdHJpY3RseSBhdCBtaW4KcHJpbyB3ZSBjb3VsZCBjYXVzZSBhIHRpbWVzbGljZSB0byBl eHBpcmUpIGl0IGlzIHVzZWZ1bCB0byBoYXZlIHRoZQpkZWJ1ZyBpbiBkbWVzZyAoYXMgaW4gQ0kg d2UgZG9uJ3QgZ2V0IGVycm9yLXN0YXRlIHZlcnkgb2Z0ZW4pLgoKWWVzLCBJJ3ZlIHRyaWVkIHRy aW1taW5nIGl0IHRvIG9ubHkgb24gdGhlIHZpdGFsIHBhdGhzLCBidXQgc28gZmFyCmhhdmVuJ3Qg Zm91bmQgYSBzYXRpc2ZhY3RvcnkgbWVhbnMuCgpUbyBtYWtlIG1lIGhhcHB5IEkgdGhpbmsgSSBu ZWVkIHRvIHB1c2ggaXQgZG93biBpbnRvIHRoZSByZXNldCByb3V0aW5lcwp0aGVtc2VsdmVzLiBI bW0uIEV4Y2VwdCB0aG9zZSB3ZSBkZWZpbml0ZWx5IGRvbid0IHdhbnQgZG1lc2cgc3BhbSBhcwp0 aGV5IGdldCBydW5zIDEwcyBvZiB0aG91c2FuZHMgdGltZXMgZHVyaW5nIENJLgoKSXQnbGwgZG8g Zm9yIG5vdy4gSSdtIHN1cmUgd2UnbGwgZ2V0IHRpcmVkIG9mIGl0IGFuZCBmaW5kIGl0IGEgbmV3 IGhvbWUuCgo+ID4gK3N0YXRpYyBzdHJ1Y3Qga29ial9hdHRyaWJ1dGUgaGVhcnRiZWF0X2ludGVy dmFsX2F0dHIgPQo+ID4gK19fQVRUUihoZWFydGJlYXRfaW50ZXJ2YWxfbXMsIDA2MDAsIGhlYXJ0 YmVhdF9pbnRlcnZhbF9zaG93LCBoZWFydGJlYXRfaW50ZXJ2YWxfc3RvcmUpOwo+ID4gICAKPiA+ ICAgc3RhdGljIHZvaWQga29ial9lbmdpbmVfcmVsZWFzZShzdHJ1Y3Qga29iamVjdCAqa29iaikK PiA+ICAgewo+ID4gQEAgLTExNSw2ICsxNDEsOSBAQCB2b2lkIGludGVsX2VuZ2luZXNfYWRkX3N5 c2ZzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1KQo+ID4gICAgICAgICAgICAgICAmY2xh c3NfYXR0ci5hdHRyLAo+ID4gICAgICAgICAgICAgICAmaW5zdF9hdHRyLmF0dHIsCj4gPiAgICAg ICAgICAgICAgICZtbWlvX2F0dHIuYXR0ciwKPiA+ICsjaWYgQ09ORklHX0RSTV9JOTE1X0hFQVJU QkVBVF9JTlRFUlZBTAo+ID4gKyAgICAgICAgICAgICAmaGVhcnRiZWF0X2ludGVydmFsX2F0dHIu YXR0ciwKPiA+ICsjZW5kaWYKPiAKPiBQcmVzdW1hYmx5IGNvbXBpbGVyIGlzIGhhcHB5IChvciB0 aGUgbGlua2VyKSB3aXRoIG9ubHkgdGhpcyBwYXJ0IGdldHRpbmcgCj4gdGhlICNpZmRlZiB0cmVh dG1lbnQ/IChUaGUgc2hvdy9zdG9yZSBmdW5jdGlvbnMgYWJvdmUgZG9uJ3QgaGF2ZSBpdC4pCgpZ dXAsIGl0J3Mgbm90IGFubm95aW5nIGVub3VnaCB0byBjb21wbGFpbiBhYm91dCB0aGUgZGVhZCBn bG9iYWxzLiBBbHRob3VnaAppdCBzaG91bGQgYmUgbW9yZSB0aGFuIHNtYXJ0IGVub3VnaCB0byBy ZW1vdmUgdGhlbS4KLUNocmlzCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu dGVsLWdmeA==